| 2018-09-19 22:17:59 |
dann frazier |
bug |
|
|
added bug |
| 2018-09-19 22:18:08 |
dann frazier |
nominated for series |
|
Ubuntu Bionic |
|
| 2018-09-19 22:18:08 |
dann frazier |
bug task added |
|
linux (Ubuntu Bionic) |
|
| 2018-09-19 22:18:15 |
dann frazier |
linux (Ubuntu Bionic): status |
New |
In Progress |
|
| 2018-09-19 22:18:17 |
dann frazier |
linux (Ubuntu Bionic): assignee |
|
dann frazier (dannf) |
|
| 2018-09-19 22:20:54 |
dann frazier |
description |
[Impact]
Changing the channel parameters of an hns3 device (ethtool -L) has an unintended side-effect of resetting the ring parameters back to their defaults. If a user has applied custom ring parameters (ethtool -G), they will be lost.
[Test Case]
Set custom ring parameters:
$ sudo ethtool -G <hns3-dev> rx 512 tx 512
Verify the change:
$ sudo ethtool -g enp125s0f2
Ring parameters for enp125s0f2:
Pre-set maximums:
RX: 32768
RX Mini: 0
RX Jumbo: 0
TX: 32768
Current hardware settings:
RX: 512
RX Mini: 0
RX Jumbo: 0
TX: 512
Now modify the ring parameters:
sudo ethtool -L <hns3-dev> enp124s0f2 combined 4
And noticed that the channel parameters are now back at their defaults:
$ sudo ethtool -g enp125s0f2
Ring parameters for enp125s0f2:
Pre-set maximums:
RX: 32768
RX Mini: 0
RX Jumbo: 0
TX: 32768
Current hardware settings:
RX: 1024
RX Mini: 0
RX Jumbo: 0
TX: 1024
[Fix]
commit 128b900de7df567ca7ca063bf5da4ed0f357db8c
Author: Yunsheng Lin <linyunsheng@huawei.com>
Date: Tue Aug 14 17:13:16 2018 +0100
net: hns3: Fix desc num set to default when setting channel
[Regression Risk]
Localized to a single driver, tested on the one SoC that includes this device. |
[Impact]
Changing the channel parameters of an hns3 device (ethtool -L) has an unintended side-effect of resetting the ring parameters back to their defaults. If a user has applied custom ring parameters (ethtool -G), they will be lost.
[Test Case]
Set custom ring parameters:
$ sudo ethtool -G <hns3-dev> rx 512 tx 512
Verify the change:
$ sudo ethtool -g <hns3-dev>
Ring parameters for <hns3-dev>:
Pre-set maximums:
RX: 32768
RX Mini: 0
RX Jumbo: 0
TX: 32768
Current hardware settings:
RX: 512
RX Mini: 0
RX Jumbo: 0
TX: 512
Now modify the ring parameters:
sudo ethtool -L <hns3-dev> combined 4
And noticed that the channel parameters are now back at their defaults:
$ sudo ethtool -g <hns3-dev>
Ring parameters for <hns3-dev>:
Pre-set maximums:
RX: 32768
RX Mini: 0
RX Jumbo: 0
TX: 32768
Current hardware settings:
RX: 1024
RX Mini: 0
RX Jumbo: 0
TX: 1024
[Fix]
commit 128b900de7df567ca7ca063bf5da4ed0f357db8c
Author: Yunsheng Lin <linyunsheng@huawei.com>
Date: Tue Aug 14 17:13:16 2018 +0100
net: hns3: Fix desc num set to default when setting channel
[Regression Risk]
Localized to a single driver, tested on the one SoC that includes this device. |
|
| 2018-09-25 12:39:00 |
Thadeu Lima de Souza Cascardo |
nominated for series |
|
Ubuntu Cosmic |
|
| 2018-09-25 12:39:02 |
Thadeu Lima de Souza Cascardo |
bug task added |
|
linux (Ubuntu Cosmic) |
|
| 2018-09-25 12:39:04 |
Thadeu Lima de Souza Cascardo |
linux (Ubuntu Cosmic): status |
In Progress |
Fix Committed |
|
| 2018-09-27 17:22:23 |
dann frazier |
bug |
|
|
added subscriber Ike Panhc |
| 2018-09-27 17:24:01 |
dann frazier |
bug |
|
|
added subscriber Andrew Cloke |
| 2018-10-02 12:44:40 |
Stefan Bader |
linux (Ubuntu Bionic): status |
In Progress |
Fix Committed |
|
| 2018-10-03 17:33:30 |
Brad Figg |
tags |
|
verification-needed-bionic |
|
| 2018-10-05 04:11:53 |
Ike Panhc |
tags |
verification-needed-bionic |
verification-done-bionic |
|
| 2018-10-12 13:48:54 |
Launchpad Janitor |
linux (Ubuntu Cosmic): status |
Fix Committed |
Fix Released |
|
| 2018-10-12 13:48:54 |
Launchpad Janitor |
cve linked |
|
2018-14633 |
|
| 2018-10-12 13:48:54 |
Launchpad Janitor |
cve linked |
|
2018-5391 |
|
| 2018-10-22 15:58:43 |
Launchpad Janitor |
linux (Ubuntu Bionic): status |
Fix Committed |
Fix Released |
|
