CONFIG_CC_STACKPROTECTOR is now defined on Makefile

[Thadeu Lima de Souza Cascardo]

https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-cosmic-canonical-kernel-team-bootstrap/cosmic/amd64/l/linux/20180524_171024_2701c@/log.gz

15:41:48 ERROR| [stderr] CONFIG_CC_STACKPROTECTOR set ... FAIL

commit 2bc2f688fdf8808de4f36be563ccdb0bde7c0c54
    Makefile: move stack-protector availability out of Kconfig

+ ifndef stackp-broken
+ # If the stack protector is functional, enable code that depends on it.
+ KBUILD_CPPFLAGS += -DCONFIG_CC_STACKPROTECTOR
+ endif

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1776242

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

[Thadeu Lima de Souza Cascardo (cascardo)]

Hi, Steve.

Can you take a look at this? The test needs to be updated to reflect the kconfig changes.

Thanks.
Cascardo.

[Steve Beattie (sbeattie)]

This was not an issue in the kernel; rather the qa-regression-testing script needed to take into account the auto-detection of the compiler's ability to perform stack protection and the restructuring of the config option due to that. I have fixed this in https://git.launchpad.net/qa-regression-testing/commit/?id=69b1392a208985e90857facbe367e3af635c8228 .

Unfortunately, it looks to change a bit again in the 4.18 kernel, but I think I have the checks set up to work properly when that lands as well.