| 2019-02-04 14:33:47 |
Julian Andres Klode |
bug |
|
|
added bug |
| 2019-02-05 12:18:22 |
Launchpad Janitor |
apt (Ubuntu): status |
New |
Fix Released |
|
| 2019-03-01 08:50:08 |
Julian Andres Klode |
description |
[Impact]
json hooks ending with EPIPE on first read fail, but should simply do nothing.This causes spurious failures of uninstalled hooks.
[Test case]
TODO
[Regression potential]
meh |
[Impact]
json hooks ending with EPIPE on first read fail, but should simply do nothing.This causes spurious failures of uninstalled hooks.
[Test case]
Cannot generate one. This was discovered by snapd ci, but I did not find a reproducer yet.
FWIW, the change should be tiny enough to see that it is not wrong:
- if (errno != ECONNRESET)
+ if (errno != ECONNRESET && errno != EPIPE)
_error->Error("Could not read response to hello message from hook %s: %s", Opts->Value.c_str(), strerror(errno));
[Regression potential]
JSON hooks failures with EPIPE are now ignored, so if it fails with EPIPE for other reasons than just exiting, I guess we might miss it |
|
| 2019-03-01 08:56:08 |
Julian Andres Klode |
description |
[Impact]
json hooks ending with EPIPE on first read fail, but should simply do nothing.This causes spurious failures of uninstalled hooks.
[Test case]
Cannot generate one. This was discovered by snapd ci, but I did not find a reproducer yet.
FWIW, the change should be tiny enough to see that it is not wrong:
- if (errno != ECONNRESET)
+ if (errno != ECONNRESET && errno != EPIPE)
_error->Error("Could not read response to hello message from hook %s: %s", Opts->Value.c_str(), strerror(errno));
[Regression potential]
JSON hooks failures with EPIPE are now ignored, so if it fails with EPIPE for other reasons than just exiting, I guess we might miss it |
[Impact]
json hooks ending with EPIPE on first read fail, but should simply do nothing. This causes spurious failures of uninstalled hooks.
Also, there is a missing error exit, causing errors reported by the script to not exit.
[Test case]
For the first part, I cannot generate one. This was discovered by snapd ci, but I did not find a reproducer yet.
FWIW, the change should be tiny enough to see that it is not wrong:
- if (errno != ECONNRESET)
+ if (errno != ECONNRESET && errno != EPIPE)
_error->Error("Could not read response to hello message from hook %s: %s", Opts->Value.c_str(), strerror(errno));
The missing error handling is the next lines:
else if (strstr(line, "error") != nullptr)
{
_error->Error("Hook %s reported an error during hello: %s", Opts->Value.c_str(), line);
+ goto out;
}
that can be checked:
sudo apt -o AptCli::Hooks::Install::="/usr/bin/printf '{error should be json}\n\n' >&3" install
[Regression potential]
JSON hooks failures with EPIPE are now ignored, so if it fails with EPIPE for other reasons than just exiting, I guess we might miss it |
|
| 2019-03-01 08:58:54 |
Julian Andres Klode |
nominated for series |
|
Ubuntu Bionic |
|
| 2019-03-01 08:58:54 |
Julian Andres Klode |
bug task added |
|
apt (Ubuntu Bionic) |
|
| 2019-03-01 08:58:54 |
Julian Andres Klode |
nominated for series |
|
Ubuntu Disco |
|
| 2019-03-01 08:58:54 |
Julian Andres Klode |
bug task added |
|
apt (Ubuntu Disco) |
|
| 2019-03-01 08:58:54 |
Julian Andres Klode |
nominated for series |
|
Ubuntu Cosmic |
|
| 2019-03-01 08:58:54 |
Julian Andres Klode |
bug task added |
|
apt (Ubuntu Cosmic) |
|
| 2019-03-01 12:06:03 |
Julian Andres Klode |
apt (Ubuntu Bionic): status |
New |
In Progress |
|
| 2019-03-01 12:06:08 |
Julian Andres Klode |
apt (Ubuntu Cosmic): status |
New |
In Progress |
|
| 2019-03-05 22:08:21 |
Brian Murray |
apt (Ubuntu Cosmic): status |
In Progress |
Fix Committed |
|
| 2019-03-05 22:08:22 |
Brian Murray |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2019-03-05 22:08:25 |
Brian Murray |
bug |
|
|
added subscriber SRU Verification |
| 2019-03-05 22:08:29 |
Brian Murray |
tags |
|
verification-needed verification-needed-cosmic |
|
| 2019-03-05 22:11:25 |
Brian Murray |
apt (Ubuntu Bionic): status |
In Progress |
Fix Committed |
|
| 2019-03-05 22:11:30 |
Brian Murray |
tags |
verification-needed verification-needed-cosmic |
verification-needed verification-needed-bionic verification-needed-cosmic |
|
| 2019-03-06 14:01:45 |
Julian Andres Klode |
tags |
verification-needed verification-needed-bionic verification-needed-cosmic |
verification-done verification-done-bionic verification-done-cosmic |
|
| 2019-03-14 12:08:56 |
Łukasz Zemczak |
tags |
verification-done verification-done-bionic verification-done-cosmic |
verification-done-bionic verification-needed verification-needed-cosmic |
|
| 2019-03-14 12:12:44 |
Łukasz Zemczak |
tags |
verification-done-bionic verification-needed verification-needed-cosmic |
verification-needed verification-needed-bionic verification-needed-cosmic |
|
| 2019-03-15 10:49:44 |
Julian Andres Klode |
tags |
verification-needed verification-needed-bionic verification-needed-cosmic |
verification-done verification-done-bionic verification-done-cosmic |
|
| 2019-03-21 10:14:03 |
Łukasz Zemczak |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2019-03-21 10:14:15 |
Launchpad Janitor |
apt (Ubuntu Cosmic): status |
Fix Committed |
Fix Released |
|
| 2019-03-21 10:28:38 |
Launchpad Janitor |
apt (Ubuntu Bionic): status |
Fix Committed |
Fix Released |
|
