[SRU] Update vala in bionic to 0.40.8

[Rico Tzschichholz]

The 0.40.x series is maintained as LTS release and will receive further bug fix releases in the future. See https://wiki.gnome.org/Projects/Vala

Upstream changes since 0.40.4:

Vala 0.40.8
===========
 * Various improvements and bug fixes:
  - Fix links in the Manual
  - libvaladoc: Change link to Valadoc wiki page for HTML doclet
  - valadoc: Use HTML5 doctype in HTML doclet
  - codegen: Let methods return -1 on error by default if possible [#526]
  - Allow TypeModule subclasses as parameter-type in module-init-method [#648]
  - girparser: Allow changing the type of constants using metadata [#643]
  - girwriter: Add boolean GIR visible attribute to allow skipping symbols
  - vala: Report error for error-domains without any code
  - parser: Accept "empty" enums/error-domains [#253]
  - codewriter: Output bodies of code-blocks if in VAPIGEN mode [#253]

 * Bindings:
  - gobject-2.0: Add lower_case_csuffix attributes to Type* symbols
  - gdk-3.0,gtk+-3.0: Update to 3.23.0+df045423
  - gio-2.0: Add custom IOError.from_errno() to make it work as expected [#253]
  - gtk+-4.0: Update to 3.94.0+bf5f27c6
  - gstreamer-rtsp-server-1.0: Update from 1.14+ git master [#653]

Vala 0.40.7
===========
 * Various improvements and bug fixes:
  - Update bugtracker links to https://gitlab.gnome.org/GNOME/vala/issues
  - codegen:
    + Handle delegate_target attribute of fields [#520]
    + Free generic elements of glib collections [#694765]
    + Fix warning for source_funcs parameter of g_source_new()
    + Actually treat GLib.Source as compact class
    + Custom abstract methods of GLib.Source are handled differently [#641]
    + Consistently use gpointer for delegate targets
    + Unify some delegate-type check patterns
    + Use default_init instead of base_init when registering interfaces
      [#699550]
  - girparser: Add support for bool delegate_target [#520]
  - girwriter:
    + Output deprecated="1"
    + construct-only properties don't have a setter method
    + Don't write any custom attributes [#608]
  - valadoc: Fix TreeBuilder.create_array() for stacked Arrays

 * Bindings:
  - glib-2.0:
    + Do not mark simple-type out-parameters as nullable [#634]
    + Make Source.attach() use the default MainContext by default
    + Make Bytes.slice() use the memory-efficient Bytes.from_bytes() [#638]
    + Fix Bytes.with_free_func()
  - gio-2.0:
    + Mark ActionEntry.parameter_type/state fields as nullable [#632]
    + Delegate fields of DBus*VTable do not have implicit target fields
    + Apply delegate_target = false on ActionEntry callbacks and make them weak
      [#630]
    + Add default to all io_priority parameters
  - gstreamer: Cherry-pick some fixes from 0.42, add gst-editing-services-1.0
  - gtk+-3.0: Update to 3.22.30+9ac7f906
  - gtk+-4.0: Update to 3.93.0+29fee2e8
  - webkit2gtk-4.0: Update to 2.21.4
  - Update GIR-based bindings

Vala 0.40.6
===========
 * Regression fix:
  - codegen: Avoid critical for array in-parameters with custom length-type
  - tests: Drop assert which is failing on big-endian archs

Vala 0.40.5
===========
 * Various improvements and bug fixes:
  - Warn if --gir is used without --library [#708693]
  - Report an error if rank attribute is required but was not found [#660991]
  - scanner: Accept \R and \N escape sequences in regex literals [#749576]
  - scanner: Accept backreferences \1 through \99 in regex literals [#728574]
  - codegen:
    + Avoid critical in get_basic_type_info() when there is no signature
      [#729517]
    + Fix serializing multidimensional arrays [#735437]
    + Guard get_default_ref_sink_function() against null base-class
    + Respect cname ccode-attribute of lockable fields
    + Fix casting of length for "ref" array parameters
  - codewriter: Add 'new' to symbols if needed to match the original source
    [#614686]
  - girparser: Deal with missing "name" attribute by falling back on "c:type"
  - girwriter: Drop errornous indent
  - girwriter: Properly output variadic methods and use introspectable="0"
  - genie: Add support for the \v escape character [#664689]
  - genie: Add support for the \uXXXX escape sequence

 * Bindings:
  - glib-2.0: Fix IConv.iconv() [#634753]
  - gobject-2.0: Make constructor of ParamSpecBoxed public
  - gstreamer: Cherry-pick some fixes from 0.42
  - gtk+-3.0: Update to 3.22.30+21fddc39
  - gtk+-4.0: Update to 3.93.0+3a860719
  - javascriptcoregtk-4.0: buffer of String.get_utf8_cstring() is not "ref"
    [#788113]
  - posix: Add missing cname = "int" to Posix.Signal enum
  - sqlite3: Add additional constants for flags of Database.open_v2() [#795627]
  - webkit2gtk-4.0: Cherry-pick some fixes from 0.42

[Impact]
 * Affects all valac reverse-dependency on buildtime

[Test Case]
 * Mass-rebuild of rdepends can be found here
   https://launchpad.net/~ricotz/+archive/ubuntu/red/+packages?batch=200&memo=0&start=0
   Occurring failures are not vala compiler related.

[Regression Potential]
 * Not immediately while it requires an rdepend rebuild to manifest.

[Other Info]
 * Regular upstream maintenance releases are likely to happen every 1-2 months

[Rico Tzschichholz (ricotz)]

The release is available in cosmic now https://launchpad.net/ubuntu/+source/vala/0.40.8-1 and a no-change backport to bionic is all what is needed.

[Jeremy Bícha (jbicha)]

I have uploaded this to the bionic proposed queue and am unsubscribing ubuntu-sponsors. It will need to be manually approved by the Stable Release Update team before being built for the official repositories. Thank you!

[Łukasz Zemczak (sil2100)]

Packages like these are really hard to review from the SRU POV, as there is no reliable test-case that can be applied. The mass-rebuild can be one way, but that does not seem like an enough test for such an update.

I will be accepting this but what I would like to see during validation:
 1) In some fresh PPA, perform a no-change rebuild of all vala rdeps (similar to what was done already) with -proposed enabled to build against the actual binaries we will have in the archive.
 2) For those packages that FTBFS in the 1) PPA, create a separate PPA with -proposed *disabled* and no-change rebuild those there. I want to see if they also fail on what we have in bionic currently.
 3) Perform some overall dogfooding of a few vala-built packages against what is in -proposed, trying to see if things didn't get broken by the update. Just seeing packages built seems like not enough of a validation.

[Łukasz Zemczak (sil2100)]

Hello Rico, or anyone else affected,

Accepted vala into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/vala/0.40.8-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Rico Tzschichholz (ricotz)]

Hello Lukasz,

I have created two new PPAs to do clean rebuilds and to confirm the failures (which are not related to vala)

Rebuild of vala rdepends with enabled -proposed:
https://launchpad.net/~ricotz/+archive/ubuntu/bionic-vala-sru/+packages?batch=200&memo=0&start=0

Rebuild to double-check *without* -proposed to confirm the failures:
https://launchpad.net/~ricotz/+archive/ubuntu/bionic-vala-sru-failed/+packages

[Jeremy Bícha (jbicha)]

I am setting the verification-done tags based on the previous comment.

[Łukasz Zemczak (sil2100)]

Ok, very good, thanks! Did you give some of the rebuilt reverse-dependencies a spin, something like: install, launch, see if they don't segfault, maybe (if you know the application) try using it? A few of those should be enough.

[Robie Basak (racb)]

Marking verification-needed pending an answer to Łukasz's question to remove noise from the "green" queue. Please mark verification-done again once ready.

[Rico Tzschichholz (ricotz)]

Hello Lukasz,

I have tested shotwell and simple-scan a bit and they work as expected.

[Launchpad Janitor (janitor)]

This bug was fixed in the package vala - 0.40.8-0ubuntu1

---------------
vala (0.40.8-0ubuntu1) bionic; urgency=medium

  * New upstream release (LP: #1782122)

 -- Rico Tzschichholz <email address hidden> Fri, 27 Jul 2018 17:27:55 +0100

[Chris Halse Rogers (raof)]

The verification of the Stable Release Update for vala has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.