2019-03-22 20:54:25 |
Brian Murray |
bug |
|
|
added bug |
2019-03-22 20:54:25 |
Brian Murray |
attachment added |
|
system-program-problem.png https://bugs.launchpad.net/bugs/1821412/+attachment/5248685/+files/system-program-problem.png |
|
2019-03-22 21:05:01 |
Brian Murray |
update-notifier (Ubuntu): importance |
Undecided |
High |
|
2019-03-28 15:35:35 |
Brian Murray |
tags |
amd64 apport-bug disco rls-dd-incoming |
amd64 apport-bug disco rls-dd-notfixing rls-ee-incoming |
|
2019-03-29 12:24:13 |
Francis Ginther |
tags |
amd64 apport-bug disco rls-dd-notfixing rls-ee-incoming |
amd64 apport-bug disco id-5c9cf7c38b53cd82590a3144 rls-dd-notfixing rls-ee-incoming |
|
2019-04-07 15:25:58 |
Launchpad Janitor |
update-notifier (Ubuntu): status |
New |
Confirmed |
|
2019-05-02 15:17:54 |
Brian Murray |
nominated for series |
|
Ubuntu Eoan |
|
2019-05-02 15:17:54 |
Brian Murray |
bug task added |
|
update-notifier (Ubuntu Eoan) |
|
2019-05-02 15:18:05 |
Brian Murray |
tags |
amd64 apport-bug disco id-5c9cf7c38b53cd82590a3144 rls-dd-notfixing rls-ee-incoming |
amd64 apport-bug disco id-5c9cf7c38b53cd82590a3144 rls-dd-notfixing |
|
2020-07-20 19:40:38 |
Brian Murray |
update-notifier (Ubuntu Eoan): status |
Confirmed |
Won't Fix |
|
2020-10-14 15:48:44 |
Matthieu Clemenceau |
tags |
amd64 apport-bug disco id-5c9cf7c38b53cd82590a3144 rls-dd-notfixing |
amd64 apport-bug disco fr-25 id-5c9cf7c38b53cd82590a3144 rls-dd-notfixing |
|
2020-10-21 20:32:43 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~tdaitx/update-notifier/+git/update-notifier/+merge/392629 |
|
2020-10-21 20:36:11 |
Tiago Stürmer Daitx |
tags |
amd64 apport-bug disco fr-25 id-5c9cf7c38b53cd82590a3144 rls-dd-notfixing |
amd64 apport-bug disco focal fr-25 groovy id-5c9cf7c38b53cd82590a3144 rls-dd-notfixing |
|
2020-11-02 12:57:30 |
Launchpad Janitor |
update-notifier (Ubuntu): status |
Confirmed |
Fix Released |
|
2021-03-23 19:27:50 |
Dan Bungert |
bug |
|
|
added subscriber Dan Bungert |
2021-03-25 19:14:44 |
Brian Murray |
update-notifier (Ubuntu): status |
Fix Released |
Triaged |
|
2021-07-09 23:21:51 |
Dan Bungert |
update-notifier (Ubuntu): assignee |
|
Dan Bungert (dbungert) |
|
2021-07-09 23:21:53 |
Dan Bungert |
update-notifier (Ubuntu): status |
Triaged |
In Progress |
|
2021-07-15 14:48:48 |
Dan Bungert |
merge proposal linked |
|
https://code.launchpad.net/~dbungert/update-notifier/+git/update-notifier/+merge/405628 |
|
2021-07-31 10:21:05 |
Norbert |
tags |
amd64 apport-bug disco focal fr-25 groovy id-5c9cf7c38b53cd82590a3144 rls-dd-notfixing |
amd64 apport-bug focal fr-25 id-5c9cf7c38b53cd82590a3144 |
|
2021-10-21 01:27:23 |
Michael Hudson-Doyle |
nominated for series |
|
Ubuntu Focal |
|
2021-10-21 01:27:23 |
Michael Hudson-Doyle |
bug task added |
|
update-notifier (Ubuntu Focal) |
|
2021-10-21 01:27:23 |
Michael Hudson-Doyle |
nominated for series |
|
Ubuntu Impish |
|
2021-10-21 01:27:23 |
Michael Hudson-Doyle |
bug task added |
|
update-notifier (Ubuntu Impish) |
|
2021-10-21 01:27:23 |
Michael Hudson-Doyle |
nominated for series |
|
Ubuntu Bionic |
|
2021-10-21 01:27:23 |
Michael Hudson-Doyle |
bug task added |
|
update-notifier (Ubuntu Bionic) |
|
2021-10-21 01:27:23 |
Michael Hudson-Doyle |
nominated for series |
|
Ubuntu Hirsute |
|
2021-10-21 01:27:23 |
Michael Hudson-Doyle |
bug task added |
|
update-notifier (Ubuntu Hirsute) |
|
2021-10-21 01:27:35 |
Michael Hudson-Doyle |
bug task deleted |
update-notifier (Ubuntu Eoan) |
|
|
2021-10-21 01:35:27 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~dbungert/update-notifier/+git/update-notifier/+merge/410570 |
|
2021-10-28 22:16:46 |
Dan Bungert |
description |
Test Case
---------
sudo xeyes &
sudo kill -11 $PID from above
receive crash notification
click "Report problem..."
Observe nothing happen
Research
--------
crash.c calls the following '/usr/bin/pkexec /usr/share/apport/apport-gtk' and this works if I call it manually so something must be awry in crash.c.
ProblemType: Bug
DistroRelease: Ubuntu 19.04
Package: update-notifier 3.192.14
ProcVersionSignature: Ubuntu 5.0.0-7.8-generic 5.0.0
Uname: Linux 5.0.0-7-generic x86_64
NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair
ApportVersion: 2.20.10-0ubuntu23
Architecture: amd64
CurrentDesktop: MATE
Date: Fri Mar 22 13:46:38 2019
InstallationDate: Installed on 2018-08-10 (223 days ago)
InstallationMedia: Ubuntu-Server 18.04.1 LTS "Bionic Beaver" - Release amd64 (20180725)
SourcePackage: update-notifier
UpgradeStatus: Upgraded to disco on 2019-02-28 (21 days ago) |
[Impact]
* Users, already annoyed that software has crashed and they have an
unwanted dialog instead, are unable to click the report button to
let us know about the crash.
* Two identical-looking dialogs exist - one on the system-crash
path, and one spawned by the background update-notifier process.
The system crash one is the failing one, the update-notifier one
is fine. The system crash one shows first, and users may not
bother to approve the second one given that the first didn't do
anything
* We receive fewer crash reports
[Test Plan]
* sudo xeyes &
* sudo kill -11 $PID from above
* receive crash notification
* click "Report problem..."
* We should see the report procedure start
[Where problems could occur]
* By the nature of the supplied fix, if the report process hangs
around, the normal systemd cleanup procedures would fail to clean
it up. This same risk is present for report processes initiated
on the non-system-crash report code path.
* Wayland is still affected even with this fix, for different reasons
(LP: #1947929)
[Other Info]
Q: Systemd says KillMode=process is not recommended
https://www.freedesktop.org/software/systemd/man/systemd.kill.html
In this case, killing the other processes in the control-group is part
of the problem.
The system crash dialog is a relatively simple bit of code that shows
a dialog, then runs a report process. This dialog process is spawned
as part of a chain of processes downstream from
update-notifier-crash.service.
This dialog runs the report process using g_spawn_async(). After
spawning the report process, there isn't any particular reason to keep
the dialog process around, so it exits. This exit is triggering the
KillMode behavior, and because the report process is in the control
group, the report process is killed.
Another possibility for addressing the process management is to run
the report process synchronously - keep the dialog process around
until the report is done and just make the dialog not visible. This
is not a workable answer in this case because with the current gtk
code usage, the dialog sticks around - even after the call to
gtk_widget_destroy()! This appears to be due to usage of
gtk_dialog_run(). Long term I recommend we modernize this code.
My initial fix for this LP was in that direction.
https://git.launchpad.net/~dbungert/update-notifier/commit/?id=06058d5705ed7cd636206c1ee72c376ec903fe74 |
|
2021-10-29 00:50:43 |
Matt Robbins |
removed subscriber Matt Robbins |
|
|
|
2021-11-05 03:19:08 |
Launchpad Janitor |
update-notifier (Ubuntu): status |
In Progress |
Fix Released |
|
2021-12-03 00:20:49 |
Brian Murray |
update-notifier (Ubuntu Focal): status |
New |
In Progress |
|
2021-12-03 00:20:51 |
Brian Murray |
update-notifier (Ubuntu Hirsute): status |
New |
In Progress |
|
2021-12-03 00:20:53 |
Brian Murray |
update-notifier (Ubuntu Impish): status |
New |
In Progress |
|
2021-12-03 00:20:55 |
Brian Murray |
update-notifier (Ubuntu Focal): assignee |
|
Brian Murray (brian-murray) |
|
2021-12-03 00:20:57 |
Brian Murray |
update-notifier (Ubuntu Hirsute): assignee |
|
Brian Murray (brian-murray) |
|
2021-12-03 00:21:00 |
Brian Murray |
update-notifier (Ubuntu Impish): assignee |
|
Brian Murray (brian-murray) |
|
2021-12-03 00:21:02 |
Brian Murray |
update-notifier (Ubuntu Focal): importance |
Undecided |
High |
|
2021-12-03 00:21:04 |
Brian Murray |
update-notifier (Ubuntu Hirsute): importance |
Undecided |
High |
|
2021-12-03 00:21:13 |
Brian Murray |
update-notifier (Ubuntu Impish): importance |
Undecided |
High |
|
2021-12-03 01:26:07 |
Brian Murray |
update-notifier (Ubuntu Bionic): status |
New |
Won't Fix |
|
2021-12-07 16:23:11 |
Brian Murray |
update-notifier (Ubuntu Impish): status |
In Progress |
Fix Committed |
|
2021-12-07 16:23:13 |
Brian Murray |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
2021-12-07 16:23:15 |
Brian Murray |
bug |
|
|
added subscriber SRU Verification |
2021-12-07 16:23:18 |
Brian Murray |
tags |
amd64 apport-bug focal fr-25 id-5c9cf7c38b53cd82590a3144 |
amd64 apport-bug focal fr-25 id-5c9cf7c38b53cd82590a3144 verification-needed verification-needed-impish |
|
2021-12-07 16:23:56 |
Brian Murray |
update-notifier (Ubuntu Hirsute): status |
In Progress |
Fix Committed |
|
2021-12-07 16:24:02 |
Brian Murray |
tags |
amd64 apport-bug focal fr-25 id-5c9cf7c38b53cd82590a3144 verification-needed verification-needed-impish |
amd64 apport-bug focal fr-25 id-5c9cf7c38b53cd82590a3144 verification-needed verification-needed-hirsute verification-needed-impish |
|
2021-12-07 16:25:24 |
Brian Murray |
update-notifier (Ubuntu Focal): status |
In Progress |
Fix Committed |
|
2021-12-07 16:25:31 |
Brian Murray |
tags |
amd64 apport-bug focal fr-25 id-5c9cf7c38b53cd82590a3144 verification-needed verification-needed-hirsute verification-needed-impish |
amd64 apport-bug focal fr-25 id-5c9cf7c38b53cd82590a3144 verification-needed verification-needed-focal verification-needed-hirsute verification-needed-impish |
|
2021-12-10 22:59:58 |
Brian Murray |
tags |
amd64 apport-bug focal fr-25 id-5c9cf7c38b53cd82590a3144 verification-needed verification-needed-focal verification-needed-hirsute verification-needed-impish |
amd64 apport-bug focal fr-25 id-5c9cf7c38b53cd82590a3144 verification-done-focal verification-done-hirsute verification-done-impish verification-needed |
|
2021-12-14 19:26:01 |
Launchpad Janitor |
update-notifier (Ubuntu Impish): status |
Fix Committed |
Fix Released |
|
2021-12-14 19:26:07 |
Brian Murray |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
2021-12-14 19:28:07 |
Launchpad Janitor |
update-notifier (Ubuntu Hirsute): status |
Fix Committed |
Fix Released |
|
2021-12-14 19:28:22 |
Launchpad Janitor |
update-notifier (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|