prime-select doesn't work in phase 2

Bug #1789201 reported by Alberto Milone
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HWE Next
Fix Released
Undecided
Unassigned
ubuntu-drivers-common (Ubuntu)
Fix Released
High
Alberto Milone
Bionic
Fix Released
High
Alberto Milone

Bug Description

SRU Request:

[Impact]
We need to be able to disable the discrete GPU in phase 2 of the oem installer*, and this requires running gpu-manager.service before oem-config.service.

[Test Case]
Add the new ubuntu-drivers-common in -proposed repository, and see if gpu-manager.service is called in phase 2.

[Regression Potential]
Low, as no action will be taken unless custom settings for hybrid graphics are available.

*What is "phase 2" (Booting from the recovery partition, and installing Ubuntu):
https://docs.google.com/presentation/d/18q2VtQt3OJzh12--2Llzwz36DlF3Lca6iLPCnhIbQds/edit?usp=sharing

tags: added: originate-from-1773080 somerville
description: updated
Revision history for this message
Brian Murray (brian-murray) wrote :

I guess this is fixed in cosmic.

ubuntu-drivers-common (1:0.5.3) cosmic; urgency=medium

  * gpu-manager.(c|py):
    - Set automatic pci power management when the dGPU is disabled (LP: #1778011).
    - Load the nvidia modules when switching to performance mode.
    - Do not skip unbound devices.
    - Make remove_prime_outputclass() void.
    - Report failures in enable_power_management().
    - Look for blacklisted modules in /lib/modprobe.d too.
    - Report failure when the nvidia modules cannot be unloaded,
      kill the main display session created by gdm3, and try
      unloading the nvidia modules once again.
  * gpu-manager.service:
    - Start before oem-config.service.

 -- Alberto Milone <email address hidden> Thu, 02 Aug 2018 15:45:42 +0200

Changed in ubuntu-drivers-common (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Steve Langasek (vorlon) wrote :

Please update the SRU bug with a test case that anyone can follow without knowing what 'phase 2' is.

Changed in ubuntu-drivers-common (Ubuntu Bionic):
status: New → Incomplete
Revision history for this message
Steve Langasek (vorlon) wrote :

Questions I asked on the other SRU bug that I think it's still worth having answered before we proceed:

Why does oem-config not provide display-manager.service?

Why are there no interdependencies between oem-config's systemd units and display-manager.service?

Revision history for this message
Alberto Milone (albertomilone) wrote :

@Steve: I am not sure as to why oem-config doesn't provide display-manager.service, but I felt it would be much safer to introduce the change in gpu-manager.service, and I didn't want to break anything in any other case where gpu-manager is not required.

description: updated
Changed in ubuntu-drivers-common (Ubuntu Bionic):
assignee: nobody → Alberto Milone (albertomilone)
status: Incomplete → In Progress
importance: Undecided → High
description: updated
Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello Alberto, or anyone else affected,

Accepted ubuntu-drivers-common into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubuntu-drivers-common/1:0.5.2.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in ubuntu-drivers-common (Ubuntu Bionic):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-bionic
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Can we get this verified?

Revision history for this message
ethan.hsieh (ethan.hsieh) wrote :

The issue is gone after installing packages at https://launchpad.net/ubuntu/+source/ubuntu-drivers-common/1:0.5.2.1.

tags: added: verification-done-bionic
removed: verification-needed-bionic
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-drivers-common - 1:0.5.2.1

---------------
ubuntu-drivers-common (1:0.5.2.1) bionic; urgency=medium

  * debian/rules:
    - Make sure to remove "__pycache__" directory.
  * debian/source/options:
    - Ignore the "__pycache__" directory.
  * gpu-manager.(c|py):
    - Set automatic pci power management when the dGPU is disabled (LP: #1778011).
    - Load the nvidia modules when switching to performance mode.
    - Do not skip unbound devices.
    - Make remove_prime_outputclass() void.
    - Report failures in enable_power_management().
    - Look for blacklisted modules in /lib/modprobe.d too.
    - Report failure when the nvidia modules cannot be unloaded,
      kill the main display session created by gdm3, and try
      unloading the nvidia modules once again.
  * gpu-manager.service:
    - Start before oem-config.service (LP: #1789201).

 -- Alberto Milone <email address hidden> Thu, 02 Aug 2018 15:45:42 +0200

Changed in ubuntu-drivers-common (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for ubuntu-drivers-common has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Changed in hwe-next:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.