trace-cmd report buffer overflow detected

[Ioanna Alifieraki]

[IMPACT]

When running trace-cmd report on Bionic it crashes with

*** buffer overflow detected ***: trace-cmd terminated
Aborted (core dumped)

[TEST CASE]

Prepare a simple script to trace e.g. :

#!/usr/bin/python
import socket
s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
s.close()

then

$ sudo trace-cmd record -a -p function_graph -g __fput -g sock_close -g tcp_close python2 ./close.py

$ sudo trace-cmd report

The latter will fail with buffer overflow detected

[WHERE THINGS COULD GO WRONG]

The fixing commit changes the size of a buffer from 20 to 24 in arg_eval() function
to avoid buffer overflow.
Any potential regression would occur in that function.

[OTHER]

Only Bionic is affected, it is fixed in newer releases.

Fix upstream commit 1375d98d8017e371776adbef10122a57ce2100e5

[Ioanna Alifieraki (joalif)]

Debdiff for Bionic

[Ioanna Alifieraki (joalif)]

Debdiff for Bionic

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "lp1955129_bionic.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Heitor Alves de Siqueira (halves)]

@joalif thank you for the debdiff! There are some minor nitpicks about the patch file that I'd like to confirm with you:

- The 'Origin:' tag in your patch file seems to be missing the patch identifier. From the commit id, would it be appropriate to point it towards [0]?
- I've seen you added a line that says "Backported from upstream commit <snip>". If this required changes, please adjust the 'Origin:' tag with a "backport" prefix instead of "upstream" (you could then omit that additional line)

[0] https://git.kernel.org/pub/scm/utils/trace-cmd/trace-cmd.git/commit/?id=1375d98d8017

[Heitor Alves de Siqueira (halves)]

Marking as won't fix, as Bionic is no longer under standard support.