Activity log for bug #1816753

Date Who What changed Old value New value Message
2019-02-20 13:07:28 Søren Boisen bug added bug
2019-03-14 15:35:23 Balint Reczey grub2 (Ubuntu): assignee Balint Reczey (rbalint)
2019-03-14 15:35:28 Balint Reczey affects grub2 (Ubuntu) systemd (Ubuntu)
2019-03-14 15:35:28 Balint Reczey systemd (Ubuntu): assignee Balint Reczey (rbalint)
2019-03-14 17:41:56 Dimitri John Ledkov nominated for series Ubuntu Xenial
2019-03-14 17:41:56 Dimitri John Ledkov bug task added systemd (Ubuntu Xenial)
2019-03-14 17:41:56 Dimitri John Ledkov nominated for series Ubuntu Cosmic
2019-03-14 17:41:56 Dimitri John Ledkov bug task added systemd (Ubuntu Cosmic)
2019-03-14 17:41:56 Dimitri John Ledkov nominated for series Ubuntu Disco
2019-03-14 17:41:56 Dimitri John Ledkov bug task added systemd (Ubuntu Disco)
2019-03-14 17:41:56 Dimitri John Ledkov nominated for series Ubuntu Bionic
2019-03-14 17:41:56 Dimitri John Ledkov bug task added systemd (Ubuntu Bionic)
2019-03-14 21:20:17 Balint Reczey attachment added 0001-disco-virt-detect-WSL-environment-as-a-container.patch https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1816753/+attachment/5246262/+files/0001-disco-virt-detect-WSL-environment-as-a-container.patch
2019-03-14 21:23:42 Balint Reczey attachment added 0001-cosmic-virt-detect-WSL-environment-as-a-container.patch https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1816753/+attachment/5246263/+files/0001-cosmic-virt-detect-WSL-environment-as-a-container.patch
2019-03-14 21:24:18 Balint Reczey attachment added 0001-bionic-virt-detect-WSL-environment-as-a-container.patch https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1816753/+attachment/5246264/+files/0001-bionic-virt-detect-WSL-environment-as-a-container.patch
2019-03-14 22:35:05 Balint Reczey attachment added 0001-xenial-virt-detect-WSL-environment-as-a-container.patch https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1816753/+attachment/5246289/+files/0001-xenial-virt-detect-WSL-environment-as-a-container.patch
2019-03-14 22:58:17 Balint Reczey description Upon reading an Ubuntu page that said it was possible to upgrade my Ubuntu-under-Windows 10 install (WSL) from 16.04 LTS just by running do-release-upgrade, I excitedly went to my terminal and ran the command. First it refused to run because system was not fully updated. Fine, I ran: sudo apt update sudo apt dist-upgrade This process completed without any errors. I then ran do-release-upgrade again. This time it started okay and got through most of the process. But then at some point it decided to run grub even though I am running Ubuntu under WSL, so presumably grub should not be used. It did apparently detect that it wasn't needed, because it asked me if I was sure I didn't want to install it on the boot device. I answered yes. Then the install proceeded to LXD but soon after came an error related to grub. After that it went downhill fast with at least 2 other errors. Additionally, when the system attempted to roll back the upgrade I got an error from a kernel package. ProblemType: Package DistroRelease: Ubuntu 18.04 Package: friendly-recovery 0.2.38ubuntu1 ProcVersionSignature: Microsoft 4.4.0-17763.253-Microsoft 4.4.35 Uname: Linux 4.4.0-17763-Microsoft x86_64 ApportVersion: 2.20.9-0ubuntu7.5 Architecture: amd64 Date: Tue Feb 19 23:50:44 2019 Dmesg: [ 0.017808] Microsoft 4.4.0-17763.253-Microsoft 4.4.35 ErrorMessage: installed friendly-recovery package post-installation script subprocess returned error exit status 1 PackageArchitecture: all Python3Details: /usr/bin/python3.6, Python 3.6.7, python3-minimal, 3.6.7-1~18.04 PythonDetails: /usr/bin/python2.7, Python 2.7.15rc1, python-minimal, 2.7.15~rc1-1 RelatedPackageVersions: dpkg 1.19.0.5ubuntu2.1 apt 1.6.8 SourcePackage: grub2 Title: package friendly-recovery 0.2.38ubuntu1 failed to install/upgrade: installed friendly-recovery package post-installation script subprocess returned error exit status 1 UpgradeStatus: Upgraded to bionic on 2019-02-20 (0 days ago) [Impact] * Package maintainer scripts and services use systemd-detect-virt and systemd's virtualization detection to determine the environment they are ran in and based on that skip not applicable operations, such as installing grub info to the MBR or to the EFI partition in a container. The WSL environment is similar to containers in that boot loader and initramfs preparations are not useful, but without this change only ad-hoc tests could be implemented in each separate package to avoid obsolete actions or failing in trying not applicable operations. * The fix detects WSL as a container type, called wsl in systemd and as a result make packages behave like they would in classic Linuxcontainers. [Test Case] * Install the fixed systemd package in WSL and observe that it is detected as a container: $ systemd-detect-virt --container wsl $ * Install the fixed systemd package in LXC and observe that it is still detected correctly: $ systemd-detect-virt --container lxc $ * Install the fixed systemd package in a VM or on a bare metal systemd and observe that it is still detected correctly: $ systemd-detect-virt --container none $ echo $? 1 * Observe the man page of sytemd-detect-virt mentioning wsl. [Regression Potential] * The changes is virtualization detection could break the detection logic but the test cases here cover most of the relevant code paths and the detection logic is also exercised in autopkgtests thus causing a regression is unlikely. * The changes to the man pages could break the formatting, but a simple observation mitigates that risk, too. [Original Bug Text] Upon reading an Ubuntu page that said it was possible to upgrade my Ubuntu-under-Windows 10 install (WSL) from 16.04 LTS just by running do-release-upgrade, I excitedly went to my terminal and ran the command. First it refused to run because system was not fully updated. Fine, I ran: sudo apt update sudo apt dist-upgrade This process completed without any errors. I then ran do-release-upgrade again. This time it started okay and got through most of the process. But then at some point it decided to run grub even though I am running Ubuntu under WSL, so presumably grub should not be used. It did apparently detect that it wasn't needed, because it asked me if I was sure I didn't want to install it on the boot device. I answered yes. Then the install proceeded to LXD but soon after came an error related to grub. After that it went downhill fast with at least 2 other errors. Additionally, when the system attempted to roll back the upgrade I got an error from a kernel package. ProblemType: Package DistroRelease: Ubuntu 18.04 Package: friendly-recovery 0.2.38ubuntu1 ProcVersionSignature: Microsoft 4.4.0-17763.253-Microsoft 4.4.35 Uname: Linux 4.4.0-17763-Microsoft x86_64 ApportVersion: 2.20.9-0ubuntu7.5 Architecture: amd64 Date: Tue Feb 19 23:50:44 2019 Dmesg: [ 0.017808] Microsoft 4.4.0-17763.253-Microsoft 4.4.35 ErrorMessage: installed friendly-recovery package post-installation script subprocess returned error exit status 1 PackageArchitecture: all Python3Details: /usr/bin/python3.6, Python 3.6.7, python3-minimal, 3.6.7-1~18.04 PythonDetails: /usr/bin/python2.7, Python 2.7.15rc1, python-minimal, 2.7.15~rc1-1 RelatedPackageVersions:  dpkg 1.19.0.5ubuntu2.1  apt 1.6.8 SourcePackage: grub2 Title: package friendly-recovery 0.2.38ubuntu1 failed to install/upgrade: installed friendly-recovery package post-installation script subprocess returned error exit status 1 UpgradeStatus: Upgraded to bionic on 2019-02-20 (0 days ago)
2019-03-14 23:11:03 Balint Reczey systemd (Ubuntu Disco): status New In Progress
2019-03-14 23:11:13 Balint Reczey systemd (Ubuntu Cosmic): status New In Progress
2019-03-14 23:11:15 Balint Reczey systemd (Ubuntu Bionic): status New In Progress
2019-03-14 23:11:19 Balint Reczey systemd (Ubuntu Xenial): status New In Progress
2019-03-15 00:21:14 Ubuntu Foundations Team Bug Bot tags amd64 apport-package bionic uec-images amd64 apport-package bionic patch uec-images
2019-03-25 12:23:16 Launchpad Janitor systemd (Ubuntu Disco): status In Progress Fix Released
2019-03-25 16:19:08 Łukasz Zemczak systemd (Ubuntu Cosmic): status In Progress Fix Committed
2019-03-25 16:19:11 Łukasz Zemczak bug added subscriber Ubuntu Stable Release Updates Team
2019-03-25 16:19:12 Łukasz Zemczak bug added subscriber SRU Verification
2019-03-25 16:19:15 Łukasz Zemczak tags amd64 apport-package bionic patch uec-images amd64 apport-package bionic patch uec-images verification-needed verification-needed-cosmic
2019-03-25 16:46:33 Łukasz Zemczak systemd (Ubuntu Bionic): status In Progress Fix Committed
2019-03-25 16:46:37 Łukasz Zemczak tags amd64 apport-package bionic patch uec-images verification-needed verification-needed-cosmic amd64 apport-package bionic patch uec-images verification-needed verification-needed-bionic verification-needed-cosmic
2019-03-25 16:52:49 Łukasz Zemczak systemd (Ubuntu Xenial): status In Progress Fix Committed
2019-03-25 16:52:56 Łukasz Zemczak tags amd64 apport-package bionic patch uec-images verification-needed verification-needed-bionic verification-needed-cosmic amd64 apport-package bionic patch uec-images verification-needed verification-needed-bionic verification-needed-cosmic verification-needed-xenial
2019-03-27 17:12:36 Balint Reczey tags amd64 apport-package bionic patch uec-images verification-needed verification-needed-bionic verification-needed-cosmic verification-needed-xenial amd64 apport-package bionic patch uec-images verification-done-bionic verification-needed verification-needed-cosmic verification-needed-xenial
2019-03-27 17:38:56 Balint Reczey tags amd64 apport-package bionic patch uec-images verification-done-bionic verification-needed verification-needed-cosmic verification-needed-xenial amd64 apport-package bionic patch uec-images verification-done-bionic verification-done-xenial verification-needed verification-needed-cosmic
2019-03-27 19:33:17 Balint Reczey tags amd64 apport-package bionic patch uec-images verification-done-bionic verification-done-xenial verification-needed verification-needed-cosmic amd64 apport-package bionic patch uec-images verification-done verification-done-bionic verification-done-cosmic verification-done-xenial
2019-04-04 15:59:56 Launchpad Janitor systemd (Ubuntu Cosmic): status Fix Committed Fix Released
2019-04-04 16:00:07 Łukasz Zemczak removed subscriber Ubuntu Stable Release Updates Team
2019-04-04 16:00:41 Launchpad Janitor systemd (Ubuntu Xenial): status Fix Committed Fix Released
2019-04-04 16:10:38 Launchpad Janitor systemd (Ubuntu Bionic): status Fix Committed Fix Released
2019-04-07 01:26:54 Launchpad Janitor merge proposal linked https://code.launchpad.net/~ddstreet/ubuntu/+source/systemd/+git/systemd/+merge/365627
2019-05-08 15:00:14 Launchpad Janitor merge proposal linked https://code.launchpad.net/~joalif/ubuntu/+source/systemd/+git/systemd/+merge/367121