LVM: fix missing dash

Bug #1839366 reported by Chris Johnston
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
resource-agents (Ubuntu)
Fix Released
Undecided
Unassigned
Xenial
Invalid
Medium
Unassigned
Bionic
Fix Released
Medium
Eric Desrochers

Bug Description

[Impact]
lvm-tag.sh line 150 is missing a dash in front of 'aly' flags. This is causing lvm resource to fail during start.

heartbeat/lvm-tag.sh
vgchange_activate_options="aly --config activation{volume_list=[\"@${OUR_TAG}\"]}"

is missing a - in front of aly. The - can be seen in the deactivate line:

vgchange_deactivate_options="-aln"

Upstream fix:

https://github.com/ClusterLabs/resource-agents/pull/1190/files

Version: 1:4.1.0~rc1-1ubuntu1.1

[Test Case]

It's the ocf:heartbeat:LVM resource that fails here (because the flags it passes to vgchange to activate the VG are incorrect). It manages an Linux Volume Manager volume (LVM) as an HA resource.

[Potential Regression]

I don't expect regression, the missing "-" need to be there to properly perform the activation. Once the activation will work using the "-", it's not impossible that one finds other corner situation due to the fact that the activation now working, but IMHO they'll be consider bugs, not regression to this SRU.

[Other Infos]

* Redhat Bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1612828

* Upstream fix:
https://github.com/ClusterLabs/resource-agents/commit/5a664525a20d3d5094912322be4faac668e4920e

$ git describe --contains 5a664525a20d3d5094912322be4faac668e4920e
v4.2.0rc1~42^2

$ rmadison resource-agents
 resource-agents | 1:3.9.7-1ubuntu1.1 | xenial-updates # lvm-tag.sh doesn't exist yet.
 => resource-agents | 1:4.1.0~rc1-1ubuntu1.1 | bionic-updates
 resource-agents | 1:4.2.0-1ubuntu1.1 | disco-updates
 resource-agents | 1:4.2.0-1ubuntu2 | eoan

Eric Desrochers (slashd)
tags: added: sts
description: updated
Changed in resource-agents (Ubuntu):
status: New → Fix Released
Changed in resource-agents (Ubuntu Bionic):
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Eric Desrochers (slashd)
Changed in resource-agents (Ubuntu Xenial):
assignee: nobody → Eric Desrochers (slashd)
importance: Undecided → Medium
Eric Desrochers (slashd)
Changed in resource-agents (Ubuntu Xenial):
status: New → In Progress
description: updated
Eric Desrochers (slashd)
description: updated
description: updated
Eric Desrochers (slashd)
description: updated
Eric Desrochers (slashd)
Changed in resource-agents (Ubuntu Xenial):
status: In Progress → Invalid
description: updated
Revision history for this message
Eric Desrochers (slashd) wrote :

lvm-tag.sh doesn't exist in Xenial, and I couldn't find any equivalent missing dash in Xenial.

The only place I found similar pattern is inside "heartbeat/LVM" and everything looks good to me at first glance.

#heartbeat/LVM
get_activate_options()
{
        local options="-a"

        case $(get_vg_mode) in
        0) options="${options}ly";;
        1) options="${options}y --config activation{volume_list=[\"@${OUR_TAG}\"]}";;
        2) options="${options}ey";;
        esac

Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Chris, or anyone else affected,

Accepted resource-agents into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/resource-agents/1:4.1.0~rc1-1ubuntu1.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in resource-agents (Ubuntu Bionic):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-bionic
Eric Desrochers (slashd)
Changed in resource-agents (Ubuntu Xenial):
assignee: Eric Desrochers (slashd) → nobody
Revision history for this message
Eric Desrochers (slashd) wrote :

[BIONIC VERIFICATION DONE]

It has been brought to my attention the following by an impacted user:

"
Thanks for getting a fix prepared so quickly.

I appreciate that you have to follow your SRU process; I'm happy to use the resource-agent package in the proposed repo in the meantime.

Our testing of the resource-agents package has been going well -- the original issue is fixed and we've not seen any newly introduced problems.

Cheers,
"

tags: added: verification-done-bionic
removed: verification-needed-bionic
Revision history for this message
Eric Desrochers (slashd) wrote :

[Regression pending sru page]

Regression in autopkgtest for resource-agents (armhf): test log

It produces a code 14 for quite some time now, look at the history :
http://autopkgtest.ubuntu.com/packages/r/resource-agents/bionic/armhf

It has nothing to do with the current SRU.

- Eric

Revision history for this message
Eric Desrochers (slashd) wrote :

With regard to code 14 on comment #4

https://manpages.debian.org/testing/autopkgtest/autopkgtest.1.en.html

EXIT STATUS
......
14 erroneous package and at least one test skipped
......

Revision history for this message
Eric Desrochers (slashd) wrote :

so this can be safely skip, especially that its a recurrent pattern for every resource-agents SRU.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package resource-agents - 1:4.1.0~rc1-1ubuntu1.2

---------------
resource-agents (1:4.1.0~rc1-1ubuntu1.2) bionic; urgency=medium

  * d/p/lvm-fix-missing-dash.patch:
    - Missing dash in vgchange_activate_options affecting
    ocf:heartbeat:LVM. (LP: #1839366)

 -- Eric Desrochers <email address hidden> Thu, 08 Aug 2019 13:42:06 +0000

Changed in resource-agents (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for resource-agents has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.