Properly let PCM leave suspended state when hardware doesn't support PCM resume
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
HWE Next |
Fix Released
|
Undecided
|
Unassigned | ||
pulseaudio (Ubuntu) |
Fix Released
|
Medium
|
Kai-Heng Feng | ||
Bionic |
Won't Fix
|
High
|
Unassigned |
Bug Description
[Impact]
Headset Mic plugged into Dell WD19TB dock stops working after suspend/resume.
[Fix]
According to alia-lib's document, to make PCM properly leave suspended state, we only use snd_pcm_resume() if hardware support PCM resume.
For hardware that doesn't support PCM resume, like snd-usb-audio on WD19TB dock, we should use snd_pcm_prepare(), snd_pcm_drop() or snd_pcm_drain() to make device leave suspended state. This patch defaults to use snd_pcm_drop() to achieve the goal.
[Test]
1. See if microphone on snd-usb-audio works in gnome-control-
2. Suspend/resume.
3. See if microphone still works in those apps.
I can the issue is fixed after each suspend/resume cycle.
[Regression Potential]
Low. This fix makes PCM suspend/resume more reliable. No functional change intended. I also don't find any regression during some smoke test.
description: | updated |
Changed in pulseaudio (Ubuntu): | |
importance: | Undecided → Medium |
tags: | added: rls-bb-incoming |
Changed in pulseaudio (Ubuntu): | |
status: | New → In Progress |
assignee: | nobody → Kai-Heng Feng (kaihengfeng) |
Changed in pulseaudio (Ubuntu Bionic): | |
assignee: | Kai-Heng Feng (kaihengfeng) → nobody |
Changed in pulseaudio (Ubuntu Bionic): | |
status: | In Progress → Won't Fix |
Changed in hwe-next: | |
status: | New → Fix Released |
The attachment "pulseaudio_ 11.1-1ubuntu7. 6.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.
[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]