openafs 1.8.0~pre5-1ubuntu1 fails to build on 5.0 kernels

[Connor Kuehl]

[Impact]

* The openafs DKMS module fails to build on 5.0 kernels due to changes in the kernel API between 4.15 and 5.0. This affects the Bionic HWE{-edge} kernels which are based on 5.0.

[Test Case]

* Install the `openafs` dkms modules package (sudo apt install openafs-modules-dkms)

Expected result: the package installs without any build-time errors, and the module is listed when `sudo dkms status` is ran.

Actual result: the package installation fails because the openafs dkms module fails to build with compilation errors

[Testing]

These instructions were carried out in an amd64 Bionic virtual machine with the 4.15 Bionic kernel and the 5.0 Bionic HWE kernel.

* Install the 5.0 kernel (sudo apt update; sudo apt install linux-image-generic-hwe-18.04)
* Install `openafs-modules-dkms` from -proposed
* Confirm the package installs correctly on 4.15 and 5.0 kernels (it should install for both). Run "sudo dkms status" and ensure it's listed there.

If it doesn't install for both kernels, you can prompt it to install for a specific kernel like this: "sudo dkms install openafs/1.8.0pre5 -k 4.15.0-55-generic/x86_64

[Regression Potential]

Low. These changes use preprocessor define macros that are deduced at configuration time to tell the package to act "normal" if a given feature exists or doesn't exist.

[Achim Bohnet (allee)]

5.0 is also already the HWE kernel in bionic:

# apt show linux-image-generic-hwe-18.04 | head -2
...
Package: linux-image-generic-hwe-18.04
Version: 5.0.0.23.80

Using the 1.8.3 kernel in the openafs PPA, added a few days ago,
works with the 5.0 kernel.

[Connor Kuehl (connork)]

Attaching .debdiff to this comment for SRU consideration into Bionic. Updating bug description with SRU justification.

[Tyler Hicks (tyhicks)]

Connor and I are iterating on the upload outside of this bug. I'm going to mark the Bionic status and Incomplete so that nobody else comes along and sponsors the old debdiff that was previously attached.

[Tyler Hicks (tyhicks)]

I've sponsored an upload from Connor to Bionic. Thanks, Connor!

[Brian Murray (brian-murray)]

Hello Connor, or anyone else affected,

Accepted openafs into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/openafs/1.8.0~pre5-1ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Connor Kuehl (connork)]

The package in -proposed builds and installs correctly on Bionic 4.15 and 5.0 kernels:

ubuntu@amd64-bionic:~$ sudo dkms status
openafs, 1.8.0pre5, 4.15.0-64-generic, x86_64: installed
openafs, 1.8.0pre5, 5.0.0-29-generic, x86_64: installed

[Launchpad Janitor (janitor)]

This bug was fixed in the package openafs - 1.8.0~pre5-1ubuntu1.1

---------------
openafs (1.8.0~pre5-1ubuntu1.1) bionic; urgency=medium

  * Fix build for Linux 5.0 (LP: #1839890)

 -- Connor Kuehl <email address hidden> Mon, 23 Sep 2019 08:49:23 -0700

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for openafs has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.