From 0e0c307fed8adf6c1d056d585a2c78e3122986f3 Mon Sep 17 00:00:00 2001 From: Pridhiviraj Paidipeddi Date: Fri, 2 Mar 2018 10:39:56 +0530 Subject: [PATCH 1/3] lsmcode: Fix failure of displaying all device possible micro code If OPAL firmware failed to provide below product version string printSystem currently returns false in case of all(--All). Due to which printVPD just returns instead of continue to provide microcode levels of other leaf devices. open-power "SUPERMICRO-P9DSU-V1.03-20180205-imp" This patch fixes this issue by not checking the return code of printSystem in case of all option, so it displays microcode levels of as much devices as possible(--all). Signed-off-by: Pridhiviraj Paidipeddi Signed-off-by: Vasant Hegde --- src/output/lsmcode.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/output/lsmcode.cpp b/src/output/lsmcode.cpp index 01acee0..64ae59d 100644 --- a/src/output/lsmcode.cpp +++ b/src/output/lsmcode.cpp @@ -531,8 +531,7 @@ void printVPD( System* root ) } if( device == "" ) { - if (printSystem( root->getLeaves( ) ) != true) - return; + printSystem( root->getLeaves( ) ); } if( !all && device == "" ) -- 2.14.3