Generate HyperV Image Gallery Builds in Bionic and Disco
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
livecd-rootfs (Ubuntu) |
Fix Released
|
High
|
Unassigned | ||
Bionic |
Fix Released
|
High
|
Unassigned | ||
Disco |
Fix Released
|
High
|
Unassigned |
Bug Description
[Overview]
We can generate HyperV Image Gallery builds for Eoan images with livecd-rootfs, but not for Bionic and Disco. These images are necessary for users to install Ubuntu on their Windows machines from the HyperV Image Gallery:
https:/
To support this, three commits need to be backported from ubuntu/master to ubuntu/disco and ubuntu/bionic:
https:/
https:/
https:/
[Test Case]
These images can be built with the livecd-roottfs ubuntu/master branch by specifying the ubuntu project and the desktop-
For example (using the ubuntu-bartender helper script in ubuntu-
ubuntu-
When backported, it's expected that these images can be built for both disco and bionic with the same parameters specified:
ubuntu-
ubuntu-
1: https:/
[Regression Potential]
The binary hook used to create the HyperV image is isolated and shouldn't affect other image builds; however, that hook depends on a symbolic link to a hook in the ubuntu-cpc project. There's a possibility of future breakage if the ubuntu-cpc project hook is modified without taking into account its use in multiple places.
To enable the use of a symbolic link, some logic was changed in the live-build configuration script. Previously, all files were copied over as-is. Now, symbolic links in hook directories are dereferenced and turned into regular files. In practice, this should only have an affect on two files, and that affect should be safe:
livecd-rootfs $ find . -type l -print | grep hooks
./live-
./live-
This may cause undesired behavior for other users of livecd-rootfs, though, that inject symbolic links into their hooks directory.
Related branches
- Łukasz Zemczak: Approve
-
Diff: 285 lines (+184/-10) (has conflicts)8 files modifieddebian/changelog (+8/-0)
live-build/auto/build (+2/-2)
live-build/auto/config (+23/-4)
live-build/functions (+2/-2)
live-build/ubuntu-cpc/hooks.d/base/disk-image-uefi.binary (+11/-2)
live-build/ubuntu/hooks/033-disk-image-uefi.binary (+1/-0)
live-build/ubuntu/hooks/040-hyperv-desktop-images.binary (+128/-0)
live-build/ubuntu/includes.chroot/etc/hosts (+9/-0)
- Łukasz Zemczak: Approve
-
Diff: 276 lines (+182/-10)8 files modifieddebian/changelog (+6/-0)
live-build/auto/build (+2/-2)
live-build/auto/config (+23/-4)
live-build/functions (+2/-2)
live-build/ubuntu-cpc/hooks.d/base/disk-image-uefi.binary (+11/-2)
live-build/ubuntu/hooks/033-disk-image-uefi.binary (+1/-0)
live-build/ubuntu/hooks/040-hyperv-desktop-images.binary (+128/-0)
live-build/ubuntu/includes.chroot/etc/hosts (+9/-0)
tags: | added: id-5d2c8bb9ad70f8685502434c |
Changed in livecd-rootfs (Ubuntu): | |
importance: | Undecided → High |
Changed in livecd-rootfs (Ubuntu Bionic): | |
importance: | Undecided → High |
Changed in livecd-rootfs (Ubuntu Disco): | |
importance: | Undecided → High |
Changed in livecd-rootfs (Ubuntu): | |
status: | New → Fix Released |
tags: | added: id-5d8a793e03625a062527c720 |
Proposed Changes:
Disco: https:/ /code.launchpad .net/~davidkrau ser/livecd- rootfs/ +git/livecd- rootfs/ +merge/ 370330 /code.launchpad .net/~davidkrau ser/livecd- rootfs/ +git/livecd- rootfs/ +merge/ 370331
Bionic: https:/