HID_ASUS should depend on USB_HID in stable v4.15 backports
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
linux (Ubuntu) |
Invalid
|
Undecided
|
Unassigned | ||
Bionic |
Fix Released
|
Medium
|
Krzysztof Kozlowski | ||
Focal |
Fix Released
|
Medium
|
Krzysztof Kozlowski |
Bug Description
[Impact]
Backported to bionic/linux commit f83baa0cb6cf ("HID: add hid_is_usb() function to make it simpler for USB detection") brings to HID_ASUS usage of hid_is_usb() which is provided by USB_HID. If HID_ASUS is built as module but USB_HID is not, the kernel build will fail (like linux-azure) did:
ERROR: "usb_hid_driver" [drivers/
[Fix]
Because of backport of commit commit f83baa0cb6cf ("HID: add hid_is_usb() function to make it simpler for USB detection"), the bionic/linux needs also backport of commit c4f0126d487f ("HID: asus: Add depends on USB_HID to HID_ASUS Kconfig option").
[Test Plan]
Build HID_ASUS as module with or without USB_HID.
[Where problems could occur]
It's a new KConfig dependency, so configs using HID_ASUS without USB_HID will loose HID_ASUS. This is expected, so no problems should occur.
tags: | added: bionic |
description: | updated |
Changed in linux (Ubuntu Bionic): | |
importance: | Undecided → Medium |
status: | New → In Progress |
Changed in linux (Ubuntu): | |
status: | New → Invalid |
Changed in linux (Ubuntu Bionic): | |
assignee: | nobody → Krzysztof Kozlowski (krzk) |
Changed in linux (Ubuntu Focal): | |
status: | New → In Progress |
assignee: | nobody → Krzysztof Kozlowski (krzk) |
importance: | Undecided → Medium |
That came via "Focal update: v5.4.170 upstream stable release" (bug 1958898). I added this report to the bug references.