rtnetlink.sh in net from ubuntu_kernel_selftests is returning 1 for a skipped test
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-kernel-tests |
Fix Released
|
Undecided
|
Po-Hsu Lin | ||
linux (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bionic |
Fix Released
|
Undecided
|
Po-Hsu Lin |
Bug Description
== SRU Justification ==
The rtnetlink.sh in kselftest/net from 4.15 kernel will fail with:
selftests: rtnetlink.sh
======
PASS: policy routing
PASS: route get
PASS: preferred_lft addresses have expired
PASS: tc htb hierarchy
PASS: gre tunnel endpoint
PASS: bridge setup
PASS: ipv6 addrlabel
PASS: set ifalias e1dfde61-
PASS: vrf
PASS: vxlan
SKIP: fou: iproute2 too old
SKIP: macsec: iproute2 too old
not ok 1..10 selftests: rtnetlink.sh [FAIL]
The return value for this script is 1.
Look into the code, it's the kci_test_
this issue:
ip fou help 2>&1 |grep -q 'Usage: ip fou'
if [ $? -ne 0 ];then
echo "SKIP: fou: iproute2 too old"
return 1
fi
It should at least return ksft_skip=4 (or 0 with older release that
does not support this skip code in kselftest framework)
== Fix ==
* 57aefc7c226d ("selftests: net: return Kselftest Skip code for
skipped tests")
This patch needs to be backported into Bionic, as some newer tests
does not exist in Bionic.
== Test ==
Tested directly on the affected kernel, the test will be marked as:
not ok 1..10 selftests: rtnetlink.sh [SKIP]
== Regression Potential ==
Low, changes limited to test scripts. And the kselftest framework in
Bionic can handle this ksft_skip=4 return code properly, tests won't
be marked as failed because of this.
Although IMO in this case the test should be marked as PASS instead of
SKIP in the end, as not all tests were skipped, but that's something
we could fix with upstream in the future.
CVE References
Changed in linux (Ubuntu Bionic): | |
status: | New → In Progress |
assignee: | nobody → Po-Hsu Lin (cypressyew) |
Changed in linux (Ubuntu): | |
status: | New → Fix Released |
Changed in ubuntu-kernel-tests: | |
status: | New → In Progress |
assignee: | nobody → Po-Hsu Lin (cypressyew) |
tags: | added: 4.15 bionic kqa-blocker sru-20200831 ubuntu-kernel-selftests |
description: | updated |
description: | updated |
description: | updated |
Changed in linux (Ubuntu Bionic): | |
status: | In Progress → Fix Committed |
This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification- needed- bionic' to 'verification- done-bionic' . If the problem still exists, change the tag 'verification- needed- bionic' to 'verification- failed- bionic' .
If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.
See https:/ /wiki.ubuntu. com/Testing/ EnableProposed for documentation how to enable and use -proposed. Thank you!