2019-05-27 06:53:10 |
Ike Panhc |
bug |
|
|
added bug |
2019-05-27 06:53:27 |
Ike Panhc |
nominated for series |
|
Ubuntu Bionic |
|
2019-05-27 06:53:27 |
Ike Panhc |
bug task added |
|
linux (Ubuntu Bionic) |
|
2019-05-27 06:53:27 |
Ike Panhc |
nominated for series |
|
Ubuntu Eoan |
|
2019-05-27 06:53:27 |
Ike Panhc |
bug task added |
|
linux (Ubuntu Eoan) |
|
2019-05-27 06:53:27 |
Ike Panhc |
nominated for series |
|
Ubuntu Cosmic |
|
2019-05-27 06:53:27 |
Ike Panhc |
bug task added |
|
linux (Ubuntu Cosmic) |
|
2019-05-27 06:53:27 |
Ike Panhc |
nominated for series |
|
Ubuntu Disco |
|
2019-05-27 06:53:27 |
Ike Panhc |
bug task added |
|
linux (Ubuntu Disco) |
|
2019-05-27 06:53:36 |
Ike Panhc |
linux (Ubuntu Eoan): assignee |
|
Ike Panhc (ikepanhc) |
|
2019-05-27 06:53:38 |
Ike Panhc |
linux (Ubuntu Disco): assignee |
|
Ike Panhc (ikepanhc) |
|
2019-05-27 06:53:40 |
Ike Panhc |
linux (Ubuntu Cosmic): assignee |
|
Ike Panhc (ikepanhc) |
|
2019-05-27 06:53:41 |
Ike Panhc |
linux (Ubuntu Bionic): assignee |
|
Ike Panhc (ikepanhc) |
|
2019-05-27 07:00:11 |
Ubuntu Kernel Bot |
linux (Ubuntu): status |
New |
Incomplete |
|
2019-05-27 07:00:13 |
Ubuntu Kernel Bot |
linux (Ubuntu Bionic): status |
New |
Incomplete |
|
2019-05-27 07:00:14 |
Ubuntu Kernel Bot |
linux (Ubuntu Cosmic): status |
New |
Incomplete |
|
2019-05-27 07:00:15 |
Ubuntu Kernel Bot |
linux (Ubuntu Disco): status |
New |
Incomplete |
|
2019-05-27 12:40:03 |
Ike Panhc |
description |
We have a warning[1] in dmesg shows hns register napi as weight 256 but not recommended. According to this commit[2] we shall use weight 64 as suggested.
To cherry-pick this makes hns driver has reasonable weight
commit acb1ce15a61154aa501891d67ebf79bc9ea26818
Author: Yonglong Liu <liuyonglong@huawei.com>
Date: Thu Apr 4 16:46:43 2019 +0800
net: hns: Use NAPI_POLL_WEIGHT for hns driver
When the HNS driver loaded, always have an error print:
"netif_napi_add() called with weight 256"
This is because the kernel checks the NAPI polling weights
requested by drivers and it prints an error message if a driver
requests a weight bigger than 64.
So use NAPI_POLL_WEIGHT to fix it.
Signed-off-by: Yonglong Liu <liuyonglong@huawei.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
[1] netif_napi_add() called with weight 256
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=82dc3c63c692b1e1d59378ecee948ac88e034aad |
[Impact]
We have a warning[1] in dmesg shows hns register napi as weight 256 but not recommended. According to this commit[2] we shall use weight 64 as suggested.
[1] netif_napi_add() called with weight 256
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=82dc3c63c692b1e1d59378ecee948ac88e034aad
[Test Case]
dmesg | grep netif_napi_add
[Fix]
commit acb1ce15a61154aa501891d67ebf79bc9ea26818
Author: Yonglong Liu <liuyonglong@huawei.com>
Date: Thu Apr 4 16:46:43 2019 +0800
net: hns: Use NAPI_POLL_WEIGHT for hns driver
When the HNS driver loaded, always have an error print:
"netif_napi_add() called with weight 256"
This is because the kernel checks the NAPI polling weights
requested by drivers and it prints an error message if a driver
requests a weight bigger than 64.
So use NAPI_POLL_WEIGHT to fix it.
Signed-off-by: Yonglong Liu <liuyonglong@huawei.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
[Regression Risk]
Only weight for NAPI changed. Lowest regression risk. |
|
2019-05-30 05:32:21 |
Khaled El Mously |
linux (Ubuntu Bionic): status |
Incomplete |
Fix Committed |
|
2019-05-30 05:32:25 |
Khaled El Mously |
linux (Ubuntu Cosmic): status |
Incomplete |
Fix Committed |
|
2019-05-30 05:32:28 |
Khaled El Mously |
linux (Ubuntu Disco): status |
Incomplete |
Fix Committed |
|
2019-06-18 12:01:21 |
Ubuntu Kernel Bot |
tags |
|
verification-needed-disco |
|
2019-06-18 12:02:42 |
Ubuntu Kernel Bot |
tags |
verification-needed-disco |
verification-needed-cosmic verification-needed-disco |
|
2019-06-18 16:02:29 |
Ubuntu Kernel Bot |
tags |
verification-needed-cosmic verification-needed-disco |
verification-needed-bionic verification-needed-cosmic verification-needed-disco |
|
2019-06-19 05:10:28 |
Ike Panhc |
tags |
verification-needed-bionic verification-needed-cosmic verification-needed-disco |
verification-done-bionic verification-done-cosmic verification-done-disco |
|
2019-07-22 10:53:34 |
Launchpad Janitor |
linux (Ubuntu Bionic): status |
Fix Committed |
Fix Released |
|
2019-07-22 10:53:34 |
Launchpad Janitor |
cve linked |
|
2018-12126 |
|
2019-07-22 10:53:34 |
Launchpad Janitor |
cve linked |
|
2018-12127 |
|
2019-07-22 10:53:34 |
Launchpad Janitor |
cve linked |
|
2018-12130 |
|
2019-07-22 10:53:34 |
Launchpad Janitor |
cve linked |
|
2019-11085 |
|
2019-07-22 10:53:34 |
Launchpad Janitor |
cve linked |
|
2019-11091 |
|
2019-07-22 10:53:34 |
Launchpad Janitor |
cve linked |
|
2019-11815 |
|
2019-07-22 10:53:34 |
Launchpad Janitor |
cve linked |
|
2019-11833 |
|
2019-07-22 10:53:34 |
Launchpad Janitor |
cve linked |
|
2019-11884 |
|
2019-07-23 05:25:24 |
Launchpad Janitor |
linux (Ubuntu Disco): status |
Fix Committed |
Fix Released |
|
2019-08-22 16:17:55 |
Ubuntu Kernel Bot |
tags |
verification-done-bionic verification-done-cosmic verification-done-disco |
verification-done-bionic verification-done-cosmic verification-done-disco verification-needed-xenial |
|
2019-08-23 01:49:19 |
Ike Panhc |
tags |
verification-done-bionic verification-done-cosmic verification-done-disco verification-needed-xenial |
verification-done-bionic verification-done-cosmic verification-done-disco |
|
2024-07-26 16:19:39 |
Brian Murray |
linux (Ubuntu Eoan): status |
Incomplete |
Won't Fix |
|
2024-07-26 16:58:15 |
Brian Murray |
linux (Ubuntu Cosmic): status |
Fix Committed |
Won't Fix |
|