| 2018-08-08 15:19:16 |
bugproxy |
bug |
|
|
added bug |
| 2018-08-08 15:19:24 |
bugproxy |
tags |
|
architecture-s39064 bugnameltc-170402 severity-high targetmilestone-inin1804 |
|
| 2018-08-08 15:19:25 |
bugproxy |
ubuntu: assignee |
|
Skipper Bug Screeners (skipper-screen-team) |
|
| 2018-08-08 15:19:28 |
bugproxy |
affects |
ubuntu |
linux (Ubuntu) |
|
| 2018-08-08 18:03:11 |
Andrew Cloke |
bug task added |
|
ubuntu-z-systems |
|
| 2018-08-08 18:03:22 |
Andrew Cloke |
ubuntu-z-systems: importance |
Undecided |
High |
|
| 2018-08-08 18:03:31 |
Andrew Cloke |
ubuntu-z-systems: assignee |
|
Canonical Kernel Team (canonical-kernel-team) |
|
| 2018-08-08 18:03:34 |
Andrew Cloke |
ubuntu-z-systems: status |
New |
Triaged |
|
| 2018-08-09 15:44:01 |
Joseph Salisbury |
linux (Ubuntu): importance |
Undecided |
High |
|
| 2018-08-09 15:44:06 |
Joseph Salisbury |
linux (Ubuntu): status |
New |
Triaged |
|
| 2018-08-09 15:44:18 |
Joseph Salisbury |
nominated for series |
|
Ubuntu Bionic |
|
| 2018-08-09 15:44:18 |
Joseph Salisbury |
bug task added |
|
linux (Ubuntu Bionic) |
|
| 2018-08-09 15:44:18 |
Joseph Salisbury |
nominated for series |
|
Ubuntu Xenial |
|
| 2018-08-09 15:44:18 |
Joseph Salisbury |
bug task added |
|
linux (Ubuntu Xenial) |
|
| 2018-08-09 15:44:24 |
Joseph Salisbury |
linux (Ubuntu Xenial): status |
New |
Triaged |
|
| 2018-08-09 15:44:28 |
Joseph Salisbury |
linux (Ubuntu Bionic): status |
New |
Triaged |
|
| 2018-08-09 15:44:31 |
Joseph Salisbury |
linux (Ubuntu Xenial): importance |
Undecided |
High |
|
| 2018-08-09 15:44:35 |
Joseph Salisbury |
linux (Ubuntu Bionic): importance |
Undecided |
High |
|
| 2018-08-09 15:45:45 |
Joseph Salisbury |
linux (Ubuntu Xenial): assignee |
|
Joseph Salisbury (jsalisbury) |
|
| 2018-08-09 15:45:48 |
Joseph Salisbury |
linux (Ubuntu Bionic): assignee |
|
Joseph Salisbury (jsalisbury) |
|
| 2018-08-09 15:45:52 |
Joseph Salisbury |
linux (Ubuntu): assignee |
Skipper Bug Screeners (skipper-screen-team) |
Joseph Salisbury (jsalisbury) |
|
| 2018-08-09 15:45:57 |
Joseph Salisbury |
linux (Ubuntu): status |
Triaged |
In Progress |
|
| 2018-08-09 15:45:59 |
Joseph Salisbury |
linux (Ubuntu Xenial): status |
Triaged |
In Progress |
|
| 2018-08-09 15:46:01 |
Joseph Salisbury |
linux (Ubuntu Bionic): status |
Triaged |
In Progress |
|
| 2018-08-09 16:10:26 |
Frank Heimes |
ubuntu-z-systems: status |
Triaged |
In Progress |
|
| 2018-08-14 20:15:58 |
Joseph Salisbury |
description |
Description: qeth: don't clobber buffer on async TX completion
Symptom: Failing transmissions on af_iucv HiperTransport socket.
Problem: If qeth_qdio_output_handler() detects that a transmit
requires async completion, it replaces the pending buffer's
metadata object (qeth_qdio_out_buffer) so that this queue
buffer can be re-used while the data is pending completion.
Later when the CQ indicates async completion of such a
metadata object, qeth_qdio_cq_handler() tries to free any
data associated with this object (since HW has now completed
the transfer). By calling qeth_clear_output_buffer(), it
erronously operates on the queue buffer that _previously_
belonged to this transfer ... but which has been potentially
re-used several times by now. This results in double-free's
of the buffer's data, and failing transmits as the buffer
descriptor is scrubbed in mid-air.
Solution: First only scrub the queue buffer when it is prepared
for re-use, and later obtain the data addresses from
the async-completion notifier (ie. the AOB), instead
of the queue buffer.
Reproduction: Heavy multi-connection workload on an af_iucv
HiperTransport socket.
Upstream-ID: ce28867fd20c23cd769e78b4d619c4755bf71a1c
Kernel 4.18
Will be introduced with kernel 4.18 in Cosmic.
But should also be applied to Bionic and Xenial |
== SRU Justification ==
IBM is requesting this commit for s390. This fixes a bug introduced by
mainline commit 0da9581ddb0f. The symptom of the bug is Failing transmissions
on af_iucv HiperTransport socket.
Xenial also needs this patch, but it required a backport, so it will be
SRU'd separately.
== Fix ==
ce28867fd20c ("s390/qeth: don't clobber buffer on async TX completion")
== Regression Potential ==
Low. Limited to s390.
== Test Case ==
A test kernel was built with this patch and tested by the original bug reporter.
The bug reporter states the test kernel resolved the bug.
Description: qeth: don't clobber buffer on async TX completion
Symptom: Failing transmissions on af_iucv HiperTransport socket.
Problem: If qeth_qdio_output_handler() detects that a transmit
requires async completion, it replaces the pending buffer's
metadata object (qeth_qdio_out_buffer) so that this queue
buffer can be re-used while the data is pending completion.
Later when the CQ indicates async completion of such a
metadata object, qeth_qdio_cq_handler() tries to free any
data associated with this object (since HW has now completed
the transfer). By calling qeth_clear_output_buffer(), it
erronously operates on the queue buffer that _previously_
belonged to this transfer ... but which has been potentially
re-used several times by now. This results in double-free's
of the buffer's data, and failing transmits as the buffer
descriptor is scrubbed in mid-air.
Solution: First only scrub the queue buffer when it is prepared
for re-use, and later obtain the data addresses from
the async-completion notifier (ie. the AOB), instead
of the queue buffer.
Reproduction: Heavy multi-connection workload on an af_iucv
HiperTransport socket.
Upstream-ID: ce28867fd20c23cd769e78b4d619c4755bf71a1c
Kernel 4.18
Will be introduced with kernel 4.18 in Cosmic.
But should also be applied to Bionic and Xenial |
|
| 2018-08-27 10:31:04 |
Kleber Sacilotto de Souza |
linux (Ubuntu Xenial): status |
In Progress |
Fix Committed |
|
| 2018-08-27 11:50:39 |
Frank Heimes |
linux (Ubuntu Bionic): status |
In Progress |
Fix Committed |
|
| 2018-08-27 11:51:27 |
Frank Heimes |
linux (Ubuntu): status |
In Progress |
Fix Committed |
|
| 2018-08-27 11:51:59 |
Frank Heimes |
linux (Ubuntu): status |
Fix Committed |
In Progress |
|
| 2018-08-28 17:01:40 |
Brad Figg |
tags |
architecture-s39064 bugnameltc-170402 severity-high targetmilestone-inin1804 |
architecture-s39064 bugnameltc-170402 severity-high targetmilestone-inin1804 verification-needed-bionic |
|
| 2018-08-28 18:45:31 |
Frank Heimes |
tags |
architecture-s39064 bugnameltc-170402 severity-high targetmilestone-inin1804 verification-needed-bionic |
architecture-s39064 bugnameltc-170402 severity-high targetmilestone-inin1804 verification-done-bionic |
|
| 2018-08-28 19:32:05 |
Frank Heimes |
linux (Ubuntu): status |
In Progress |
Fix Committed |
|
| 2018-08-28 19:32:07 |
Frank Heimes |
ubuntu-z-systems: status |
In Progress |
Fix Committed |
|
| 2018-08-29 11:04:29 |
Brad Figg |
tags |
architecture-s39064 bugnameltc-170402 severity-high targetmilestone-inin1804 verification-done-bionic |
architecture-s39064 bugnameltc-170402 severity-high targetmilestone-inin1804 verification-done-bionic verification-needed-xenial |
|
| 2018-08-29 13:00:30 |
Frank Heimes |
tags |
architecture-s39064 bugnameltc-170402 severity-high targetmilestone-inin1804 verification-done-bionic verification-needed-xenial |
architecture-s39064 bugnameltc-170402 severity-high targetmilestone-inin1804 verification-done verification-done-bionic verification-done-xenial |
|
| 2018-09-10 17:53:06 |
Launchpad Janitor |
linux (Ubuntu Bionic): status |
Fix Committed |
Fix Released |
|
| 2018-09-10 17:53:06 |
Launchpad Janitor |
cve linked |
|
2018-1118 |
|
| 2018-09-10 17:54:50 |
Launchpad Janitor |
linux (Ubuntu Xenial): status |
Fix Committed |
Fix Released |
|
| 2018-09-11 05:32:20 |
Frank Heimes |
linux (Ubuntu): status |
Fix Committed |
Fix Released |
|
| 2018-09-11 05:32:32 |
Frank Heimes |
ubuntu-z-systems: status |
Fix Committed |
Fix Released |
|
| 2019-07-24 20:22:45 |
Brad Figg |
tags |
architecture-s39064 bugnameltc-170402 severity-high targetmilestone-inin1804 verification-done verification-done-bionic verification-done-xenial |
architecture-s39064 bugnameltc-170402 cscc severity-high targetmilestone-inin1804 verification-done verification-done-bionic verification-done-xenial |
|
