Broadcom: IT (HBA) Driver Enablement in 18.04 (Patches)

[Michael Reed]

The purpose of this bug is to track the patches needed to enable the IT (HBA) driver into 18.04.

Below are upstream commit ids of IT driver which went in over the in-box driver of Ubuntu18.04 OS’s base kernel,

864449eea7c600596e305ffdc4a6a846414b222c scsi: mpt3sas: Do not mark fw_event workqueue as WQ_MEM_RECLAIM

6f9e09fd6488de7661ee20efb5d8ab4e05a59735 scsi: mpt3sas: clarify mmio pointer types

40114bde9773ccaf9ad77233ac2cc9039f0f2941 scsi: mpt3sas: Do not use 32-bit atomic request descriptor for Ventura controllers.

b4472d7180894c96b6133ef5ff3df50836591eaa scsi: mpt3sas: Introduce function to clone mpi reply.

e5747439366c1079257083f231f5dd9a84bf0fd7 scsi: mpt3sas: Introduce function to clone mpi request.

182ac784b41faee02e8b44cd7149575258ad6858 scsi: mpt3sas: Introduce Base function for cloning.

22ae5a3c2599381cf7aaa5aca25c515a3166adcc scsi: mpt3sas: Introduce API to get BAR0 mapped buffer address

0448f0195124e33f11d15b7d1e1cab959989eee7 scsi: mpt3sas: Configure reply post queue depth, DMA and sgl tablesize.

c520691b38cde1d94f53e5782feba892f5645043 scsi: mpt3sas: Add PCI device ID for Andromeda.

4a8842de8db4953fdda7866626b78b12fb8adb97 scsi: mpt3sas: fix an out of bound write

61dfb8a5fb7e93e692856026fa4c778a27f28984 scsi: mpt3sas: make function _get_st_from_smid static

dbec4c9040edc15442c3ebdb65408aa9d3b82c24 scsi: mpt3sas: lockless command submission

272e253c7bcabfeef5f4d0aaed94a413e13e520f scsi: mpt3sas: simplify _wait_for_commands_to_complete()

6da999fe5a9285c2a78f3cf1e768abcd48d7607e scsi: mpt3sas: simplify mpt3sas_scsi_issue_tm()

74fcfa5371b7a681e864d3a9d3b9ecfd5737d8ea scsi: mpt3sas: simplify task management functions

b0cd285eb57cd3cb18d882565c22d39bccffe7f0 scsi: mpt3sas: always use first reserved smid for ioctl passthrough

9961c9bbf2b43acaaf030a0fbabc9954d937ad8c scsi: mpt3sas: check command status before attempting abort

12e7c6782bc58128392b768fc2a87b230414a2a5 scsi: mpt3sas: Introduce mpt3sas_get_st_from_smid()

02a386df3678275b01eec71fee39735c379e4a2a scsi: mpt3sas: open-code _scsih_scsi_lookup_get()

6a2d4618aef3d4ffb83514e5e58a091d61e54a03 scsi: mpt3sas: separate out _base_recovery_check()

05303dfb738066ad597d7feb422ff9fa2d3d8ef3 scsi: mpt3sas: use list_splice_init()

ba4494d47bd02e5757b449a2cc2222fa3ff87bc8 scsi: mpt3sas: set default value for cb_idx

f49d4aed1315a7b766d855f1367142e682b0cc87 scsi: mpt3sas: Proper handling of set/clear of "ATA command pending" flag.

45b7aef7fb7d5f5bfa3a2a6727f1accf7660f6fd scsi: mpt3sas: Remove unused variable requeue_event

[Michael Reed (mreed8855)]

Also we have posted some patches to the upstream community and they are yet to be accepted by the upstream,

mpt3sas: Bug fix for big endian systems.

  mpt3sas: Pre-allocate RDPQ Array at driver boot time.

  mpt3sas: Lockless access for chain buffers.

  mpt3sas: Optimize I/O memory consumption in driver.

  mpt3sas: Enhanced handling of Sense Buffer.

  mpt3sas: Added support for SAS Device Discovery Error Event.

  mpt3sas: Increase event log buffer to support 24 port HBA's.

  mpt3sas: Allow processing of events during driver unload.

  mpt3sas: Cache enclosure pages during enclosure add.

  mpt3sas: Report Firmware Package Version from HBA Driver.

  mpt3sas: Update MPI Headers

  mpt3sas: For NVME device, issue a protocol level reset instead of

    hot reset and use TM timeout value exposed in PCIe Device Page 2.

  mpt3sas: fix possible memory leak.

  mpt3sas: Update driver version "25.100.00.00"

[Michael Reed (mreed8855)]

Currently we are waiting on the commit IDs for the patches listed in comment #1

[Jerry Clement (jerry-clement)]

Adding commit IDs for patches referenced above:

All these patches are queued for the next kernel (4.18) update in the SCSI branch. Once the window for the 4.18 is open, these patches will be pushed from SCSI branch to the tip kernel. Current tip kernel 4.17-rc7 doesn’t have these changes in it.

  mpt3sas: Bug fix for big endian systems. : commit cf6bf9710cabba1fe94a4349f4eb8db623c77ebc
  mpt3sas: Pre-allocate RDPQ Array at driver boot time : commit cd33223b59a4938f9ae890bc5ae4196398e9abe0
  mpt3sas: Lockless access for chain buffers : commit 93204b782a88f2067ff83cb732b66236644c4c56
  mpt3sas: Optimize I/O memory consumption in driver: commit 74522a92bbf003111852d77f1a95d961c1de7baf
  mpt3sas: Enhanced handling of Sense Buffer: commit e21fef6f331b3977018f35ef38c91dccf2ebc5ae
  mpt3sas: Added support for SAS Device Discovery Error Event: commit 95540b8eaf30d224ba0723f5a109aa52fd996c6f
  mpt3sas: Increase event log buffer to support 24 port HBA's: commit 1537d1bfc58858f2e0a86c37977d92b05e0afa2e
  mpt3sas: Allow processing of events during driver unload: commit 79eb96d6ca6971e79a3770991a12a16fde871e90
  mpt3sas: Cache enclosure pages during enclosure add: commit 22a923c315ba09a83ef88ff1d968413d9dd8fb75
  mpt3sas: Report Firmware Package Version from HBA Driver: commit 3d29ed85fc9ca673fbae0f97178ef64c1314f7e2
  mpt3sas: Update MPI Headers: commit 65928d1f4130a48732034c2f31b2b0790694537f
  mpt3sas: For NVME device, issue a protocol level reset instead of hot reset and use TM timeout value exposed in PCIe Device Page 2.: commit c1a6c5ac4278d406c112cc2f038e6e506feadff9
  mpt3sas: fix possible memory leak: commit 87b3576e9eaba85644c643bb55b485b5330a2af5
  mpt3sas: Update driver version "25.100.00.00" commit f6972d7180909787a324b83bf3f2f0686f22286a”

[Joseph Salisbury (jsalisbury)]

I built a Bionic test kernel with the requested 37 patches.

 The test kernel can be downloaded from:
http://kernel.ubuntu.com/~jsalisbury/lp1772434

Can you test this kernel and see if it resolves this bug?

Note about installing test kernels:
• If the test kernel is prior to 4.15(Bionic) you need to install the linux-image and linux-image-extra .deb packages.
• If the test kernel is 4.15(Bionic) or newer, you need to install the linux-modules, linux-modules-extra and linux-image-unsigned .deb packages.

Thanks in advance!

[Sujith Pandel (sujithpandel)]

Can you guys share the release plans for kernel-4.15.0-33.36?
We have a installation/boot failure with HBA330 and the patches in this list are fixing it.

[Joseph Salisbury (jsalisbury)]

Hi Sujith,

Do you know if the test kernel posted in comment #4 was tested? It's been some time, and I think we were waiting for the test result of that kernel before submitting the SRU request.

[Jeff Lane  (bladernr)]

Closing, this is an old bug and this support likely landed long ago.