Need fix to aacraid driver to prevent panic

Bug #1770095 reported by bugproxy on 2018-05-09
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
The Ubuntu-power-systems project
Critical
Canonical Kernel Team
linux (Ubuntu)
Critical
Joseph Salisbury
Bionic
Critical
Joseph Salisbury

Bug Description

== SRU Justification ==
A commit introduced in mainline v4.14-rc1 to aacraid
(b60710ec7d7ab1ca277b458338563ac21b393906) introduced a regression whereby a
panic may happen under certain recovery situations.

This regression is fixed by linux-next commit 7d3af7d96af7.

== Fix ==
7d3af7d96af7 ("scsi: aacraid: Correct hba_send to include iu_type")

== Regression Potential ==
Low. This patch fixes a current regression. It was cc'd to upstream
stable, so it has had additonal upstream review.

== Test Case ==
A test kernel was built with this patch and tested by the original bug reporter.
The bug reporter states the test kernel resolved the bug.

== Comment: #0 - Douglas Miller <email address hidden> - 2018-05-08 15:45:13 ==
+++ This bug was initially created as a clone of Bug #167565 +++

A recent commit to aacraid (b60710ec7d7ab1ca277b458338563ac21b393906) introduced a bug whereby a panic may happen under certain recovery situations. The following commit fixes that:

https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git/commit/?h=fixes&id=7d3af7d96af7b9f51e1ef67b6f4725f545737da2

We need this commit backported to Ubuntu 18.04

bugproxy (bugproxy) on 2018-05-09
tags: added: architecture-ppc64le bugnameltc-167566 severity-critical targetmilestone-inin---
Changed in ubuntu:
assignee: nobody → Ubuntu on IBM Power Systems Bug Triage (ubuntu-power-triage)
affects: ubuntu → linux (Ubuntu)
Changed in ubuntu-power-systems:
status: New → Triaged
importance: Undecided → Critical
assignee: nobody → Canonical Kernel Team (canonical-kernel-team)
tags: added: triage-g
Changed in linux (Ubuntu):
importance: Undecided → Critical
status: New → Triaged
assignee: Ubuntu on IBM Power Systems Bug Triage (ubuntu-power-triage) → Joseph Salisbury (jsalisbury)
Changed in linux (Ubuntu Bionic):
status: New → Triaged
importance: Undecided → Critical
assignee: nobody → Joseph Salisbury (jsalisbury)
Changed in linux (Ubuntu Bionic):
status: Triaged → In Progress
Changed in linux (Ubuntu):
status: Triaged → In Progress
Joseph Salisbury (jsalisbury) wrote :

I built a test kernel with linux-next commit 7d3af7d96af7b9f51e1ef67b6f4725f545737da2. The test kernel can be downloaded from:
http://kernel.ubuntu.com/~jsalisbury/lp1770095

Can you test this kernel and see if it resolves this bug?

Note about installing test kernels:
• If the test kernel is prior to 4.15(Bionic) you need to install the linux-image and linux-image-extra .deb packages.
• If the test kernel is 4.15(Bionic) or newer, you need to install the linux-image-unsigned, linux-modules and linux-modules-extra .deb packages.

Thanks in advance

------- Comment From <email address hidden> 2018-05-15 16:18 EDT-------
The source code package seems to be empty, so I can't confirm by inspection. Still awaiting actually load and test. I do see that this experimental kernel did not alter the version so it will collide with any installation of 4.15.0-20.21 "standard" install.

Joseph Salisbury (jsalisbury) wrote :

Would you like me to build another test kernel with a version, so it won't collide?

bugproxy (bugproxy) wrote :

------- Comment From <email address hidden> 2018-05-16 11:05 EDT-------
(In reply to comment #8)
> Would you like me to build another test kernel with a version, so it won't
> collide?

I haven't heard back from Naveed, who was going to test last night. I hate to ask for a new kernel if he was able to test.

But, this brings up a question I had. I am not familiar with the Ubuntu build procedures, so I'm just comparing to RedHat and Linux Makefile. In those build methods, there is a way to append an arbitrary string to the version (EXTRAVERSION) and it allows the kernel to avoid conflicts. Does such a mechanism exist for Ubuntu builds? Up to now, it seems that only numeric strings are being appended (e.g. "-21", "-90").

Joseph Salisbury (jsalisbury) wrote :

Yes, you can add EXTRAVERSION info to the kernel name. This is done in the file: ~/debian.master/changelog. The top line would be changed like the following:

linux (4.15.0-20.21) bionic; urgency=medium

TO

linux (4.15.0-20.21~lp1770095) bionic; urgency=medium

Manoj Iyer (manjo) on 2018-05-24
Changed in ubuntu-power-systems:
status: Triaged → In Progress
Joseph Salisbury (jsalisbury) wrote :

Is there any update on testing of the test kernel?

bugproxy (bugproxy) wrote :

------- Comment From <email address hidden> 2018-06-12 16:13 EDT-------
We don't see the panic anymore, with the test kernel.

Joseph Salisbury (jsalisbury) wrote :
description: updated
Changed in linux (Ubuntu Bionic):
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers