snapcraft.yaml: skip non-existent firmware_install step

[Paolo Pisati]

[Impact]

Linux kernel removed the 'firmware_install' step long ago (~4.13), so invoking it results in a broken kernel snap build:

...
make -j4 CONFIG_PREFIX=/build/pc-kernel/parts/kernel/install modules_install INSTALL_MOD_PATH=/build/pc-kernel/parts/kernel/install dtbs_install INSTALL_DTBS_PATH=/build/pc-kernel/parts/kernel/install/dtbs firmware_install INSTALL_FW_PATH=/build/pc-kernel/parts/kernel/install/lib/firmware
Failed to run 'make -j4 CONFIG_PREFIX=/build/pc-kernel/parts/kernel/install modules_install INSTALL_MOD_PATH=/build/pc-kernel/parts/kernel/install dtbs_install INSTALL_DTBS_PATH=/build/pc-kernel/parts/kernel/install/dtbs firmware_install INSTALL_FW_PATH=/build/pc-kernel/parts/kernel/install/lib/firmware' for 'kernel': Exited with code 2.
Verify that the part is using the correct parameters and try again.

During the last snapcraft patch, i accidentally removed the directive to skip it.

[Fix]

Apply the attached patch

[Test]

Try to snap a kernel:

$ snapcraft --target-arch=arm

...
The version has been set to '4.15.0-1022.24'
Snapping 'pi2-kernel' |
Snapped pi2-kernel_4.15.0-1022.24_armhf.snap

[Regression]

None, it actually fixes a regression.

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux-raspi2 - 4.15.0-1024.26

---------------
linux-raspi2 (4.15.0-1024.26) bionic; urgency=medium

  [ Ubuntu: 4.15.0-36.39 ]

  * CVE-2018-14633
    - iscsi target: Use hex2bin instead of a re-implementation
  * CVE-2018-17182
    - mm: get rid of vmacache_flush_all() entirely

linux-raspi2 (4.15.0-1023.25) bionic; urgency=medium

  * linux-raspi2: 4.15.0-1023.25 -proposed tracker (LP: #1791720)

  * [Bionic] Spectre v4 mitigation (Speculative Store Bypass Disable) support
    for arm64 using SMC firmware call to set a hardware chicken bit
    (LP: #1787993)
    - [Config] update configs after rebase on master

  * snapcraft.yaml: skip non-existent firmware_install step (LP: #1789897)
    - snapcraft.yaml: skip non-existent firmware_install step

  [ Ubuntu: 4.15.0-35.38 ]

  * linux: 4.15.0-35.38 -proposed tracker (LP: #1791719)
  * device hotplug of vfio devices can lead to deadlock in vfio_pci_release
    (LP: #1792099)
    - SAUCE: vfio -- release device lock before userspace requests
  * L1TF mitigation not effective in some CPU and RAM combinations
    (LP: #1788563)
    - x86/speculation/l1tf: Fix overflow in l1tf_pfn_limit() on 32bit
    - x86/speculation/l1tf: Fix off-by-one error when warning that system has too
      much RAM
    - x86/speculation/l1tf: Increase l1tf memory limit for Nehalem+
  * CVE-2018-15594
    - x86/paravirt: Fix spectre-v2 mitigations for paravirt guests
  * CVE-2017-5715 (Spectre v2 s390x)
    - KVM: s390: implement CPU model only facilities
    - s390: detect etoken facility
    - KVM: s390: add etoken support for guests
    - s390/lib: use expoline for all bcr instructions
    - s390: fix br_r1_trampoline for machines without exrl
    - SAUCE: s390: use expoline thunks for all branches generated by the BPF JIT
  * Ubuntu18.04.1: cpuidle: powernv: Fix promotion from snooze if next state
    disabled (performance) (LP: #1790602)
    - cpuidle: powernv: Fix promotion from snooze if next state disabled
  * Watchdog CPU:19 Hard LOCKUP when kernel crash was triggered (LP: #1790636)
    - powerpc: hard disable irqs in smp_send_stop loop
    - powerpc: Fix deadlock with multiple calls to smp_send_stop
    - powerpc: smp_send_stop do not offline stopped CPUs
    - powerpc/powernv: Fix opal_event_shutdown() called with interrupts disabled
  * Security fix: check if IOMMU page is contained in the pinned physical page
    (LP: #1785675)
    - vfio/spapr: Use IOMMU pageshift rather than pagesize
    - KVM: PPC: Check if IOMMU page is contained in the pinned physical page
  * Missing Intel GPU pci-id's (LP: #1789924)
    - drm/i915/kbl: Add KBL GT2 sku
    - drm/i915/whl: Introducing Whiskey Lake platform
    - drm/i915/aml: Introducing Amber Lake platform
    - drm/i915/cfl: Add a new CFL PCI ID.
  * CVE-2018-15572
    - x86/speculation: Protect against userspace-userspace spectreRSB
  * Support Power Management for Thunderbolt Controller (LP: #1789358)
    - thunderbolt: Handle NULL boot ACL entries properly
    - thunderbolt: Notify userspace when boot_acl is changed
    - thunderbolt: Use 64-bit DMA mask if supported by the platform
    - thunderbolt: Do not unnecessarily call I...

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.