Bionic linux 4.15.0-56.62 fails to build with CONFIG_NVM disabled
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
linux (Ubuntu) |
Invalid
|
Undecided
|
Unassigned | ||
Xenial |
Invalid
|
Undecided
|
Unassigned | ||
Bionic |
Fix Released
|
Undecided
|
Unassigned | ||
linux-azure (Ubuntu) |
Invalid
|
Undecided
|
Unassigned | ||
Xenial |
Fix Released
|
Undecided
|
Unassigned | ||
Bionic |
Invalid
|
Undecided
|
Unassigned |
Bug Description
[Impact]
When compiling bionic linux 4.15.0-56.62 with CONFIG_NVM disabled, it fails with:
make[5]: *** [drivers/
make[5]: *** Waiting for unfinished jobs....
In file included from /tmp/kernel-
/tmp/kernel-
/tmp/kernel-
if (ctrl->subsys->cmic & (1 << 3))
^
/tmp/kernel-
[Fix]
The culprit seems to be this patch:
commit 993f70b886c0062
Author: Christoph Hellwig <email address hidden>
Date: Tue Nov 20 16:57:54 2018 +0100
nvme: warn when finding multi-port subsystems without multipathing enabled
BugLink: https:/
[ Upstream commit 14a1336e6fff47d
[...]
--- a/drivers/
+++ b/drivers/
@@ -499,6 +499,9 @@ static inline int nvme_nvm_
static inline void nvme_nvm_
static inline int nvme_nvm_
{
+ if (ctrl->subsys->cmic & (1 << 3))
+ dev_warn(
+"Please enable CONFIG_
return 0;
}
which is adding the new lines to a different function than the original upstream commit:
--- a/drivers/
+++ b/drivers/
@@ -531,6 +531,9 @@ static inline void nvme_mpath_
static inline int nvme_mpath_
{
+ if (ctrl->subsys->cmic & (1 << 3))
+ dev_warn(
+"Please enable CONFIG_
return 0;
}
This patch was probably wrongly backported for bug #1837161 from linux-4.19.y stable and not needed since bionic/linux lacks commit 0d0b660f214d (nvme: add ANA support) which introduced nvme_mpath_init(). The fix is to revert this patch.
[Test Case]
Disabled kernel config CONFIG_NVM and compile the kernel.
[Regression Potential]
Low. The patch was wrongly backported and can be safely reverted.
CVE References
Changed in linux (Ubuntu Xenial): | |
status: | New → Invalid |
Changed in linux (Ubuntu): | |
status: | New → Invalid |
Changed in linux (Ubuntu Bionic): | |
status: | New → Confirmed |
Changed in linux-azure (Ubuntu): | |
status: | New → Invalid |
Changed in linux-azure (Ubuntu Xenial): | |
status: | New → Confirmed |
Changed in linux-azure (Ubuntu Bionic): | |
status: | New → Invalid |
description: | updated |
Changed in linux (Ubuntu Bionic): | |
status: | Confirmed → Fix Committed |
Changed in linux-azure (Ubuntu Xenial): | |
status: | Confirmed → Fix Committed |
This bug was fixed in the package linux-azure - 4.15.0-1055.60
---------------
linux-azure (4.15.0-1055.60) xenial; urgency=medium
* xenial/linux-azure: 4.15.0-1055.60 -proposed tracker (LP: #1839287)
* Packaging resync (LP: #1786013)
- [Packaging] update helper scripts
[ Ubuntu: 4.15.0-58.64 ]
* unable to handle kernel NULL pointer dereference at 000000000000002c (IP: locked+ 0x9e/0x1f0) (LP: #1838982) new_inode( )"
iget5_
- Revert "ovl: set I_CREATING on inode being created"
- Revert "new primitive: discard_
-- Marcelo Henrique Cerri <email address hidden> Thu, 08 Aug 2019 14:52:35 -0300