libunistring and libidn ftbfs on 18.04 LTS

[Matthias Klose]

Impact
------
libunistring doesn't build from source which means someone would need to fix that problem before fixing any bugs in the libunistring package for Ubuntu 18.04 LTS.

Test Case
---------
Does libunistring build successfully?

Regression Potential
--------------------
We are simply backporting the workaround we applied in Ubuntu 19.04.

Original Bug Report
-------------------
according to
http://people.canonical.com/~doko/ftbfs-report/test-rebuild-20181222-bionic.html

libunistring ftbfs.

FAIL: test-thread_create
========================

glthread_create failed
FAIL test-thread_create (exit status: 1)

[Sebastien Bacher (seb128)]

Cosmic got that workaround, it includes no details about the issue it fixes but could be the same one?
http://launchpadlibrarian.net/379762076/libunistring_0.9.10-1_0.9.10-1ubuntu1.diff.gz

[Gianfranco Costamagna (costamagnagianfranco)]

yes, it is the same, but unfortunately I don't know if the fix is sane or not.
the real bug is this one
https://bugs.launchpad.net/ubuntu/+source/binutils/+bug/1340250

[Łukasz Zemczak (sil2100)]

An upload of libunistring to bionic-proposed has been rejected from the upload queue for the following reason: "This upload has only an FTBFS bug attached to it even though it's a new upstream release SRU (from 0.9.9 tp 0.9.10). That does not seem like the 'fix' to a FTBFS issue. Please re-upload with just the FTBFS fix or fill in additional SRU bugs for all the other changes.".

[Bruno Haible (bruno-clisp)]

The FTBFS was fixed upstream, in gnulib (from which libunistring takes most of its source files), through this commit:
https://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=cca32830b57e91f837c01d15b8732f23ff97fc36

[Gianfranco Costamagna (costamagnagianfranco)]

I uploaded the upstream patch in the unapproved queue, thanks!

[Gianfranco Costamagna (costamagnagianfranco)]

In the same way, I'm uploading a fix for libidn, I think it is really better to have as-needed used for the binary size, so better use the upstream patch and revert the package currently in updates.

[Brian Murray (brian-murray)]

Hello Matthias, or anyone else affected,

Accepted libunistring into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libunistring/0.9.9-0ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Brian Murray (brian-murray)]

The regression potential here in the description is incorrect "We are simply backporting the workaround we applied in Ubuntu 18.10." The fix in Ubuntu 18.10 for both packages was to add "--no-as-needed" to the build options which you now indicate is a worse solution. Please also upload the better fix to the cosmic SRU queue.

[Gianfranco Costamagna (costamagnagianfranco)]

Ok Brian, so lets backport the fix from 19.04 and fix also 18.10

[Gianfranco Costamagna (costamagnagianfranco)]

libunistring backport patch to cosmic from Disco:
diff -Nru libunistring-0.9.10/debian/changelog libunistring-0.9.10/debian/changelog
--- libunistring-0.9.10/debian/changelog 2018-07-23 16:46:28.000000000 +0200
+++ libunistring-0.9.10/debian/changelog 2019-03-27 12:21:30.000000000 +0100
@@ -1,3 +1,10 @@
+libunistring (0.9.10-1ubuntu1.18.10.1) cosmic; urgency=medium
+
+ * Cherry-pick pthread fix from upstream and disco release.
+ (LP: #1813587)
+
+ -- Gianfranco Costamagna <email address hidden> Wed, 27 Mar 2019 12:21:30 +0100
+
 libunistring (0.9.10-1ubuntu1) cosmic; urgency=medium

   * Do not set as-needed, to work-around a testsuite failure
diff -Nru libunistring-0.9.10/debian/patches/cca32830b57e91f837c01d15b8732f23ff97fc36.patch libunistring-0.9.10/debian/patches/cca32830b57e91f837c01d15b8732f23ff97fc36.patch
--- libunistring-0.9.10/debian/patches/cca32830b57e91f837c01d15b8732f23ff97fc36.patch 1970-01-01 01:00:00.000000000 +0100
+++ libunistring-0.9.10/debian/patches/cca32830b57e91f837c01d15b8732f23ff97fc36.patch 2019-03-27 12:21:14.000000000 +0100
@@ -0,0 +1,15 @@
+Description: Fix link failure with upstream gnulib patch
+Origin: https://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=cca32830b57e91f837c01d15b8732f23ff97fc36
+Last-Update: 2019-03-20
+
+--- libunistring-0.9.10.orig/tests/glthread/thread.h
++++ libunistring-0.9.10/tests/glthread/thread.h
+@@ -133,8 +133,6 @@ extern int glthread_in_use (void);
+ call to foo(...) in the same function. To avoid this, we test the
+ address of a function in libpthread that we don't use. */
+
+-# pragma weak pthread_create
+-
+ # ifndef pthread_sigmask /* Do not declare rpl_pthread_sigmask weak. */
+ # pragma weak pthread_sigmask
+ # endif
diff -Nru libunistring-0.9.10/debian/patches/series libunistring-0.9.10/debian/patches/series
--- libunistring-0.9.10/debian/patches/series 2018-07-23 16:46:28.000000000 +0200
+++ libunistring-0.9.10/debian/patches/series 2019-03-27 12:21:14.000000000 +0100
@@ -1,2 +1,3 @@
 0100-float-endian-detection.patch
 0700-multiarch-libc.patch
+cca32830b57e91f837c01d15b8732f23ff97fc36.patch

[Gianfranco Costamagna (costamagnagianfranco)]

@Brian

Now the disco fix is in both cosmic and bionic queues.
please accept them :)
I checked if wl-asneeded was removed from rules, if the patch was added, and also the upgrade path for versioning was correct for bionic->cosmic->disco

please double check! I also fixed the description

[Timo Aaltonen (tjaalton)]

Hello Matthias, or anyone else affected,

Accepted libidn into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libidn/1.33-2.2ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Timo Aaltonen (tjaalton)]

Hello Matthias, or anyone else affected,

Accepted libidn into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libidn/1.33-2.1ubuntu1.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Timo Aaltonen (tjaalton)]

Hello Matthias, or anyone else affected,

Accepted libunistring into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libunistring/0.9.10-1ubuntu1.18.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Gianfranco Costamagna (costamagnagianfranco)]

This is something that is currently fixing just a build failure, not something that the end user is affected... Marking as verification done (and I'm using the package because my system is on bionic)

[Robie Basak (racb)]

What about Cosmic? Has anyone actually checked that the packages still work on Cosmic?

[Matthias Klose (doko)]

> What about Cosmic? Has anyone actually checked that
> the packages still work on Cosmic?

why should we? We cannot afford doing test rebuilds for every supported release at the same time. And this is such an issue found for the test rebuilds.

[Gianfranco Costamagna (costamagnagianfranco)]

its a build fix...
anyway, its a library, so not that easy to test, but I picked up gnome-characters, one of its reverse-dependencies that uses a lot of unicode, and it still works

gnome-characters
Gtk-Message: 09:13:35.039: Failed to load module "canberra-gtk-module"
Gtk-Message: 09:13:35.039: Failed to load module "canberra-gtk-module"
Gjs-Message: 09:13:35.042: JS LOG: Characters Application started
Gjs-Message: 09:13:38.057: JS LOG: Characters Application exiting
dpkg -l |grep unistr
ii libunistring2:amd64 0.9.10-1ubuntu1.18.10.1 amd64 Unicode string library for C

ii libidn11:amd64 1.33-2.2ubuntu1.1 amd64 GNU Libidn library, implementation of IETF IDN specifications
ii libidn2-0:amd64 2.0.5-1 amd64 Internationalized domain names (IDNA2008/TR46) library

to test libidn I installed and started successfully vlc.

[Launchpad Janitor (janitor)]

This bug was fixed in the package libunistring - 0.9.9-0ubuntu2

---------------
libunistring (0.9.9-0ubuntu2) bionic; urgency=medium

  * Cherry-pick pthread fix from upstream and disco release.
    (LP: #1813587)

 -- Gianfranco Costamagna <email address hidden> Thu, 21 Mar 2019 10:30:01 +0100

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for libunistring has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package libunistring - 0.9.10-1ubuntu1.18.10.1

---------------
libunistring (0.9.10-1ubuntu1.18.10.1) cosmic; urgency=medium

  * Cherry-pick pthread fix from upstream and disco release.
    (LP: #1813587)

 -- Gianfranco Costamagna <email address hidden> Wed, 27 Mar 2019 12:21:30 +0100

[Launchpad Janitor (janitor)]

This bug was fixed in the package libidn - 1.33-2.2ubuntu1.1

---------------
libidn (1.33-2.2ubuntu1.1) cosmic; urgency=medium

  * Fix build failure in the proper way, with upstream gnulib patch
    LP: #1813587

 -- Gianfranco Costamagna <email address hidden> Wed, 27 Mar 2019 12:39:19 +0100

[Launchpad Janitor (janitor)]

This bug was fixed in the package libidn - 1.33-2.1ubuntu1.2

---------------
libidn (1.33-2.1ubuntu1.2) bionic; urgency=medium

  * Fix build failure in the proper way, with upstream gnulib patch
    LP: #1813587

 -- Gianfranco Costamagna <email address hidden> Thu, 21 Mar 2019 10:33:11 +0100