Backport for 22.04, 20.04, and 18.04

[John Cabaj]

[Impact]

* Request to backport Azure Site Recovery Disk Filter Driver to Jammy (22.04), Focal (20.04), and Bionic (18.04)

[Fix]

* Simple re-package, with updated dependencies

[Test Plan]

* Compile and install dkms module
* Microsoft tested

[Where problems could occur]

* Code could fail load and unload module in some manner

[John Cabaj (john-cabaj)]

Debdiffs provided. Packages also uploaded to https://launchpad.net/~john-cabaj/+archive/ubuntu/asrdfd.

[Paride Legovini (paride)]

Hello, I am not sure this is ready for sponsorship (I see it's In Progress), but I had a look at the debdiffs and I have some comments.

1. I see this is going to be a New package for Bionic/Focal/Jammy. Will this package in the future require backports of new upstream versions to stable releases because of compatibility reasons? (Note that I'm not familiar with the package!) If this is the case, you'll need a SRU exception [1], and I suggest using the same debhelper compat level for all the uploads, even those to newer releases. This will make reviewing easier.

2. In the upload manifests for stable releases (the .changes files), please include the full changelog of the packages, see dpkg-buildpackage -v (passed to dpkg-genchanges).

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Documentation_for_Special_Cases

[John Cabaj (john-cabaj)]

Hi Paride, thanks for having a look. I don't expect Bionic/Focal/Jammy to need backports for compatibility reasons, mostly because the latest changes were to enable compatibility with the 6.8 kernel. Only Jammy will need some form of compatibility with the 6.8 kernel as that will be the last HWE kernel for Jammy. Focal is still on 5.15 latest, and Bionic on 5.4. There may in the future be backports for particular features, but I wouldn't considered them compatibility related.

I can re-upload debdiffs with the full changelog - that makes sense.

[John Cabaj (john-cabaj)]

Paride,

I've updated the packages at https://launchpad.net/~john-cabaj/+archive/ubuntu/asrdfd to include all versions in the changes file for the new package. Let me know if anything else is amiss.

Thanks,
John

[Simon Quigley (tsimonq2)]

 - Added dh-dkms as a build dependency to satisfy Lintian.
 - Added a copyright entry, src/md5.c is public domain.
 - Sponsored to the Focal and Jammy queues, advised OP contacts the ESM team for a Bionic upload.

[Steve Langasek (vorlon)]

Hello John, or anyone else affected,

Accepted involflt into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/involflt/0.1.0-0ubuntu6~22.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Steve Langasek (vorlon)]

 - Added a copyright entry, src/md5.c is public domain.

It is not. As https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ says:

   Widespread misunderstanding about copyright in general, and the public domain in particular,
   results in the common assertion that a work is in the public domain when this is partly or
   wholly untrue for that work. The Wikipedia article on public domain is a useful reference
   for this subject.

There is no provision under US copyright law for a copyright holder to grant a work to the public domain. Legally a work only enters the public domain only when copyright term lapses, or if it is a government work to which no copyright is attached.

What you can say here is that:

- the copyright holder is waiving all of their rights under copyright
- the work can be treated AS IF it is in the public domain because that is the copyright holder's intent

but the copyright still EXISTS and the debian copyright format still expects you to document this, including the use of the Copyright: field - which, because it is missing here, means the file does not parse correctly according to the standard.

Furthermore, changing debian/copyright in an SRU upload whose changelog says that it is a backport, without also changing it in the devel series, is a bad call.

[Steve Langasek (vorlon)]

Hello John, or anyone else affected,

Accepted involflt into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/involflt/0.1.0-0ubuntu6~20.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.