adcli delete dies with free(): invalid pointer

[Joshua Kugler]

When running this command:
```
cat /tmp/adcli_join_password | sudo adcli delete-computer -U ad_admin_user --stdin-password --domain=EXAMPLE.NET $(hostname -f)
```
adcli dies with this:
```
 free(): invalid pointer
```
and the computer delete fails.

`adcli join` to the domain works great!

$ lsb_release -rd
Description: Ubuntu 18.04.1 LTS
Release: 18.04

Version: 0.8.2-1

I would expect the computer to be deleted from AD, but instead get a free() error.

[Joshua Kugler (jkugler)]

But opened here, with trace back. https://gitlab.freedesktop.org/realmd/adcli/issues/17#note_140307

[Joshua Kugler (jkugler)]

We built a package using this patch: https://gitlab.freedesktop.org/realmd/adcli/commit/90c1e96cf3eea8718aa97a6fb97aa2029ef64670 and it fixed the issue.

[Joshua Kugler (jkugler)]

To clarify "fixed the issue:" It did not fail with the original error, and exited with a `0` exit code. Running the command again return an error saying the computer was not in the domain (as expected).

[Stefan Bogner (bochiii)]

Hi,
any news on this one? Is an update for that package planned using the patch provided?

Thanks

[Robie Basak (racb)]

I see that I triaged this before but without comment. I don't know what I was thinking. I try to always ensure that next steps are clearly communicated when I triage, and I failed at that. Sorry.

It looks like adcli is in the universe archive component, and so we rely on community support for this package. Community members are welcome and encouraged to provide updates themselves to be made available in the archive to all users. But this does require someone to volunteer the packaging update, document it, and perform the required QA.

Please see https://wiki.ubuntu.com/StableReleaseUpdates for details of the process, procedure and rationale. If you need any help in understanding the process requirements, you can ask in #ubuntu-motu on Freenode, or the ubuntu-motu@ mailing list.

I hope this helps!

[Mario Limonciello (superm1)]

I can see this fix is landed in the 0.9.0 release, so this is fixed in Focal and later.

[Joshua Kugler (jkugler)]

Will this be released for LTS (18.04) as well. That was where the bug was found. :)