powerline version from repository is not compatible with fish version

Bug #1726441 reported by Murillo Rodrigues de Paula on 2017-10-23
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
powerline (Ubuntu)
Undecided
Unassigned
Artful
Medium
Brian Murray

Bug Description

I just installed the powerline apt package on Ubuntu 17.10 and followed the documentation to install it for the Fish prompt, then I got the error below after trying to launch Fish. The {repository_root} of this ubuntu package I am using in my config. file is "/usr/share", which is where the powerline bindings for Fish are located at. Powerline version is 2.5-1.1.

/usr/share/powerline/bindings/fish/powerline-setup.fish (line 35): function: Illegal function name '--on-variable'
  function --on-variable fish_key_bindings _powerline_set_default_mode
   if test x$fish_key_bindings != xfish_vi_key_bindings
  ^
in function “powerline-setup”
 called on line 14 of file ~/.config/fish/config.fish

from sourcing file ~/.config/fish/config.fish
 called during startup

/usr/share/powerline/bindings/fish/powerline-setup.fish (line 42): function: Illegal function name '--on-variable'
  function --on-variable POWERLINE_COMMAND _powerline_update
   set -l addargs "--last-exit-code=\$status"
  ^
in function “powerline-setup”
 called on line 14 of file ~/.config/fish/config.fish

from sourcing file ~/.config/fish/config.fish
 called during startup

/usr/share/powerline/bindings/fish/powerline-setup.fish (line 78):
  _powerline_set_default_mode
  ^
in function “powerline-setup”
 called on line 14 of file ~/.config/fish/config.fish

from sourcing file ~/.config/fish/config.fish
 called during startup

/usr/share/powerline/bindings/fish/powerline-setup.fish (line 79):
  _powerline_update
  ^
in function “powerline-setup”
 called on line 14 of file ~/.config/fish/config.fish

from sourcing file ~/.config/fish/config.fish
 called during startup

I already filed a bug (https://github.com/powerline/powerline/issues/1850) in the powerline project page and they told me to report a bug for this ubuntu package. Can you fix this error?

ProblemType: Bug
DistroRelease: Ubuntu 17.10
Package: powerline 2.5-1.1
ProcVersionSignature: Ubuntu 4.13.0-16.19-generic 4.13.4
Uname: Linux 4.13.0-16-generic x86_64
ApportVersion: 2.20.7-0ubuntu3
Architecture: amd64
CurrentDesktop: ubuntu:GNOME
Date: Mon Oct 23 12:53:51 2017
InstallationDate: Installed on 2017-10-22 (1 days ago)
InstallationMedia: Ubuntu 17.10 "Artful Aardvark" - Release amd64 (20171018)
SourcePackage: powerline
UpgradeStatus: No upgrade log present (probably fresh install)

TJ (tj) wrote :

Attached is a patch pulled from git that fixes this.

Changed in powerline (Ubuntu):
status: New → In Progress

The attachment "Swap order of function name/arguments" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Changed in powerline (Ubuntu):
status: In Progress → Fix Released
Changed in powerline (Ubuntu Artful):
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Brian Murray (brian-murray)
Brian Murray (brian-murray) wrote :

I've sponsored this but changed the maintainer to ubuntu-devel-discuss instead of an individual. Thanks for working on it!

Brian Murray (brian-murray) wrote :

Its not immediately clear to me what the test case is though. Could somebody add SRU information to the bug description? See the following for details:

http://wiki.ubuntu.com/StableReleaseUpdates

Robie Basak (racb) wrote :

The upload in the queue refers to bug 1728441 instead of this bug, which is wrong, so rejecting.

The bug still needs SRU information filling out.

I'm not keen on a version string of '2.5-1.1ubuntu0' either. It doesn't follow any commonly used pattern. Zesty also has '2.5-1.1' and isn't technically EOL yet, so this version would make a subsequent SRU to Zesty difficult as well. I suggest '2.5-1.1ubuntu0.17.10.1' instead based on https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers