| 2018-05-15 13:10:33 |
bugproxy |
bug |
|
|
added bug |
| 2018-05-15 13:10:36 |
bugproxy |
tags |
|
architecture-ppc64le bugnameltc-167852 severity-high targetmilestone-inin--- |
|
| 2018-05-15 13:10:37 |
bugproxy |
ubuntu: assignee |
|
Ubuntu on IBM Power Systems Bug Triage (ubuntu-power-triage) |
|
| 2018-05-15 13:10:40 |
bugproxy |
affects |
ubuntu |
linux (Ubuntu) |
|
| 2018-05-15 13:22:57 |
Frank Heimes |
bug task added |
|
ubuntu-power-systems |
|
| 2018-05-15 13:23:10 |
Frank Heimes |
tags |
architecture-ppc64le bugnameltc-167852 severity-high targetmilestone-inin--- |
architecture-ppc64le bugnameltc-167852 severity-high targetmilestone-inin--- triage-g |
|
| 2018-05-15 13:23:15 |
Frank Heimes |
ubuntu-power-systems: status |
New |
Triaged |
|
| 2018-05-15 13:23:18 |
Frank Heimes |
ubuntu-power-systems: importance |
Undecided |
High |
|
| 2018-05-15 13:23:31 |
Frank Heimes |
ubuntu-power-systems: assignee |
|
Canonical Kernel Team (canonical-kernel-team) |
|
| 2018-05-15 13:53:32 |
Manoj Iyer |
linux (Ubuntu): assignee |
Ubuntu on IBM Power Systems Bug Triage (ubuntu-power-triage) |
Canonical Kernel Team (canonical-kernel-team) |
|
| 2018-05-15 13:53:37 |
Manoj Iyer |
linux (Ubuntu): importance |
Undecided |
Critical |
|
| 2018-05-15 13:53:45 |
Manoj Iyer |
linux (Ubuntu): importance |
Critical |
High |
|
| 2018-05-15 13:53:48 |
Manoj Iyer |
linux (Ubuntu): status |
New |
Triaged |
|
| 2018-05-16 18:30:43 |
Joseph Salisbury |
nominated for series |
|
Ubuntu Bionic |
|
| 2018-05-16 18:30:43 |
Joseph Salisbury |
bug task added |
|
linux (Ubuntu Bionic) |
|
| 2018-05-16 18:30:49 |
Joseph Salisbury |
linux (Ubuntu Bionic): importance |
Undecided |
High |
|
| 2018-05-16 18:30:52 |
Joseph Salisbury |
linux (Ubuntu Bionic): assignee |
|
Joseph Salisbury (jsalisbury) |
|
| 2018-05-16 18:30:56 |
Joseph Salisbury |
linux (Ubuntu): assignee |
Canonical Kernel Team (canonical-kernel-team) |
Joseph Salisbury (jsalisbury) |
|
| 2018-05-16 18:30:59 |
Joseph Salisbury |
linux (Ubuntu): status |
Triaged |
In Progress |
|
| 2018-05-16 18:31:03 |
Joseph Salisbury |
linux (Ubuntu Bionic): status |
New |
In Progress |
|
| 2018-05-23 07:23:27 |
Andrew Cloke |
ubuntu-power-systems: status |
Triaged |
In Progress |
|
| 2018-05-23 16:14:12 |
Joseph Salisbury |
description |
== Comment: #0 - Breno Leitao <brenohl@br.ibm.com>
On boot we save the configuration space of PCIe bridges. We do this so
when we get an EEH event and everything gets reset that we can restore
them.
Unfortunately we save this state before we've enabled the MMIO space
on the bridges. Hence if we have to reset the bridge when we come back
MMIO is not enabled and we end up taking an PE freeze when the driver
starts accessing again.
This patch forces the memory/MMIO and bus mastering on when restoring
bridges on EEH. Ideally we'd do this correctly by saving the
configuration space writes later, but that will have to come later in
a larger EEH rewrite. For now we have this simple fix.
The original bug can be triggered on a boston machine by doing:
echo 0x8000000000000000 > /sys/kernel/debug/powerpc/PCI0001/err_injct_outbound
On boston, this PHB has a PCIe switch on it. Without this patch,
you'll see two EEH events, 1 expected and 1 the failure we are fixing
here. The second EEH event causes the anything under the PHB to
disappear (i.e. the i40e eth).
With this patch, only 1 EEH event occurs and devices properly recover.
This is commit id 13a83eac373c49c0a081cbcd137e79210fe78acd and should be part of Ubuntu 18.04 kernel. |
== SRU Justification ==
IBM is requesting this patch in Bionic and Artful to fix a regression. The
regression was introduced in v3.11-rc1. The patch fixes enabling bridge
MMIO windows. Commit 13a83eac373c was also cc'd to upstream stable, and
has already landed in Xenial via upstream stable updates.
== Fix ==
13a83eac373c ("powerpc/eeh: Fix enabling bridge MMIO windows")
== Regression Potential ==
Low. Limited to powerpc and fixes a current regression.
== Test Case ==
A test kernel was built with this patch and tested by the original bug reporter.
The bug reporter states the test kernel resolved the bug.
== Comment: #0 - Breno Leitao <brenohl@br.ibm.com>
On boot we save the configuration space of PCIe bridges. We do this so
when we get an EEH event and everything gets reset that we can restore
them.
Unfortunately we save this state before we've enabled the MMIO space
on the bridges. Hence if we have to reset the bridge when we come back
MMIO is not enabled and we end up taking an PE freeze when the driver
starts accessing again.
This patch forces the memory/MMIO and bus mastering on when restoring
bridges on EEH. Ideally we'd do this correctly by saving the
configuration space writes later, but that will have to come later in
a larger EEH rewrite. For now we have this simple fix.
The original bug can be triggered on a boston machine by doing:
echo 0x8000000000000000 > /sys/kernel/debug/powerpc/PCI0001/err_injct_outbound
On boston, this PHB has a PCIe switch on it. Without this patch,
you'll see two EEH events, 1 expected and 1 the failure we are fixing
here. The second EEH event causes the anything under the PHB to
disappear (i.e. the i40e eth).
With this patch, only 1 EEH event occurs and devices properly recover.
This is commit id 13a83eac373c49c0a081cbcd137e79210fe78acd and should be part of Ubuntu 18.04 kernel. |
|
| 2018-05-23 16:14:19 |
Joseph Salisbury |
nominated for series |
|
Ubuntu Artful |
|
| 2018-05-23 16:14:19 |
Joseph Salisbury |
bug task added |
|
linux (Ubuntu Artful) |
|
| 2018-05-23 16:14:24 |
Joseph Salisbury |
linux (Ubuntu Artful): status |
New |
In Progress |
|
| 2018-05-23 16:14:27 |
Joseph Salisbury |
linux (Ubuntu Artful): importance |
Undecided |
High |
|
| 2018-05-23 16:14:30 |
Joseph Salisbury |
linux (Ubuntu Artful): assignee |
|
Joseph Salisbury (jsalisbury) |
|
| 2018-05-23 16:17:45 |
Joseph Salisbury |
nominated for series |
|
Ubuntu Cosmic |
|
| 2018-05-23 16:17:45 |
Joseph Salisbury |
bug task added |
|
linux (Ubuntu Cosmic) |
|
| 2018-06-07 22:51:31 |
Khaled El Mously |
linux (Ubuntu Artful): status |
In Progress |
Fix Committed |
|
| 2018-06-07 22:51:35 |
Khaled El Mously |
linux (Ubuntu Bionic): status |
In Progress |
Invalid |
|
| 2018-06-11 14:49:36 |
Manoj Iyer |
linux (Ubuntu Bionic): status |
Invalid |
In Progress |
|
| 2018-06-13 07:01:20 |
Brad Figg |
tags |
architecture-ppc64le bugnameltc-167852 severity-high targetmilestone-inin--- triage-g |
architecture-ppc64le bugnameltc-167852 severity-high targetmilestone-inin--- triage-g verification-needed-artful |
|
| 2018-06-18 14:30:33 |
Manoj Iyer |
linux (Ubuntu Bionic): status |
In Progress |
Fix Released |
|
| 2018-06-18 14:30:40 |
Manoj Iyer |
ubuntu-power-systems: status |
In Progress |
Fix Committed |
|
| 2018-06-18 14:42:39 |
Manoj Iyer |
linux (Ubuntu Cosmic): status |
In Progress |
Fix Committed |
|
| 2018-07-02 08:27:17 |
Launchpad Janitor |
linux (Ubuntu Artful): status |
Fix Committed |
Fix Released |
|
| 2018-07-02 08:27:17 |
Launchpad Janitor |
cve linked |
|
2018-1130 |
|
| 2018-07-02 08:27:17 |
Launchpad Janitor |
cve linked |
|
2018-11508 |
|
| 2018-07-02 08:27:17 |
Launchpad Janitor |
cve linked |
|
2018-5750 |
|
| 2018-07-02 08:27:17 |
Launchpad Janitor |
cve linked |
|
2018-5803 |
|
| 2018-07-02 08:27:17 |
Launchpad Janitor |
cve linked |
|
2018-6927 |
|
| 2018-07-02 08:27:17 |
Launchpad Janitor |
cve linked |
|
2018-7755 |
|
| 2018-07-02 08:27:17 |
Launchpad Janitor |
cve linked |
|
2018-7757 |
|
| 2018-07-19 19:13:08 |
Joseph Salisbury |
linux (Ubuntu Cosmic): status |
Fix Committed |
Fix Released |
|
| 2018-07-19 19:39:31 |
Andrew Cloke |
ubuntu-power-systems: status |
Fix Committed |
Fix Released |
|
| 2018-07-31 15:50:15 |
bugproxy |
tags |
architecture-ppc64le bugnameltc-167852 severity-high targetmilestone-inin--- triage-g verification-needed-artful |
architecture-ppc64le bugnameltc-167852 severity-high targetmilestone-inin1804 triage-g verification-needed-artful |
|
| 2019-07-24 21:04:37 |
Brad Figg |
tags |
architecture-ppc64le bugnameltc-167852 severity-high targetmilestone-inin1804 triage-g verification-needed-artful |
architecture-ppc64le bugnameltc-167852 cscc severity-high targetmilestone-inin1804 triage-g verification-needed-artful |
|
