Activity log for bug #1746002

Date Who What changed Old value New value Message
2018-01-29 14:11:30 AaronMa bug added bug
2018-01-29 14:17:39 AaronMa bug added subscriber Canonical Hardware Enablement Team
2018-01-29 14:17:43 AaronMa tags originate-from-1722312 sutton
2018-01-29 14:19:11 AaronMa hwe-next: assignee AaronMa (mapengyu)
2018-01-29 14:30:05 Ubuntu Kernel Bot linux (Ubuntu): status New Incomplete
2018-02-02 11:29:40 Timo Aaltonen bug task added linux-oem (Ubuntu)
2018-02-02 11:29:48 Timo Aaltonen nominated for series Ubuntu Xenial
2018-02-02 11:29:48 Timo Aaltonen bug task added linux (Ubuntu Xenial)
2018-02-02 11:29:48 Timo Aaltonen bug task added linux-oem (Ubuntu Xenial)
2018-02-02 11:29:56 Timo Aaltonen linux (Ubuntu Xenial): status New Invalid
2018-02-02 11:30:00 Timo Aaltonen linux-oem (Ubuntu): status New Invalid
2018-02-12 14:59:28 Timo Aaltonen linux-oem (Ubuntu Xenial): status New Fix Committed
2018-02-15 15:12:25 Timo Aaltonen tags originate-from-1722312 sutton originate-from-1722312 sutton verification-needed-xenial
2018-02-16 15:38:20 Stefan Bader nominated for series Ubuntu Artful
2018-02-16 15:38:20 Stefan Bader bug task added linux (Ubuntu Artful)
2018-02-16 15:38:20 Stefan Bader bug task added linux-oem (Ubuntu Artful)
2018-02-16 15:38:27 Stefan Bader linux-oem (Ubuntu Artful): status New Invalid
2018-02-17 04:46:53 Khaled El Mously linux (Ubuntu Artful): status New Fix Committed
2018-02-21 19:08:44 Launchpad Janitor linux-oem (Ubuntu Xenial): status Fix Committed Fix Released
2018-02-21 19:08:44 Launchpad Janitor cve linked 2017-15115
2018-02-21 19:08:44 Launchpad Janitor cve linked 2017-17712
2018-02-21 19:08:44 Launchpad Janitor cve linked 2017-5715
2018-02-21 19:08:44 Launchpad Janitor cve linked 2017-5753
2018-02-21 19:08:44 Launchpad Janitor cve linked 2017-5754
2018-02-21 19:08:44 Launchpad Janitor cve linked 2017-8824
2018-02-21 19:08:49 Launchpad Janitor linux-oem (Ubuntu Xenial): status Fix Committed Fix Released
2018-02-22 02:46:18 AaronMa tags originate-from-1722312 sutton verification-needed-xenial originate-from-1722312 sutton verification-done-xenial
2018-02-22 02:56:10 AaronMa summary TrackPoint: middle button doesn't work on TrackPoint-compatible device. [SRU] TrackPoint: middle button doesn't work on TrackPoint-compatible device.
2018-02-22 02:56:10 AaronMa description Lenovo introduced 4 new TrackPoint compatible sticks those only support the minimum commands described in the spec, which has been used in the current Windows driver. Legacy TrackPoint: 0101 – 0E01 ALPS: 0102 – FF02 ELAN:0103 – FF03 NXP: 0104 – FF04 TrackPoint (ID: 01/02) report 0 button when reading the EXT_BUTTON command. Setting middle button enabled to make it work. Upstream patch: commit f5d07b9e98022d50720e38aa936fc11c67868ece Author: Aaron Ma <aaron.ma@canonical.com> Date: Fri Jan 19 09:43:39 2018 -0800 Input: trackpoint - force 3 buttons if 0 button is reported Lenovo introduced trackpoint compatible sticks with minimum PS/2 commands. They supposed to reply with 0x02, 0x03, or 0x04 in response to the "Read Extended ID" command, so we would know not to try certain extended commands. Unfortunately even some trackpoints reporting the original IBM version (0x01 firmware 0x0e) now respond with incorrect data to the "Get Extended Buttons" command: thinkpad_acpi: ThinkPad BIOS R0DET87W (1.87 ), EC unknown thinkpad_acpi: Lenovo ThinkPad E470, model 20H1004SGE psmouse serio2: trackpoint: IBM TrackPoint firmware: 0x0e, buttons: 0/0 Since there are no trackpoints without buttons, let's assume the trackpoint has 3 buttons when we get 0 response to the extended buttons query. Signed-off-by: Aaron Ma <aaron.ma@canonical.com> Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=196253 Cc: stable@vger.kernel.org Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Lenovo introduced 4 new TrackPoint compatible sticks those only support the minimum commands described in the spec, which has been used in the current Windows driver. Legacy TrackPoint: 0101 – 0E01 ALPS: 0102 – FF02 ELAN:0103 – FF03 NXP: 0104 – FF04 TrackPoint (ID: 01/02) report 0 button when reading the EXT_BUTTON command. Setting middle button enabled to make it work. Upstream patch: commit f5d07b9e98022d50720e38aa936fc11c67868ece Author: Aaron Ma <aaron.ma@canonical.com> Date: Fri Jan 19 09:43:39 2018 -0800 Input: trackpoint - force 3 buttons if 0 button is reported Lenovo introduced trackpoint compatible sticks with minimum PS/2 commands. They supposed to reply with 0x02, 0x03, or 0x04 in response to the "Read Extended ID" command, so we would know not to try certain extended commands. Unfortunately even some trackpoints reporting the original IBM version (0x01 firmware 0x0e) now respond with incorrect data to the "Get Extended Buttons" command: thinkpad_acpi: ThinkPad BIOS R0DET87W (1.87 ), EC unknown thinkpad_acpi: Lenovo ThinkPad E470, model 20H1004SGE psmouse serio2: trackpoint: IBM TrackPoint firmware: 0x0e, buttons: 0/0 Since there are no trackpoints without buttons, let's assume the trackpoint has 3 buttons when we get 0 response to the extended buttons query. Signed-off-by: Aaron Ma <aaron.ma@canonical.com> Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=196253 Cc: stable@vger.kernel.org Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> SRU justification: ============== [Impact] Middle button on some TrackPoints with ThinkPad can't work on Ubuntu 16.04. Lenovo introduced 4 new TrackPoint compatible sticks those only support minimum commands, Sticks with ID 01/02 reported the external button 0, TrackPoint always have 3 buttons. [Fix] Set 3 buttons when 0 button is reported via PS/2 commands. [Test Case] Tested on Finn and E470, middle button works with this patch. [Regression Potential] No regression is expected. This patch had been send to stable kernel, so Bionic should have it with stable updates. Aaron Ma (1): Input: trackpoint - force 3 buttons if 0 button is reported drivers/input/mouse/trackpoint.c | 3 +++ 1 file changed, 3 insertions(+)
2018-03-19 10:58:42 Stefan Bader tags originate-from-1722312 sutton verification-done-xenial originate-from-1722312 sutton verification-done-xenial verification-needed-artful
2018-03-20 03:12:37 AaronMa tags originate-from-1722312 sutton verification-done-xenial verification-needed-artful originate-from-1722312 sutton verification-done-artful verification-done-xenial
2018-03-20 03:13:06 AaronMa hwe-next: status New Fix Released
2018-03-20 03:13:16 AaronMa linux (Ubuntu): status Incomplete Fix Released
2018-04-03 14:10:10 Launchpad Janitor linux (Ubuntu Artful): status Fix Committed Fix Released
2018-04-03 14:10:10 Launchpad Janitor cve linked 2017-0861
2018-04-03 14:10:10 Launchpad Janitor cve linked 2017-1000407
2018-04-03 14:10:10 Launchpad Janitor cve linked 2017-15129
2018-04-03 14:10:10 Launchpad Janitor cve linked 2017-16994
2018-04-03 14:10:10 Launchpad Janitor cve linked 2017-17448
2018-04-03 14:10:10 Launchpad Janitor cve linked 2017-17450
2018-04-03 14:10:10 Launchpad Janitor cve linked 2017-17741
2018-04-03 14:10:10 Launchpad Janitor cve linked 2017-17805
2018-04-03 14:10:10 Launchpad Janitor cve linked 2017-17806
2018-04-03 14:10:10 Launchpad Janitor cve linked 2017-17807
2018-04-03 14:10:10 Launchpad Janitor cve linked 2018-1000026
2018-04-03 14:10:10 Launchpad Janitor cve linked 2018-5332
2018-04-03 14:10:10 Launchpad Janitor cve linked 2018-5333
2018-04-03 14:10:10 Launchpad Janitor cve linked 2018-5344