[needs-packaging] Please package Peruse

[Clive Johnston]

Peruse is a comic book reader by KDE, with stable version 1.2 [1] being released on 27th Dec 2016.

With all of the peruse build and runtime dependencies now being provided in Zesty, it would be nice to introduce this into the Kubuntu 17.04 release.

The Kubuntu team have been testing this software and it works very well and we would like to see it sponsored.

[1] http://download.kde.org/stable/peruse/

[Clive Johnston (clivejo)]

Please review the following packaging:

https://launchpad.net/~clivejo/+archive/ubuntu/peruse/+files/peruse_1.2-0ubuntu1.dsc

[Rik Mills (rikmills)]

As we now have a new enough knewstuff package in the archive and proposed, seems we can now revert our packaging commit:

https://git.launchpad.net/~kubuntu-packagers/kubuntu-packaging/+git/peruse/commit/?h=kubuntu_zesty_archive&id=59ac21665a2f1806e8d8943d366a9ff2d4c03bfd

Resulting build is here:

https://launchpad.net/~kubuntu-ppa/+archive/ubuntu/staging-misc/+sourcepub/7476949/+listing-archive-extra

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Jeremy Bícha (jbicha)]

I looked at https://git.launchpad.net/~kubuntu-packagers/kubuntu-packaging/+git/peruse/

1. Please close this bug in the changelog.

Since this is the first time it's packaged in Ubuntu, you could reduce the changelog down to

* Initial release (LP: #1663675)

2. Please update the maintainer in debian/control to a ubuntu.com email.

3. If you use dh compat 10, you could drop "--parallel" from debian/rules since it's automatic there. debhelper 10 is available in Ubuntu 16.10 and in backports for 16.04.

4. Why the dbgsym migration rule? Was peruse-dbg previously published in your PPAs or in Neon?

5. src/qtquick/karchive-rar/external/unarr is LGPL-3

That might make the license of the whole project GPL-3, I recommend contacting the peruse maintainer about that concern.

6. lines 6-7 of your debian/copyright are unnecessary because of the line 5 wildcard

7. Not important, but debian/upstream/meatadata could be updated to
https://cgit.kde.org/peruse.git
https://cgit.kde.org/peruse.git/log

[Jeremy Bícha (jbicha)]

Did you abandon this just because it's after Feature Freeze? That's not necessarily a blocker. Just ad [FFe] to the bug title and subscribe ~ubuntu-release. Then it's up to the Ubuntu Archive Admins whether they have time to review and choose to accept it before the release or not.

[Clive Johnston (clivejo)]

No, I abandon it as I don't have the time to follow it through and get it into the archive.

[Michael Terry (mterry)]

Unsubscribing sponsors then, since the packaging needs some fixing. Feel free to re-subscribe them when this is ready. Thanks!

[Launchpad Janitor (janitor)]

[Expired for Ubuntu because there has been no activity for 60 days.]

[Gustavo Silva (gsilvapt)]

Changes were made as suggested in #4. Can someone review the changes?

https://code.launchpad.net/~kubuntu-packagers/kubuntu-packaging/+git/peruse/+ref/kubuntu_unstable

[Jeremy Bícha (jbicha)]

Gustavo, could you resubscribe ubuntu-sponsors?

[Gustavo Silva (gsilvapt)]

That's done, Jeremy. Thank you!

[Clive Johnston (clivejo)]

Uploaded the package with changes Gustavo made to my PPA for review

https://launchpad.net/~clivejo/+archive/ubuntu/artful/+packages?field.name_filter=peruse&field.status_filter=published&field.series_filter=artful

[Jeremy Bícha (jbicha)]

Thank you for your continued work on this package.

#3 If you want to use automatic parallel, you need to bump the compat level to 10 in debian/compat and update the debhelper dependency to >= 10

debian/copyright is incomplete.

Many but not all of the QML files like src/app/qml/Main.qml have a special clause (LGPL-2.1 or LGPL-3 or any later version of the LGPL approved by the membership of KDE e.V.). That text should be copied to debian/copyright.

I think the rest have a standard LGPL-2.1+ but I didn't look thoroughly.

Do these 2 files intentionally have a higher license (GPL-2+ instead of LGPL-2+)?
Files: src/qtquick/PropertyContainer.cpp
 src/qtquick/PropertyContainer.h
Copyright: 2012, Dan Leinir Turthra Jensen <email address hidden>

Like I said in #5, the overall license may end up being GPL-3 (or LGPL-3 if those 2 files are able to be relicensed to LGPL-2.1+). I would appreciate it if you would let upstream know about that.

[Clive Johnston (clivejo)]

I have spoken to Dan directly and opened a bug at his request.

https://bugs.kde.org/show_bug.cgi?id=381491

[Clive Johnston (clivejo)]

Apparently fixed by https://cgit.kde.org/peruse.git/commit/?id=76f472108c5464efc3ba20f8f4e896a53eb6518c

[Gustavo Silva (gsilvapt)]

What is the next step?

[Jeremy Bícha (jbicha)]

Gustavo, see my last comment.

You probably want to bump debhelper compat to 10.

debian/copyright needs to be rewritten.

I wonder if upstream is aware that src/qtquick/karchive-rar/external/unarr is LGPL-3.

Leave a comment here when those tasks are done.

[Simon Quigley (tsimonq2)]

Hey Jeremy!

Bumping debhelper compat above 9 isn't really an option because the Kubuntu CI doesn't use Xenial archive backports and Xenial still ships with debhelper compat 9. The same goes with Standards-version. This is an intentional `Won't Fix` that is standard across all of the Kubuntu packages.

[Simon Quigley (tsimonq2)]

Unsubscribing ~ubuntu-sponsors as there's nothing left to sponsor.