| 2020-06-01 07:48:15 |
Didier Roche-Tolomelli |
bug |
|
|
added bug |
| 2020-06-03 00:38:52 |
Launchpad Janitor |
zsys (Ubuntu): status |
New |
Fix Released |
|
| 2020-06-09 09:25:55 |
Didier Roche-Tolomelli |
zsys (Ubuntu): importance |
Undecided |
Low |
|
| 2020-06-09 09:25:57 |
Didier Roche-Tolomelli |
zsys (Ubuntu): assignee |
|
Didier Roche (didrocks) |
|
| 2020-06-09 09:26:03 |
Didier Roche-Tolomelli |
nominated for series |
|
Ubuntu Focal |
|
| 2020-06-09 09:26:03 |
Didier Roche-Tolomelli |
bug task added |
|
zsys (Ubuntu Focal) |
|
| 2020-06-09 09:26:34 |
Didier Roche-Tolomelli |
zsys (Ubuntu Focal): importance |
Undecided |
Low |
|
| 2020-06-09 09:26:36 |
Didier Roche-Tolomelli |
zsys (Ubuntu Focal): assignee |
|
Didier Roche (didrocks) |
|
| 2020-06-09 09:31:52 |
Didier Roche-Tolomelli |
description |
From the log:
mai 12 09:41:27 casanier zsysd[48398]: gdm
mai 12 09:41:27 casanier zsysctl[48826]: level=error msg="couldn't save state for user \"gdm\":user \"gdm\" doesn't exist"
mai 12 09:41:27 casanier systemd[2480]: zsys-user-savestate.service: Main process exited, code=exited, status=1/FAILURE
mai 12 09:41:27 casanier systemd[2480]: zsys-user-savestate.service: Failed with result 'exit-code'.
mai 12 09:41:27 casanier systemd[2480]: Failed to start Save current user state periodically.
mai 12 09:42:27 casanier systemd[1]: zsysd.service: Succeeded.
We should avoid by default logging user ID < 1000 but root rather than outputting an error. |
[Impact]
* ZSys user autosave feature was trying to save GDM users on systems that don’t have their GDM session teared down after logged in (nvidia binary driver).
* The saving was failing as no GDM dataset was created.This was only visible in logs:
mai 12 09:41:27 casanier zsysd[48398]: gdm
mai 12 09:41:27 casanier zsysctl[48826]: level=error msg="couldn't save state for user \"gdm\":user \"gdm\" doesn't exist"
mai 12 09:41:27 casanier systemd[2480]: zsys-user-savestate.service: Main process exited, code=exited, status=1/FAILURE
mai 12 09:41:27 casanier systemd[2480]: zsys-user-savestate.service: Failed with result 'exit-code'.
mai 12 09:41:27 casanier systemd[2480]: Failed to start Save current user state periodically.
[Test Case]
1. Install the new ZSys on a machine which gdm session doesn’t tear down
2. Wait for 5 minutes after boot so that the autosave user timer is triggered.
3. Check the logs: the timer isn’t ran for gdm user.
[Regression Potential]
* The fix is about adding ConditionUser=!@system to the systemd user autosave features, so that any user with UID < 1000 (which are the users we don’t create user datasets for) are not considered.
* The failure was silent for most of users who don’t look at the logs.
-----
From the log:
mai 12 09:41:27 casanier zsysd[48398]: gdm
mai 12 09:41:27 casanier zsysctl[48826]: level=error msg="couldn't save state for user \"gdm\":user \"gdm\" doesn't exist"
mai 12 09:41:27 casanier systemd[2480]: zsys-user-savestate.service: Main process exited, code=exited, status=1/FAILURE
mai 12 09:41:27 casanier systemd[2480]: zsys-user-savestate.service: Failed with result 'exit-code'.
mai 12 09:41:27 casanier systemd[2480]: Failed to start Save current user state periodically.
mai 12 09:42:27 casanier systemd[1]: zsysd.service: Succeeded.
We should avoid by default logging user ID < 1000 but root rather than outputting an error. |
|
| 2020-06-19 06:37:48 |
Timo Aaltonen |
zsys (Ubuntu Focal): status |
New |
Fix Committed |
|
| 2020-06-19 06:37:50 |
Timo Aaltonen |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2020-06-19 06:37:53 |
Timo Aaltonen |
bug |
|
|
added subscriber SRU Verification |
| 2020-06-19 06:37:57 |
Timo Aaltonen |
tags |
|
verification-needed verification-needed-focal |
|
| 2020-06-24 12:21:38 |
Jean-Baptiste Lallement |
tags |
verification-needed verification-needed-focal |
verification-done verification-done-focal |
|
| 2020-07-02 08:29:32 |
Launchpad Janitor |
zsys (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|
| 2020-07-02 08:30:25 |
Łukasz Zemczak |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
