zsh completion broken for svn 1.5

Bug #279545 reported by Dag-Erling Smørgrav
8
Affects Status Importance Assigned to Milestone
zsh (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: zsh

Fully up-to-date Hardy Heron as of 1008-10-07 with zsh-4.3.4-24ubuntu1 and subversion-1.5.1dfsg1-1ubuntu2~hardy2 from hardy-backports.

Subversion command completion fails:

% svn add<TAB>
_arguments:comparguments:303: invalid argument: ARG

This goes for any subversion command, not just svn add.

The reason is the following line that appears in 'svn help $command' for any $command:

  --config-dir ARG : read user configuration files from directory ARG

In 1.4 and earlier, it looked like this:

  --config-dir arg : read user configuration files from directory ARG

The completion spec barfs on s/arg/ARG/.

The minimal fix is to replace every occurrence of "/ arg/:arg:" with "/ (arg|ARG)/:arg:" in /usr/share/zsh/4.3.4/functions/Completion/Unix/_subversion; see attached patch.

Revision history for this message
Dag-Erling Smørgrav (dag-erling) wrote :
Revision history for this message
Dag-Erling Smørgrav (dag-erling) wrote :

"as of 1008-10-07" should of course be "as of 2008-10-07"

Revision history for this message
Gaz (errant7015) wrote :

I see the same problem and confirm that the patch works.

Changed in zsh:
status: New → Confirmed
Revision history for this message
Francisco Borges (francisco-borges) wrote :

FYI: same problem here, and the patch works.

Revision history for this message
Kohsuke Kawaguchi (kk-kohsuke) wrote :

Ditto. The patch worked for me.

Revision history for this message
Axel Beckert (xtaran) wrote :

This issue is fixed a long time ago already. zsh 5.0.0-1 supports Subversion syntax up to version 1.7.

Changed in zsh (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.