| 2022-07-22 12:51:05 |
Ilya Leoshkevich |
bug |
|
|
added bug |
| 2022-07-22 12:51:05 |
Ilya Leoshkevich |
attachment added |
|
lp1932010-ibm-z-add-vectorized-crc32-implementation.patch https://bugs.launchpad.net/bugs/1982583/+attachment/5604757/+files/lp1932010-ibm-z-add-vectorized-crc32-implementation.patch |
|
| 2022-07-22 15:39:35 |
bugproxy |
tags |
|
architecture-s39064 bugnameltc-199129 severity-high targetmilestone-inin--- |
|
| 2022-10-07 08:39:41 |
Frank Heimes |
description |
I've discovered two issues in lp1932010-ibm-z-add-vectorized-crc32-implementation.patch:
1) s390_crc32_vx() signature mismatch, resulting in a warning.
2) -DS390_CRC32_VX is not added to SFLAGS, resulting in vectorization being enabled only in the static library.
I've attached the updated patch. |
'zlib CRC32 optimization for s390x works only in a static library'
I've discovered two issues in lp1932010-ibm-z-add-vectorized-crc32-implementation.patch:
1) s390_crc32_vx() signature mismatch, resulting in a warning.
2) -DS390_CRC32_VX is not added to SFLAGS, resulting in vectorization being enabled only in the static library.
I've attached the updated patch. |
|
| 2022-10-07 08:40:04 |
Frank Heimes |
summary |
zlib CRC32 optimization for s390x works only in a static library |
Fix for zlib CRC32 optimization for s390x |
|
| 2022-10-07 13:09:39 |
Frank Heimes |
attachment added |
|
lp1990379+lp1982583_debdiffs.tgz https://bugs.launchpad.net/ubuntu/+source/zlib/+bug/1982583/+attachment/5622051/+files/lp1990379+lp1982583_debdiffs.tgz |
|
| 2022-10-07 13:09:58 |
Frank Heimes |
bug task added |
|
ubuntu-z-systems |
|
| 2022-10-07 13:10:26 |
Frank Heimes |
ubuntu-z-systems: assignee |
|
Skipper Bug Screeners (skipper-screen-team) |
|
| 2022-10-07 13:10:29 |
Frank Heimes |
zlib (Ubuntu): importance |
Undecided |
High |
|
| 2022-10-07 13:10:30 |
Frank Heimes |
ubuntu-z-systems: importance |
Undecided |
High |
|
| 2022-10-07 13:10:34 |
Frank Heimes |
zlib (Ubuntu): status |
New |
In Progress |
|
| 2022-10-07 13:10:40 |
Frank Heimes |
ubuntu-z-systems: status |
New |
In Progress |
|
| 2022-10-07 14:12:55 |
Frank Heimes |
description |
'zlib CRC32 optimization for s390x works only in a static library'
I've discovered two issues in lp1932010-ibm-z-add-vectorized-crc32-implementation.patch:
1) s390_crc32_vx() signature mismatch, resulting in a warning.
2) -DS390_CRC32_VX is not added to SFLAGS, resulting in vectorization being enabled only in the static library.
I've attached the updated patch. |
SRU Justification:
------------------
[ Impact ]
* There were two issues identified in the current
zlib CRC32 optimization for s390x implementation:
* 1) s390_crc32_vx() signature mismatch
which causes a warning
* 2) '-DS390_CRC32_VX' was not added to SFLAGS
which results in vectorization being enabled only in the static library.
* The fixes are quite small and affect each only one line:
* 1) by using unsigned longs instead of uint32_t in s390_crc32_vx declaration
* 2) by add line 'SFLAGS="$SFLAGS -DS390_CRC32_VX"'
[ Test Plan ]
* An affected Ubuntu release ([20.04], 22.04 and 22.10) installed
on a z15/LinuxONE III or newer system is needed.
* Then it's possible to test the updated package with the help
of a small test program (in C) that checks for
s390_crc32_vx() signature mismatches.
* The bug reporter has a set of s390x-specific tests that will be executed.
* Test will be done by IBM.
[ Where problems could occur ]
* The fixes are each limited to one line, hence there are
not many issues to expect, other than:
* Typos (e.g. in the flags), mixing of CFLAGS and SFLAGS,
* in case the changed data type in s390_crc32_vx is causing issues
inside of s390_crc32_vx or in other parts of the code.
* Structural and syntactical issues can be identified with a test build
that was done for all affected Ubuntu releases and for all major archs:
https://launchpad.net/~fheimes/+archive/ubuntu/lp1990379+lp1982583
[ Other Info ]
* This bug (LP#1982583) is solved in combination with LP#1982583,
so that only one package update is needed.
However, LP#1982583 also affects Focal, but this bug only Jammy and Kinetic.
* To fix LP#1982583 also for focal the debdiff mentioned there is needed, too.
__________
'zlib CRC32 optimization for s390x works only in a static library'
I've discovered two issues in lp1932010-ibm-z-add-vectorized-crc32-implementation.patch:
1) s390_crc32_vx() signature mismatch, resulting in a warning.
2) -DS390_CRC32_VX is not added to SFLAGS, resulting in vectorization being enabled only in the static library.
I've attached the updated patch. |
|
| 2022-10-07 14:14:13 |
Frank Heimes |
description |
SRU Justification:
------------------
[ Impact ]
* There were two issues identified in the current
zlib CRC32 optimization for s390x implementation:
* 1) s390_crc32_vx() signature mismatch
which causes a warning
* 2) '-DS390_CRC32_VX' was not added to SFLAGS
which results in vectorization being enabled only in the static library.
* The fixes are quite small and affect each only one line:
* 1) by using unsigned longs instead of uint32_t in s390_crc32_vx declaration
* 2) by add line 'SFLAGS="$SFLAGS -DS390_CRC32_VX"'
[ Test Plan ]
* An affected Ubuntu release ([20.04], 22.04 and 22.10) installed
on a z15/LinuxONE III or newer system is needed.
* Then it's possible to test the updated package with the help
of a small test program (in C) that checks for
s390_crc32_vx() signature mismatches.
* The bug reporter has a set of s390x-specific tests that will be executed.
* Test will be done by IBM.
[ Where problems could occur ]
* The fixes are each limited to one line, hence there are
not many issues to expect, other than:
* Typos (e.g. in the flags), mixing of CFLAGS and SFLAGS,
* in case the changed data type in s390_crc32_vx is causing issues
inside of s390_crc32_vx or in other parts of the code.
* Structural and syntactical issues can be identified with a test build
that was done for all affected Ubuntu releases and for all major archs:
https://launchpad.net/~fheimes/+archive/ubuntu/lp1990379+lp1982583
[ Other Info ]
* This bug (LP#1982583) is solved in combination with LP#1982583,
so that only one package update is needed.
However, LP#1982583 also affects Focal, but this bug only Jammy and Kinetic.
* To fix LP#1982583 also for focal the debdiff mentioned there is needed, too.
__________
'zlib CRC32 optimization for s390x works only in a static library'
I've discovered two issues in lp1932010-ibm-z-add-vectorized-crc32-implementation.patch:
1) s390_crc32_vx() signature mismatch, resulting in a warning.
2) -DS390_CRC32_VX is not added to SFLAGS, resulting in vectorization being enabled only in the static library.
I've attached the updated patch. |
SRU Justification:
------------------
[ Impact ]
* There were two issues identified in the current
zlib CRC32 optimization for s390x implementation:
* 1) s390_crc32_vx() signature mismatch
which causes a warning
* 2) '-DS390_CRC32_VX' was not added to SFLAGS
which results in vectorization being enabled only in the static library.
* The fixes are quite small and affect each only one line:
* 1) by using unsigned longs instead of uint32_t in s390_crc32_vx declaration
* 2) by add line 'SFLAGS="$SFLAGS -DS390_CRC32_VX"'
[ Test Plan ]
* An affected Ubuntu release ([20.04], 22.04 and 22.10) installed
on a z15/LinuxONE III or newer system is needed.
* Then it's possible to test the updated package with the help
of a small test program (in C) that checks for
s390_crc32_vx() signature mismatches.
* The bug reporter has a set of s390x-specific tests that will be executed.
* Test will be done by IBM.
[ Where problems could occur ]
* The fixes are each limited to one line, hence there are
not many issues to expect, other than:
* Typos (e.g. in the flags), mixing of CFLAGS and SFLAGS,
* in case the changed data type in s390_crc32_vx is causing issues
inside of s390_crc32_vx or in other parts of the code.
* Structural and syntactical issues can be identified with a test build
that was done for all affected Ubuntu releases and for all major archs:
https://launchpad.net/~fheimes/+archive/ubuntu/lp1990379+lp1982583
[ Other Info ]
* This bug (LP#1982583) is solved in combination with LP#1990379,
so that only one package update is needed.
However, LP#1990379 also affects Focal, but this bug only Jammy and Kinetic.
* To fix LP#1990379 also for focal the debdiff mentioned there is needed, too.
__________
'zlib CRC32 optimization for s390x works only in a static library'
I've discovered two issues in lp1932010-ibm-z-add-vectorized-crc32-implementation.patch:
1) s390_crc32_vx() signature mismatch, resulting in a warning.
2) -DS390_CRC32_VX is not added to SFLAGS, resulting in vectorization being enabled only in the static library.
I've attached the updated patch. |
|
| 2022-10-10 10:45:17 |
Julian Andres Klode |
tags |
architecture-s39064 bugnameltc-199129 severity-high targetmilestone-inin--- |
architecture-s39064 bugnameltc-199129 foundation-triage-discuss severity-high targetmilestone-inin--- |
|
| 2022-11-02 10:34:30 |
Simon Chopin |
nominated for series |
|
Ubuntu Jammy |
|
| 2022-11-02 10:34:30 |
Simon Chopin |
bug task added |
|
zlib (Ubuntu Jammy) |
|
| 2022-11-02 10:34:30 |
Simon Chopin |
nominated for series |
|
Ubuntu Kinetic |
|
| 2022-11-02 10:34:30 |
Simon Chopin |
bug task added |
|
zlib (Ubuntu Kinetic) |
|
| 2022-11-18 20:11:18 |
Steve Langasek |
zlib (Ubuntu Kinetic): status |
New |
Incomplete |
|
| 2022-11-18 20:11:27 |
Steve Langasek |
zlib (Ubuntu Jammy): status |
New |
Incomplete |
|
| 2023-08-10 17:59:48 |
Utkarsh Gupta |
zlib (Ubuntu Kinetic): status |
Incomplete |
Won't Fix |
|
