| 2022-02-18 16:09:48 |
bugproxy |
bug |
|
|
added bug |
| 2022-02-18 16:09:50 |
bugproxy |
tags |
|
architecture-s39064 bugnameltc-194923 severity-high targetmilestone-inin2110 |
|
| 2022-02-18 16:09:52 |
bugproxy |
ubuntu: assignee |
|
Skipper Bug Screeners (skipper-screen-team) |
|
| 2022-02-18 16:09:57 |
bugproxy |
affects |
ubuntu |
linux (Ubuntu) |
|
| 2022-02-18 16:14:32 |
Frank Heimes |
affects |
linux (Ubuntu) |
zlib (Ubuntu) |
|
| 2022-02-18 16:14:57 |
Frank Heimes |
bug task added |
|
ubuntu-z-systems |
|
| 2022-02-18 16:15:17 |
Frank Heimes |
ubuntu-z-systems: assignee |
|
Skipper Bug Screeners (skipper-screen-team) |
|
| 2022-02-24 15:43:58 |
Matthieu Clemenceau |
tags |
architecture-s39064 bugnameltc-194923 severity-high targetmilestone-inin2110 |
architecture-s39064 bugnameltc-194923 fr-2079 severity-high targetmilestone-inin2110 |
|
| 2022-03-09 19:59:13 |
Frank Heimes |
attachment added |
|
zlib_1.2.11.dfsg-2ubuntu7_to_zlib_1.2.11.dfsg-2ubuntu8 (jammy) https://bugs.launchpad.net/ubuntu/+source/zlib/+bug/1961427/+attachment/5567534/+files/debdiff_zlib_1.2.11.dfsg-2ubuntu7_to_zlib_1.2.11.dfsg-2ubuntu8_jammy.diff |
|
| 2022-03-09 19:59:24 |
Frank Heimes |
nominated for series |
|
Ubuntu Jammy |
|
| 2022-03-09 19:59:24 |
Frank Heimes |
bug task added |
|
zlib (Ubuntu Jammy) |
|
| 2022-03-09 19:59:24 |
Frank Heimes |
nominated for series |
|
Ubuntu Impish |
|
| 2022-03-09 19:59:24 |
Frank Heimes |
bug task added |
|
zlib (Ubuntu Impish) |
|
| 2022-03-09 20:00:15 |
Frank Heimes |
summary |
[Ubuntu 21.10] zlib: compressBound() returns an incorrect result on z15 |
zlib: compressBound() returns an incorrect result on z15 |
|
| 2022-03-09 20:20:44 |
Ubuntu Foundations Team Bug Bot |
tags |
architecture-s39064 bugnameltc-194923 fr-2079 severity-high targetmilestone-inin2110 |
architecture-s39064 bugnameltc-194923 fr-2079 patch severity-high targetmilestone-inin2110 |
|
| 2022-03-09 20:20:51 |
Ubuntu Foundations Team Bug Bot |
bug |
|
|
added subscriber Ubuntu Sponsors Team |
| 2022-03-11 07:06:34 |
Mathew Hodson |
zlib (Ubuntu Impish): importance |
Undecided |
High |
|
| 2022-03-11 07:06:36 |
Mathew Hodson |
zlib (Ubuntu Jammy): importance |
Undecided |
High |
|
| 2022-03-14 19:52:27 |
Brian Murray |
removed subscriber Ubuntu Sponsors Team |
|
|
|
| 2022-03-14 19:54:51 |
Brian Murray |
bug |
|
|
added subscriber Brian Murray |
| 2022-03-14 19:54:58 |
Brian Murray |
zlib (Ubuntu Jammy): status |
New |
In Progress |
|
| 2022-03-14 19:55:01 |
Brian Murray |
zlib (Ubuntu Jammy): assignee |
Skipper Bug Screeners (skipper-screen-team) |
Brian Murray (brian-murray) |
|
| 2022-03-14 20:48:50 |
Frank Heimes |
description |
Description: zlib: compressBound() returns an incorrect result on z15
Symptom: Passing the result of compressBound() to compress()
results in an error code.
Problem: compressBound() is not adjusted for DFLTCC.
Solution: Adjust compressBound() for DFLTCC like it's already done
for deflateBound(). Since zlib project does not accept
patches at the moment, the fix has been integrated into
the DFLTCC pull request:
https://github.com/madler/zlib/pull/410
The commitid is b25781e735363e04f6c56e21431c47e4afc50b17.
Reproduction: z15 only:
#include <assert.h>
#include <stdlib.h>
#include <zlib.h>
int main() {
Bytef in_buf[128], out_buf[1024];
for (size_t i = 0; i < sizeof(in_buf); i++)
in_buf[i] = rand();
uLongf dest_len = compressBound(sizeof(in_buf));
assert(dest_len <= sizeof(out_buf));
int ret = compress(out_buf, &dest_len,
in_buf, sizeof(in_buf));
assert(ret == Z_OK);
} |
SRU Justification:
==================
[Impact]
* zlib: compressBound() returns an incorrect result on IBM z15 hardware.
* Passing the result of compressBound() to compress() results
in an error code.
* This is because compressBound() is not adjusted for DFLTCC.
[Fix]
* Adjust compressBound() for DFLTCC like it's already done
for deflateBound().
* Since zlib project does not accept patches at the moment,
the fix has been integrated into the DFLTCC pull request:
https://github.com/madler/zlib/pull/410
The commitid is b25781e735363e04f6c56e21431c47e4afc50b17.
* The fix extracted out of the above is:
https://launchpadlibrarian.net/589857296/debdiff_zlib_1.2.11.dfsg-2ubuntu7_to_zlib_1.2.11.dfsg-2ubuntu8_jammy.diff
[Test Plan]
* An IBM z15 system (LPAR, z/VM guest or KVM virtual machine)
with Ubuntu Server 21.10 (or 22.04).
* A test can be done based on the following C test program:
#include <assert.h>
#include <stdlib.h>
#include <zlib.h>
int main() {
Bytef in_buf[128], out_buf[1024];
for (size_t i = 0; i < sizeof(in_buf); i++)
in_buf[i] = rand();
uLongf dest_len = compressBound(sizeof(in_buf));
assert(dest_len <= sizeof(out_buf));
int ret = compress(out_buf, &dest_len,
in_buf, sizeof(in_buf));
assert(ret == Z_OK);
}
* The test needs to be done by IBM, due to the requirements
for the special z15 hardware.
[Where problems could occur]
* If the adjustment of compressBound() for DFLTCC is done
erroneously the issue can still be present or in worst case
even affect Z systems other than z15 only.
* The crc table can be broken, in case the endian detection
or the register initialization is done wrong.
* The compression can become errorneous with the new changes,
e.g. in compressBound.
* Mistakes in dfltcc_free_window OF and especially DEFLATE_BOUND_COMPLEN,
(incl. the bit definitions), may cause various and unforseen defects.
* Any build time issues that might have been introduced by this patch
can be identified by a test build; this was done and is available here:
https://launchpad.net/~fheimes/+archive/ubuntu/lp1961427
[Other Info]
* Only impish and jammy are affected.
__________
Description: zlib: compressBound() returns an incorrect result on z15
Symptom: Passing the result of compressBound() to compress()
results in an error code.
Problem: compressBound() is not adjusted for DFLTCC.
Solution: Adjust compressBound() for DFLTCC like it's already done
for deflateBound(). Since zlib project does not accept
patches at the moment, the fix has been integrated into
the DFLTCC pull request:
https://github.com/madler/zlib/pull/410
The commitid is b25781e735363e04f6c56e21431c47e4afc50b17.
Reproduction: z15 only:
#include <assert.h>
#include <stdlib.h>
#include <zlib.h>
int main() {
Bytef in_buf[128], out_buf[1024];
for (size_t i = 0; i < sizeof(in_buf); i++)
in_buf[i] = rand();
uLongf dest_len = compressBound(sizeof(in_buf));
assert(dest_len <= sizeof(out_buf));
int ret = compress(out_buf, &dest_len,
in_buf, sizeof(in_buf));
assert(ret == Z_OK);
} |
|
| 2022-03-15 13:02:05 |
Frank Heimes |
description |
SRU Justification:
==================
[Impact]
* zlib: compressBound() returns an incorrect result on IBM z15 hardware.
* Passing the result of compressBound() to compress() results
in an error code.
* This is because compressBound() is not adjusted for DFLTCC.
[Fix]
* Adjust compressBound() for DFLTCC like it's already done
for deflateBound().
* Since zlib project does not accept patches at the moment,
the fix has been integrated into the DFLTCC pull request:
https://github.com/madler/zlib/pull/410
The commitid is b25781e735363e04f6c56e21431c47e4afc50b17.
* The fix extracted out of the above is:
https://launchpadlibrarian.net/589857296/debdiff_zlib_1.2.11.dfsg-2ubuntu7_to_zlib_1.2.11.dfsg-2ubuntu8_jammy.diff
[Test Plan]
* An IBM z15 system (LPAR, z/VM guest or KVM virtual machine)
with Ubuntu Server 21.10 (or 22.04).
* A test can be done based on the following C test program:
#include <assert.h>
#include <stdlib.h>
#include <zlib.h>
int main() {
Bytef in_buf[128], out_buf[1024];
for (size_t i = 0; i < sizeof(in_buf); i++)
in_buf[i] = rand();
uLongf dest_len = compressBound(sizeof(in_buf));
assert(dest_len <= sizeof(out_buf));
int ret = compress(out_buf, &dest_len,
in_buf, sizeof(in_buf));
assert(ret == Z_OK);
}
* The test needs to be done by IBM, due to the requirements
for the special z15 hardware.
[Where problems could occur]
* If the adjustment of compressBound() for DFLTCC is done
erroneously the issue can still be present or in worst case
even affect Z systems other than z15 only.
* The crc table can be broken, in case the endian detection
or the register initialization is done wrong.
* The compression can become errorneous with the new changes,
e.g. in compressBound.
* Mistakes in dfltcc_free_window OF and especially DEFLATE_BOUND_COMPLEN,
(incl. the bit definitions), may cause various and unforseen defects.
* Any build time issues that might have been introduced by this patch
can be identified by a test build; this was done and is available here:
https://launchpad.net/~fheimes/+archive/ubuntu/lp1961427
[Other Info]
* Only impish and jammy are affected.
__________
Description: zlib: compressBound() returns an incorrect result on z15
Symptom: Passing the result of compressBound() to compress()
results in an error code.
Problem: compressBound() is not adjusted for DFLTCC.
Solution: Adjust compressBound() for DFLTCC like it's already done
for deflateBound(). Since zlib project does not accept
patches at the moment, the fix has been integrated into
the DFLTCC pull request:
https://github.com/madler/zlib/pull/410
The commitid is b25781e735363e04f6c56e21431c47e4afc50b17.
Reproduction: z15 only:
#include <assert.h>
#include <stdlib.h>
#include <zlib.h>
int main() {
Bytef in_buf[128], out_buf[1024];
for (size_t i = 0; i < sizeof(in_buf); i++)
in_buf[i] = rand();
uLongf dest_len = compressBound(sizeof(in_buf));
assert(dest_len <= sizeof(out_buf));
int ret = compress(out_buf, &dest_len,
in_buf, sizeof(in_buf));
assert(ret == Z_OK);
} |
SRU Justification:
==================
[Impact]
* zlib: compressBound() returns an incorrect result on IBM z15 hardware.
* Passing the result of compressBound() to compress() results
in an error code.
* This is because compressBound() is not adjusted for DFLTCC.
[Fix]
* Adjust compressBound() for DFLTCC like it's already done
for deflateBound().
* Since zlib project does not accept patches at the moment,
the fix has been integrated into the DFLTCC pull request:
https://github.com/madler/zlib/pull/410
The commitid is b25781e735363e04f6c56e21431c47e4afc50b17.
* The fix extracted out of the above is:
https://launchpadlibrarian.net/589857296/debdiff_zlib_1.2.11.dfsg-2ubuntu7_to_zlib_1.2.11.dfsg-2ubuntu8_jammy.diff
[Test Plan]
* An IBM z15 system (LPAR, z/VM guest or KVM virtual machine)
with Ubuntu Server 21.10 (or 22.04).
* A test can be done based on the following C test program:
#include <assert.h>
#include <stdlib.h>
#include <zlib.h>
int main() {
Bytef in_buf[128], out_buf[1024];
for (size_t i = 0; i < sizeof(in_buf); i++)
in_buf[i] = rand();
uLongf dest_len = compressBound(sizeof(in_buf));
assert(dest_len <= sizeof(out_buf));
int ret = compress(out_buf, &dest_len,
in_buf, sizeof(in_buf));
assert(ret == Z_OK);
}
* The test needs to be done by IBM, due to the requirements
for the special z15 hardware.
* A successful test was just completed, based on the version in jammy-proposed, which is at the same code level that the impish version this SRU is targeted for.
[Where problems could occur]
* If the adjustment of compressBound() for DFLTCC is done
erroneously the issue can still be present or in worst case
even affect Z systems other than z15 only.
* The compression can become errorneous with the new changes,
e.g. in compressBound.
* Mistakes in dfltcc_free_window OF and especially DEFLATE_BOUND_COMPLEN,
(incl. the bit definitions), may cause various and unforseen defects.
* Any build time issues that might have been introduced by this patch
can be identified by a test build; this was done and is available here:
https://launchpad.net/~fheimes/+archive/ubuntu/lp1961427
[Other Info]
* Only impish and jammy are affected.
__________
Description: zlib: compressBound() returns an incorrect result on z15
Symptom: Passing the result of compressBound() to compress()
results in an error code.
Problem: compressBound() is not adjusted for DFLTCC.
Solution: Adjust compressBound() for DFLTCC like it's already done
for deflateBound(). Since zlib project does not accept
patches at the moment, the fix has been integrated into
the DFLTCC pull request:
https://github.com/madler/zlib/pull/410
The commitid is b25781e735363e04f6c56e21431c47e4afc50b17.
Reproduction: z15 only:
#include <assert.h>
#include <stdlib.h>
#include <zlib.h>
int main() {
Bytef in_buf[128], out_buf[1024];
for (size_t i = 0; i < sizeof(in_buf); i++)
in_buf[i] = rand();
uLongf dest_len = compressBound(sizeof(in_buf));
assert(dest_len <= sizeof(out_buf));
int ret = compress(out_buf, &dest_len,
in_buf, sizeof(in_buf));
assert(ret == Z_OK);
} |
|
| 2022-03-15 15:23:36 |
Frank Heimes |
nominated for series |
|
Ubuntu Focal |
|
| 2022-03-15 15:23:36 |
Frank Heimes |
bug task added |
|
zlib (Ubuntu Focal) |
|
| 2022-03-15 15:24:13 |
Frank Heimes |
description |
SRU Justification:
==================
[Impact]
* zlib: compressBound() returns an incorrect result on IBM z15 hardware.
* Passing the result of compressBound() to compress() results
in an error code.
* This is because compressBound() is not adjusted for DFLTCC.
[Fix]
* Adjust compressBound() for DFLTCC like it's already done
for deflateBound().
* Since zlib project does not accept patches at the moment,
the fix has been integrated into the DFLTCC pull request:
https://github.com/madler/zlib/pull/410
The commitid is b25781e735363e04f6c56e21431c47e4afc50b17.
* The fix extracted out of the above is:
https://launchpadlibrarian.net/589857296/debdiff_zlib_1.2.11.dfsg-2ubuntu7_to_zlib_1.2.11.dfsg-2ubuntu8_jammy.diff
[Test Plan]
* An IBM z15 system (LPAR, z/VM guest or KVM virtual machine)
with Ubuntu Server 21.10 (or 22.04).
* A test can be done based on the following C test program:
#include <assert.h>
#include <stdlib.h>
#include <zlib.h>
int main() {
Bytef in_buf[128], out_buf[1024];
for (size_t i = 0; i < sizeof(in_buf); i++)
in_buf[i] = rand();
uLongf dest_len = compressBound(sizeof(in_buf));
assert(dest_len <= sizeof(out_buf));
int ret = compress(out_buf, &dest_len,
in_buf, sizeof(in_buf));
assert(ret == Z_OK);
}
* The test needs to be done by IBM, due to the requirements
for the special z15 hardware.
* A successful test was just completed, based on the version in jammy-proposed, which is at the same code level that the impish version this SRU is targeted for.
[Where problems could occur]
* If the adjustment of compressBound() for DFLTCC is done
erroneously the issue can still be present or in worst case
even affect Z systems other than z15 only.
* The compression can become errorneous with the new changes,
e.g. in compressBound.
* Mistakes in dfltcc_free_window OF and especially DEFLATE_BOUND_COMPLEN,
(incl. the bit definitions), may cause various and unforseen defects.
* Any build time issues that might have been introduced by this patch
can be identified by a test build; this was done and is available here:
https://launchpad.net/~fheimes/+archive/ubuntu/lp1961427
[Other Info]
* Only impish and jammy are affected.
__________
Description: zlib: compressBound() returns an incorrect result on z15
Symptom: Passing the result of compressBound() to compress()
results in an error code.
Problem: compressBound() is not adjusted for DFLTCC.
Solution: Adjust compressBound() for DFLTCC like it's already done
for deflateBound(). Since zlib project does not accept
patches at the moment, the fix has been integrated into
the DFLTCC pull request:
https://github.com/madler/zlib/pull/410
The commitid is b25781e735363e04f6c56e21431c47e4afc50b17.
Reproduction: z15 only:
#include <assert.h>
#include <stdlib.h>
#include <zlib.h>
int main() {
Bytef in_buf[128], out_buf[1024];
for (size_t i = 0; i < sizeof(in_buf); i++)
in_buf[i] = rand();
uLongf dest_len = compressBound(sizeof(in_buf));
assert(dest_len <= sizeof(out_buf));
int ret = compress(out_buf, &dest_len,
in_buf, sizeof(in_buf));
assert(ret == Z_OK);
} |
SRU Justification:
==================
[Impact]
* zlib: compressBound() returns an incorrect result on IBM z15 hardware.
* Passing the result of compressBound() to compress() results
in an error code.
* This is because compressBound() is not adjusted for DFLTCC.
[Fix]
* Adjust compressBound() for DFLTCC like it's already done
for deflateBound().
* Since zlib project does not accept patches at the moment,
the fix has been integrated into the DFLTCC pull request:
https://github.com/madler/zlib/pull/410
The commitid is b25781e735363e04f6c56e21431c47e4afc50b17.
* The fix extracted out of the above is:
https://launchpadlibrarian.net/589857296/debdiff_zlib_1.2.11.dfsg-2ubuntu7_to_zlib_1.2.11.dfsg-2ubuntu8_jammy.diff
[Test Plan]
* An IBM z15 system (LPAR, z/VM guest or KVM virtual machine)
with Ubuntu Server 21.10 (or 22.04).
* A test can be done based on the following C test program:
#include <assert.h>
#include <stdlib.h>
#include <zlib.h>
int main() {
Bytef in_buf[128], out_buf[1024];
for (size_t i = 0; i < sizeof(in_buf); i++)
in_buf[i] = rand();
uLongf dest_len = compressBound(sizeof(in_buf));
assert(dest_len <= sizeof(out_buf));
int ret = compress(out_buf, &dest_len,
in_buf, sizeof(in_buf));
assert(ret == Z_OK);
}
* The test needs to be done by IBM, due to the requirements
for the special z15 hardware.
* A successful test was just completed, based on the version in jammy-proposed, which is at the same code level that the impish version this SRU is targeted for.
[Where problems could occur]
* If the adjustment of compressBound() for DFLTCC is done
erroneously the issue can still be present or in worst case
even affect Z systems other than z15 only.
* The compression can become errorneous with the new changes,
e.g. in compressBound.
* Mistakes in dfltcc_free_window OF and especially DEFLATE_BOUND_COMPLEN,
(incl. the bit definitions), may cause various and unforseen defects.
* Any build time issues that might have been introduced by this patch
can be identified by a test build; this was done and is available here:
https://launchpad.net/~fheimes/+archive/ubuntu/lp1961427
[Other Info]
* Ubuntu jammy, impish and focal are affected.
__________
Description: zlib: compressBound() returns an incorrect result on z15
Symptom: Passing the result of compressBound() to compress()
results in an error code.
Problem: compressBound() is not adjusted for DFLTCC.
Solution: Adjust compressBound() for DFLTCC like it's already done
for deflateBound(). Since zlib project does not accept
patches at the moment, the fix has been integrated into
the DFLTCC pull request:
https://github.com/madler/zlib/pull/410
The commitid is b25781e735363e04f6c56e21431c47e4afc50b17.
Reproduction: z15 only:
#include <assert.h>
#include <stdlib.h>
#include <zlib.h>
int main() {
Bytef in_buf[128], out_buf[1024];
for (size_t i = 0; i < sizeof(in_buf); i++)
in_buf[i] = rand();
uLongf dest_len = compressBound(sizeof(in_buf));
assert(dest_len <= sizeof(out_buf));
int ret = compress(out_buf, &dest_len,
in_buf, sizeof(in_buf));
assert(ret == Z_OK);
} |
|
| 2022-03-15 18:01:45 |
Frank Heimes |
attachment added |
|
debdiff_zlib_1.2.11.dfsg-2ubuntu1.2_to_zlib_1.2.11.dfsg-2ubuntu1.3 https://bugs.launchpad.net/ubuntu/+source/zlib/+bug/1961427/+attachment/5569357/+files/debdiff_zlib_1.2.11.dfsg-2ubuntu1.2_to_zlib_1.2.11.dfsg-2ubuntu1.3_focal.diff |
|
| 2022-03-15 18:04:06 |
Frank Heimes |
attachment added |
|
debdiff_zlib_1.2.11.dfsg-2ubuntu7_to_zlib_1.2.11.dfsg-2ubuntu8 https://bugs.launchpad.net/ubuntu/+source/zlib/+bug/1961427/+attachment/5569358/+files/debdiff_zlib_1.2.11.dfsg-2ubuntu7_to_zlib_1.2.11.dfsg-2ubuntu8_impish.diff |
|
| 2022-03-15 19:22:50 |
Frank Heimes |
attachment removed |
debdiff_zlib_1.2.11.dfsg-2ubuntu7_to_zlib_1.2.11.dfsg-2ubuntu8 https://bugs.launchpad.net/ubuntu/+source/zlib/+bug/1961427/+attachment/5569358/+files/debdiff_zlib_1.2.11.dfsg-2ubuntu7_to_zlib_1.2.11.dfsg-2ubuntu8_impish.diff |
|
|
| 2022-03-15 19:24:58 |
Frank Heimes |
attachment added |
|
debdiff_zlib_1.2.11.dfsg-2ubuntu7_to_zlib_1.2.11.dfsg-2ubuntu7.1_impish.diff https://bugs.launchpad.net/ubuntu/+source/zlib/+bug/1961427/+attachment/5569372/+files/debdiff_zlib_1.2.11.dfsg-2ubuntu7_to_zlib_1.2.11.dfsg-2ubuntu7.1_impish.diff |
|
| 2022-03-15 19:28:20 |
bugproxy |
attachment added |
|
debdiff_zlib_1.2.11.dfsg-2ubuntu7_to_zlib_1.2.11.dfsg-2ubuntu8 https://bugs.launchpad.net/bugs/1961427/+attachment/5569373/+files/debdiff_zlib_1.2.11.dfsg-2ubuntu7_to_zlib_1.2.11.dfsg-2ubuntu8_impish.diff |
|
| 2022-03-21 10:27:56 |
Frank Heimes |
zlib (Ubuntu Jammy): status |
In Progress |
Incomplete |
|
| 2022-03-21 10:27:59 |
Frank Heimes |
ubuntu-z-systems: status |
New |
Incomplete |
|
| 2022-03-21 19:07:19 |
Jonathan Albrecht |
bug |
|
|
added subscriber Jonathan Albrecht |
| 2022-05-09 18:20:43 |
Frank Heimes |
bug task added |
|
bedtools (Ubuntu) |
|
| 2022-06-15 17:16:25 |
Frank Heimes |
description |
SRU Justification:
==================
[Impact]
* zlib: compressBound() returns an incorrect result on IBM z15 hardware.
* Passing the result of compressBound() to compress() results
in an error code.
* This is because compressBound() is not adjusted for DFLTCC.
[Fix]
* Adjust compressBound() for DFLTCC like it's already done
for deflateBound().
* Since zlib project does not accept patches at the moment,
the fix has been integrated into the DFLTCC pull request:
https://github.com/madler/zlib/pull/410
The commitid is b25781e735363e04f6c56e21431c47e4afc50b17.
* The fix extracted out of the above is:
https://launchpadlibrarian.net/589857296/debdiff_zlib_1.2.11.dfsg-2ubuntu7_to_zlib_1.2.11.dfsg-2ubuntu8_jammy.diff
[Test Plan]
* An IBM z15 system (LPAR, z/VM guest or KVM virtual machine)
with Ubuntu Server 21.10 (or 22.04).
* A test can be done based on the following C test program:
#include <assert.h>
#include <stdlib.h>
#include <zlib.h>
int main() {
Bytef in_buf[128], out_buf[1024];
for (size_t i = 0; i < sizeof(in_buf); i++)
in_buf[i] = rand();
uLongf dest_len = compressBound(sizeof(in_buf));
assert(dest_len <= sizeof(out_buf));
int ret = compress(out_buf, &dest_len,
in_buf, sizeof(in_buf));
assert(ret == Z_OK);
}
* The test needs to be done by IBM, due to the requirements
for the special z15 hardware.
* A successful test was just completed, based on the version in jammy-proposed, which is at the same code level that the impish version this SRU is targeted for.
[Where problems could occur]
* If the adjustment of compressBound() for DFLTCC is done
erroneously the issue can still be present or in worst case
even affect Z systems other than z15 only.
* The compression can become errorneous with the new changes,
e.g. in compressBound.
* Mistakes in dfltcc_free_window OF and especially DEFLATE_BOUND_COMPLEN,
(incl. the bit definitions), may cause various and unforseen defects.
* Any build time issues that might have been introduced by this patch
can be identified by a test build; this was done and is available here:
https://launchpad.net/~fheimes/+archive/ubuntu/lp1961427
[Other Info]
* Ubuntu jammy, impish and focal are affected.
__________
Description: zlib: compressBound() returns an incorrect result on z15
Symptom: Passing the result of compressBound() to compress()
results in an error code.
Problem: compressBound() is not adjusted for DFLTCC.
Solution: Adjust compressBound() for DFLTCC like it's already done
for deflateBound(). Since zlib project does not accept
patches at the moment, the fix has been integrated into
the DFLTCC pull request:
https://github.com/madler/zlib/pull/410
The commitid is b25781e735363e04f6c56e21431c47e4afc50b17.
Reproduction: z15 only:
#include <assert.h>
#include <stdlib.h>
#include <zlib.h>
int main() {
Bytef in_buf[128], out_buf[1024];
for (size_t i = 0; i < sizeof(in_buf); i++)
in_buf[i] = rand();
uLongf dest_len = compressBound(sizeof(in_buf));
assert(dest_len <= sizeof(out_buf));
int ret = compress(out_buf, &dest_len,
in_buf, sizeof(in_buf));
assert(ret == Z_OK);
} |
SRU Justification:
==================
[Impact]
* zlib: compressBound() returns an incorrect result on IBM z15 hardware.
* Passing the result of compressBound() to compress() results
in an error code.
* This is because compressBound() is not adjusted for DFLTCC.
[Fix]
* Adjust compressBound() for DFLTCC like it's already done
for deflateBound().
* Since zlib project does not accept patches at the moment,
the fix has been integrated into the DFLTCC pull request:
https://github.com/madler/zlib/pull/410
The commitid is b25781e735363e04f6c56e21431c47e4afc50b17.
* The fix extracted out of the above is:
https://launchpadlibrarian.net/589857296/debdiff_zlib_1.2.11.dfsg-2ubuntu7_to_zlib_1.2.11.dfsg-2ubuntu8_jammy.diff
* On top of this actual zlib fix, there is another patch needed:
'Remove compressBound assertions. (PR #1258)' for htslib.
* But there is a standalone 'htslib' package version, as well as a
htslib version included in (some) 'bedtools' packages.
Both need to be patched (see '[Other]' for more details).
[Test Plan]
* An IBM z15 system (LPAR, z/VM guest or KVM virtual machine)
with Ubuntu Server 21.10 (or 22.04).
* A test can be done based on the following C test program:
#include <assert.h>
#include <stdlib.h>
#include <zlib.h>
int main() {
Bytef in_buf[128], out_buf[1024];
for (size_t i = 0; i < sizeof(in_buf); i++)
in_buf[i] = rand();
uLongf dest_len = compressBound(sizeof(in_buf));
assert(dest_len <= sizeof(out_buf));
int ret = compress(out_buf, &dest_len,
in_buf, sizeof(in_buf));
assert(ret == Z_OK);
}
* The test needs to be done by IBM, due to the requirements
for the special z15 hardware.
* A successful test was just completed, based on the version in jammy-proposed, which is at the same code level that the impish version this SRU is targeted for.
[Where problems could occur]
* If the adjustment of compressBound() for DFLTCC is done
erroneously the issue can still be present or in worst case
even affect Z systems other than z15 only.
* The compression can become errorneous with the new changes,
e.g. in compressBound.
* Mistakes in dfltcc_free_window OF and especially DEFLATE_BOUND_COMPLEN,
(incl. the bit definitions), may cause various and unforseen defects.
* Any build time issues that might have been introduced by this patch
can be identified by a test build; this was done and is available here:
https://launchpad.net/~fheimes/+archive/ubuntu/lp1961427
[Other Info]
* Ubuntu jammy, impish and focal are affected by the zlib issue.
* The 'htslib' version '1.13+ds' (as it is part of I, J and K),
already includes the patch,
hence only htslib '1.10.2' in focal needs to be patched.
* The bedtools version '2.30.0+dfsg' (as it is part of I, J and K),
requires the patch,
but version '2.27.1+dfsg' bedtools in focal does not incl. an
embedded htslib, hence does not need to be (actually can't be)
patched.
* Patched version of the affected htslib and bedtools packages
are build and also available at this PPA:
https://launchpad.net/~fheimes/+archive/ubuntu/lp1961427
__________
Description: zlib: compressBound() returns an incorrect result on z15
Symptom: Passing the result of compressBound() to compress()
results in an error code.
Problem: compressBound() is not adjusted for DFLTCC.
Solution: Adjust compressBound() for DFLTCC like it's already done
for deflateBound(). Since zlib project does not accept
patches at the moment, the fix has been integrated into
the DFLTCC pull request:
https://github.com/madler/zlib/pull/410
The commitid is b25781e735363e04f6c56e21431c47e4afc50b17.
Reproduction: z15 only:
#include <assert.h>
#include <stdlib.h>
#include <zlib.h>
int main() {
Bytef in_buf[128], out_buf[1024];
for (size_t i = 0; i < sizeof(in_buf); i++)
in_buf[i] = rand();
uLongf dest_len = compressBound(sizeof(in_buf));
assert(dest_len <= sizeof(out_buf));
int ret = compress(out_buf, &dest_len,
in_buf, sizeof(in_buf));
assert(ret == Z_OK);
} |
|
| 2022-06-15 17:16:54 |
Frank Heimes |
bug task added |
|
htslib (Ubuntu) |
|
| 2022-06-15 17:17:59 |
Frank Heimes |
htslib (Ubuntu Impish): status |
New |
Invalid |
|
| 2022-06-15 17:18:15 |
Frank Heimes |
htslib (Ubuntu Jammy): status |
New |
Invalid |
|
| 2022-06-15 17:18:51 |
Frank Heimes |
bedtools (Ubuntu Focal): status |
New |
Invalid |
|
| 2022-06-15 17:20:25 |
Frank Heimes |
attachment added |
|
debdiff_htslib_focal_from_1.10.2-3_to_1.10.2-3ubuntu0.1.patch https://bugs.launchpad.net/ubuntu/focal/+source/bedtools/+bug/1961427/+attachment/5597484/+files/debdiff_htslib_focal_from_1.10.2-3_to_1.10.2-3ubuntu0.1.patch |
|
| 2022-06-15 17:22:41 |
Frank Heimes |
attachment added |
|
debdiff_bedtools_kinetic_from_2.30.0+dfsg-2_to_2.30.0+dfsg-2ubuntu1.patch https://bugs.launchpad.net/ubuntu/focal/+source/bedtools/+bug/1961427/+attachment/5597488/+files/debdiff_bedtools_kinetic_from_2.30.0+dfsg-2_to_2.30.0+dfsg-2ubuntu1.patch |
|
| 2022-06-15 17:23:04 |
Frank Heimes |
attachment added |
|
debdiff_bedtools_jammy_from_2.30.0+dfsg-2_to_2.30.0+dfsg-2ubuntu0.1.patch https://bugs.launchpad.net/ubuntu/focal/+source/bedtools/+bug/1961427/+attachment/5597489/+files/debdiff_bedtools_jammy_from_2.30.0+dfsg-2_to_2.30.0+dfsg-2ubuntu0.1.patch |
|
| 2022-06-15 17:23:27 |
Frank Heimes |
attachment added |
|
debdiff_bedtools_impish_from_2.30.0+dfsg-1_to_2.30.0+dfsg-1ubuntu0.1.patch https://bugs.launchpad.net/ubuntu/focal/+source/bedtools/+bug/1961427/+attachment/5597490/+files/debdiff_bedtools_impish_from_2.30.0+dfsg-1_to_2.30.0+dfsg-1ubuntu0.1.patch |
|
| 2022-06-15 17:43:01 |
Frank Heimes |
attachment added |
|
reverse dependencies, gathered on focal.txt https://bugs.launchpad.net/ubuntu/focal/+source/bedtools/+bug/1961427/+attachment/5597497/+files/reverse%20dependencies%2C%20gathered%20on%20focal.txt |
|
| 2022-06-15 17:43:32 |
Frank Heimes |
htslib (Ubuntu): status |
New |
Invalid |
|
| 2022-06-15 18:45:34 |
Frank Heimes |
ubuntu-z-systems: status |
Incomplete |
In Progress |
|
| 2022-06-15 18:46:37 |
Frank Heimes |
zlib (Ubuntu): status |
Incomplete |
In Progress |
|
| 2022-07-04 12:01:11 |
Frank Heimes |
bedtools (Ubuntu Impish): status |
New |
Won't Fix |
|
| 2022-07-04 12:01:35 |
Frank Heimes |
htslib (Ubuntu Impish): status |
Invalid |
Won't Fix |
|
| 2022-07-04 12:01:57 |
Frank Heimes |
zlib (Ubuntu Impish): status |
New |
Won't Fix |
|
| 2022-07-04 12:02:09 |
Frank Heimes |
zlib (Ubuntu Jammy): status |
Incomplete |
New |
|
| 2022-07-14 10:40:33 |
bugproxy |
tags |
architecture-s39064 bugnameltc-194923 fr-2079 patch severity-high targetmilestone-inin2110 |
architecture-s39064 bugnameltc-194923 fr-2079 patch severity-high targetmilestone-inin20045 |
|
| 2022-07-14 16:51:29 |
Frank Heimes |
attachment removed |
reverse dependencies, gathered on focal.txt https://bugs.launchpad.net/ubuntu/+source/zlib/+bug/1961427/+attachment/5597497/+files/reverse%20dependencies%2C%20gathered%20on%20focal.txt |
|
|
| 2022-07-21 06:20:53 |
Frank Heimes |
attachment added |
|
zlib debdiffs for jammy and kinetic (latest) https://bugs.launchpad.net/ubuntu/+source/htslib/+bug/1961427/+attachment/5604504/+files/debdiffs_J_K.tar.gz |
|
| 2022-07-21 06:31:29 |
bugproxy |
attachment added |
|
reverse dependencies, gathered on focal.txt https://bugs.launchpad.net/bugs/1961427/+attachment/5604505/+files/reverse_dependencies%2C_gathered_on_focal.txt |
|
| 2022-07-21 08:15:10 |
Frank Heimes |
attachment removed |
zlib debdiffs for jammy and kinetic (latest) https://bugs.launchpad.net/ubuntu/+source/htslib/+bug/1961427/+attachment/5604504/+files/debdiffs_J_K.tar.gz |
|
|
| 2022-07-21 08:16:02 |
Frank Heimes |
attachment added |
|
zlib debdiffs for kinetic, jammy and focal (latest) https://bugs.launchpad.net/ubuntu/+source/htslib/+bug/1961427/+attachment/5604515/+files/debdiffs_K_J_F.tar.gz |
|
| 2022-07-21 08:20:46 |
bugproxy |
attachment added |
|
zlib debdiffs for jammy and kinetic (latest) https://bugs.launchpad.net/bugs/1961427/+attachment/5604516/+files/debdiffs_J_K.tar.gz |
|
| 2022-07-21 16:28:33 |
Launchpad Janitor |
bedtools (Ubuntu): status |
New |
Fix Released |
|
| 2022-07-21 23:12:23 |
Brian Murray |
bedtools (Ubuntu Jammy): assignee |
|
Brian Murray (brian-murray) |
|
| 2022-07-21 23:12:36 |
Brian Murray |
htslib (Ubuntu Focal): assignee |
|
Brian Murray (brian-murray) |
|
| 2022-07-21 23:12:51 |
Brian Murray |
zlib (Ubuntu Focal): assignee |
|
Brian Murray (brian-murray) |
|
| 2022-07-22 05:30:48 |
Frank Heimes |
zlib (Ubuntu): status |
In Progress |
Fix Committed |
|
| 2022-07-29 17:16:54 |
Frank Heimes |
attachment added |
|
autopkgtest_local_for_libbio-samtools-perl.txt https://bugs.launchpad.net/ubuntu/+source/zlib/+bug/1961427/+attachment/5605907/+files/autopkgtest_local_for_libbio-samtools-perl.txt |
|
| 2022-08-05 21:17:00 |
Steve Langasek |
htslib (Ubuntu Focal): status |
New |
Fix Committed |
|
| 2022-08-05 21:17:04 |
Steve Langasek |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2022-08-05 21:17:06 |
Steve Langasek |
bug |
|
|
added subscriber SRU Verification |
| 2022-08-05 21:17:11 |
Steve Langasek |
tags |
architecture-s39064 bugnameltc-194923 fr-2079 patch severity-high targetmilestone-inin20045 |
architecture-s39064 bugnameltc-194923 fr-2079 patch severity-high targetmilestone-inin20045 verification-needed verification-needed-focal |
|
| 2022-08-05 21:35:34 |
Steve Langasek |
zlib (Ubuntu Focal): status |
New |
Fix Committed |
|
| 2022-08-11 07:50:32 |
Lukas Märdian |
zlib (Ubuntu Jammy): status |
New |
In Progress |
|
| 2022-08-12 23:07:54 |
Steve Langasek |
bedtools (Ubuntu Jammy): status |
New |
Fix Committed |
|
| 2022-08-12 23:08:00 |
Steve Langasek |
tags |
architecture-s39064 bugnameltc-194923 fr-2079 patch severity-high targetmilestone-inin20045 verification-needed verification-needed-focal |
architecture-s39064 bugnameltc-194923 fr-2079 patch severity-high targetmilestone-inin20045 verification-needed verification-needed-focal verification-needed-jammy |
|
| 2022-08-12 23:18:53 |
Steve Langasek |
zlib (Ubuntu Jammy): status |
In Progress |
Fix Committed |
|
| 2022-08-15 19:39:49 |
Launchpad Janitor |
zlib (Ubuntu): status |
Fix Committed |
Fix Released |
|
| 2022-09-05 16:00:13 |
Frank Heimes |
tags |
architecture-s39064 bugnameltc-194923 fr-2079 patch severity-high targetmilestone-inin20045 verification-needed verification-needed-focal verification-needed-jammy |
architecture-s39064 bugnameltc-194923 fr-2079 patch severity-high targetmilestone-inin20045 verification-done verification-done-focal verification-done-jammy |
|
| 2022-09-12 00:12:20 |
Matthieu Clemenceau |
tags |
architecture-s39064 bugnameltc-194923 fr-2079 patch severity-high targetmilestone-inin20045 verification-done verification-done-focal verification-done-jammy |
architecture-s39064 bugnameltc-194923 foundations-todo fr-2079 patch severity-high targetmilestone-inin20045 verification-done verification-done-focal verification-done-jammy |
|
| 2022-09-12 00:12:31 |
Matthieu Clemenceau |
bug |
|
|
added subscriber Ubuntu Foundations Team |
| 2022-09-12 14:19:11 |
Launchpad Janitor |
zlib (Ubuntu Jammy): status |
Fix Committed |
Fix Released |
|
| 2022-09-12 14:19:16 |
Łukasz Zemczak |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2022-09-12 14:19:33 |
Launchpad Janitor |
bedtools (Ubuntu Jammy): status |
Fix Committed |
Fix Released |
|
| 2022-09-12 15:27:35 |
Frank Heimes |
ubuntu-z-systems: status |
In Progress |
Fix Committed |
|
| 2022-09-15 15:41:56 |
Matthieu Clemenceau |
removed subscriber Ubuntu Foundations Team |
|
|
|
| 2022-09-15 15:42:01 |
Matthieu Clemenceau |
bug |
|
|
added subscriber Ubuntu Foundations Bugs |
| 2022-09-22 09:18:03 |
Łukasz Zemczak |
tags |
architecture-s39064 bugnameltc-194923 foundations-todo fr-2079 patch severity-high targetmilestone-inin20045 verification-done verification-done-focal verification-done-jammy |
architecture-s39064 bugnameltc-194923 foundations-todo fr-2079 patch severity-high targetmilestone-inin20045 verification-done-jammy verification-needed verification-needed-focal |
|
| 2022-09-22 09:51:21 |
bugproxy |
tags |
architecture-s39064 bugnameltc-194923 foundations-todo fr-2079 patch severity-high targetmilestone-inin20045 verification-done-jammy verification-needed verification-needed-focal |
architecture-s39064 bugnameltc-194923 foundations-todo fr-2079 patch severity-high targetmilestone-inin20045 verification-done verification-done-focal verification-done-jammy |
|
| 2022-09-22 10:11:09 |
bugproxy |
tags |
architecture-s39064 bugnameltc-194923 foundations-todo fr-2079 patch severity-high targetmilestone-inin20045 verification-done verification-done-focal verification-done-jammy |
architecture-s39064 bugnameltc-194923 foundations-todo fr-2079 patch severity-high targetmilestone-inin20045 verification-done-jammy verification-needed verification-needed-focal |
|
| 2022-09-22 12:21:57 |
bugproxy |
tags |
architecture-s39064 bugnameltc-194923 foundations-todo fr-2079 patch severity-high targetmilestone-inin20045 verification-done-jammy verification-needed verification-needed-focal |
architecture-s39064 bugnameltc-194923 foundations-todo fr-2079 patch severity-high targetmilestone-inin20045 verification-done verification-done-focal verification-done-jammy |
|
| 2022-09-26 15:54:11 |
Brian Murray |
tags |
architecture-s39064 bugnameltc-194923 foundations-todo fr-2079 patch severity-high targetmilestone-inin20045 verification-done verification-done-focal verification-done-jammy |
architecture-s39064 bugnameltc-194923 fr-2079 patch severity-high targetmilestone-inin20045 verification-done verification-done-focal verification-done-jammy |
|
| 2022-10-05 04:06:16 |
Launchpad Janitor |
zlib (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|
| 2022-10-05 05:05:37 |
Frank Heimes |
ubuntu-z-systems: status |
Fix Committed |
Fix Released |
|
| 2022-10-05 22:06:49 |
Launchpad Janitor |
htslib (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|
| 2022-10-06 14:19:53 |
Simon Chopin |
removed subscriber Ubuntu Foundations Bugs |
|
|
|
