Activity log for bug #1899621

Date Who What changed Old value New value Message
2020-10-13 11:29:37 bugproxy bug added bug
2020-10-13 11:29:40 bugproxy tags architecture-s39064 bugnameltc-188656 severity-high targetmilestone-inin2004
2020-10-13 11:29:41 bugproxy attachment added patch https://bugs.launchpad.net/bugs/1899621/+attachment/5421694/+files/patch
2020-10-13 11:29:42 bugproxy ubuntu: assignee Skipper Bug Screeners (skipper-screen-team)
2020-10-13 11:29:45 bugproxy affects ubuntu zlib (Ubuntu)
2020-10-13 12:51:42 Andrew Cloke bug task added ubuntu-z-systems
2020-10-13 12:51:50 Andrew Cloke ubuntu-z-systems: importance Undecided High
2020-10-13 13:06:05 Frank Heimes nominated for series Ubuntu Groovy
2020-10-13 13:06:05 Frank Heimes bug task added zlib (Ubuntu Groovy)
2020-10-13 13:06:05 Frank Heimes nominated for series Ubuntu Focal
2020-10-13 13:06:05 Frank Heimes bug task added zlib (Ubuntu Focal)
2020-10-13 14:09:56 Dimitri John Ledkov zlib (Ubuntu Groovy): importance Undecided Critical
2020-10-13 14:09:58 Dimitri John Ledkov zlib (Ubuntu Focal): importance Undecided Critical
2020-10-13 14:10:12 Dimitri John Ledkov bug task added ubuntu-release-notes
2020-10-13 14:10:25 Dimitri John Ledkov zlib (Ubuntu Groovy): milestone ubuntu-20.10
2020-10-13 14:10:28 Dimitri John Ledkov zlib (Ubuntu Focal): milestone focal-updates
2020-10-13 15:25:11 Frank Heimes ubuntu-z-systems: assignee Skipper Bug Screeners (skipper-screen-team)
2020-10-14 14:37:44 Brian Murray zlib (Ubuntu Groovy): milestone ubuntu-20.10 groovy-updates
2020-10-15 09:52:58 Dimitri John Ledkov description Description: zlib: inflateSyncPoint() returns an incorrect result on z15 Symptom: Certain rsync builds fail with "error in rsync protocol data stream" on z15. Problem: inflateSyncPoint() does not take into account the hardware compression state and returns an incorrect result. Solution: Make inflateSyncPoint() fail if the hardware compression is on. The hardware does not provide enough information in order to implement this function. Reproduction: z15 only: printf 1 >1 && rsync -z 1 2 Description: zlib: inflateSyncPoint() returns an incorrect result on z15 Symptom: Certain rsync builds fail with "error in rsync protocol data                stream" on z15. Problem: inflateSyncPoint() does not take into account the hardware                compression state and returns an incorrect result. Solution: Make inflateSyncPoint() fail if the hardware compression is on.                The hardware does not provide enough information in order to                implement this function. [Impact] * Certain rsync builds fail with "error in rsync protocol data stream" on z15. * rsync with non-default zlib compression (-z flag) uses inflateSyncPoint() API. * inflateSyncPoint() does not take into account the hardware compression state and returns an incorrect result. * Make inflateSyncPoint() fail if the hardware compression is on. The hardware does not provide enough information in order to implement this function. * Above makes rsync to succeed, when zlib uses hardware compression. [Test Case] Reproduction: z15 only: printf 1 >1 && rsync -z 1 2 [Regression Potential] * inflateSyncPoint API is rarely used. Scanning codesearch, there is a lot of false positives due to embedded copies of zlib in all the things. I do see that both rsync and backuppc-rsync use it. It used during a safety check to ensure that algorithm is not at a sync point (or that cannot be determined). Nonetheless, returning error is a safer implementation for this API call. [Other Info] * This is a regression introduced by adding & enabling zlib hw acceleration by default on z15; and discovering using rsync that one API is implemented incorrectly.
2020-10-15 09:55:01 Dimitri John Ledkov description Description: zlib: inflateSyncPoint() returns an incorrect result on z15 Symptom: Certain rsync builds fail with "error in rsync protocol data                stream" on z15. Problem: inflateSyncPoint() does not take into account the hardware                compression state and returns an incorrect result. Solution: Make inflateSyncPoint() fail if the hardware compression is on.                The hardware does not provide enough information in order to                implement this function. [Impact] * Certain rsync builds fail with "error in rsync protocol data stream" on z15. * rsync with non-default zlib compression (-z flag) uses inflateSyncPoint() API. * inflateSyncPoint() does not take into account the hardware compression state and returns an incorrect result. * Make inflateSyncPoint() fail if the hardware compression is on. The hardware does not provide enough information in order to implement this function. * Above makes rsync to succeed, when zlib uses hardware compression. [Test Case] Reproduction: z15 only: printf 1 >1 && rsync -z 1 2 [Regression Potential] * inflateSyncPoint API is rarely used. Scanning codesearch, there is a lot of false positives due to embedded copies of zlib in all the things. I do see that both rsync and backuppc-rsync use it. It used during a safety check to ensure that algorithm is not at a sync point (or that cannot be determined). Nonetheless, returning error is a safer implementation for this API call. [Other Info] * This is a regression introduced by adding & enabling zlib hw acceleration by default on z15; and discovering using rsync that one API is implemented incorrectly. Description: zlib: inflateSyncPoint() returns an incorrect result on z15 Symptom: Certain rsync builds fail with "error in rsync protocol data                stream" on z15. Problem: inflateSyncPoint() does not take into account the hardware                compression state and returns an incorrect result. Solution: Make inflateSyncPoint() fail if the hardware compression is on.                The hardware does not provide enough information in order to                implement this function. [Impact]  * Certain rsync builds fail with "error in rsync protocol data stream" on z15.  * On ubuntu, rsync normally uses zstd or lz4. But when rsync is forced to use non-default zlib compression (-z flag) it uses inflateSyncPoint() API. This can also happen when rsync on the the other end doesn't support zstd & lz4.  * inflateSyncPoint() does not take into account the hardware compression state and returns an incorrect result.  * Make inflateSyncPoint() fail if the hardware compression is on. The hardware does not provide enough information in order to implement this function.  * Above makes rsync to succeed, when zlib uses hardware compression. [Test Case] Reproduction: z15 only: printf 1 >1 && rsync -z 1 2 [Regression Potential]  * inflateSyncPoint API is rarely used. Scanning codesearch, there is a lot of false positives due to embedded copies of zlib in all the things. I do see that both rsync and backuppc-rsync use it. It used during a safety check to ensure that algorithm is not at a sync point (or that cannot be determined). Nonetheless, returning error is a safer implementation for this API call. [Other Info]  * This is a regression introduced by adding & enabling zlib hw acceleration by default on z15; and discovering using rsync that one API is implemented incorrectly.
2020-10-15 10:11:35 Dimitri John Ledkov zlib (Ubuntu Focal): status New In Progress
2020-10-15 10:11:38 Dimitri John Ledkov zlib (Ubuntu Groovy): status New In Progress
2020-10-19 23:56:54 Launchpad Janitor zlib (Ubuntu Groovy): status In Progress Fix Released
2020-10-20 05:23:24 Frank Heimes ubuntu-z-systems: status New In Progress
2020-10-20 09:06:21 Dimitri John Ledkov bug task deleted ubuntu-release-notes
2020-10-20 21:22:46 Brian Murray zlib (Ubuntu Focal): status In Progress Fix Committed
2020-10-20 21:22:49 Brian Murray bug added subscriber Ubuntu Stable Release Updates Team
2020-10-20 21:22:50 Brian Murray bug added subscriber SRU Verification
2020-10-20 21:22:54 Brian Murray tags architecture-s39064 bugnameltc-188656 severity-high targetmilestone-inin2004 architecture-s39064 bugnameltc-188656 severity-high targetmilestone-inin2004 verification-needed verification-needed-focal
2020-10-21 11:42:21 Frank Heimes tags architecture-s39064 bugnameltc-188656 severity-high targetmilestone-inin2004 verification-needed verification-needed-focal architecture-s39064 bugnameltc-188656 severity-high targetmilestone-inin2004 verification-done verification-done-focal
2020-10-21 11:42:32 Frank Heimes ubuntu-z-systems: status In Progress Fix Committed
2020-11-05 10:07:04 Łukasz Zemczak removed subscriber Ubuntu Stable Release Updates Team
2020-11-05 10:17:08 Launchpad Janitor zlib (Ubuntu Focal): status Fix Committed Fix Released
2020-11-05 10:50:55 Frank Heimes ubuntu-z-systems: status Fix Committed Fix Released