2019-11-13 09:35:25 |
Witold Krecicki |
bug |
|
|
added bug |
2019-11-13 09:35:25 |
Witold Krecicki |
attachment added |
|
zfs-encryptionroot-quote.patch https://bugs.launchpad.net/bugs/1852406/+attachment/5305012/+files/zfs-encryptionroot-quote.patch |
|
2019-11-13 09:50:25 |
Colin Ian King |
zfs-linux (Ubuntu): importance |
Undecided |
Medium |
|
2019-11-13 09:50:27 |
Colin Ian King |
zfs-linux (Ubuntu): assignee |
|
Colin Ian King (colin-king) |
|
2019-11-13 09:50:33 |
Colin Ian King |
zfs-linux (Ubuntu): status |
New |
Triaged |
|
2019-11-13 11:10:43 |
Colin Ian King |
nominated for series |
|
Ubuntu Focal |
|
2019-11-13 11:10:43 |
Colin Ian King |
bug task added |
|
zfs-linux (Ubuntu Focal) |
|
2019-11-13 11:10:49 |
Colin Ian King |
zfs-linux (Ubuntu Focal): status |
Triaged |
Fix Released |
|
2019-11-13 11:12:02 |
Colin Ian King |
nominated for series |
|
Ubuntu Eoan |
|
2019-11-13 11:12:02 |
Colin Ian King |
bug task added |
|
zfs-linux (Ubuntu Eoan) |
|
2019-11-13 11:12:10 |
Colin Ian King |
zfs-linux (Ubuntu Eoan): status |
New |
In Progress |
|
2019-11-13 11:12:12 |
Colin Ian King |
zfs-linux (Ubuntu Eoan): importance |
Undecided |
Medium |
|
2019-11-13 11:12:15 |
Colin Ian King |
zfs-linux (Ubuntu Eoan): assignee |
|
Colin Ian King (colin-king) |
|
2019-11-13 11:34:17 |
Colin Ian King |
description |
initramfs/scripts/zfs.in incorrectly quotes ${ENCRYPTIONROOT} on line 414:
DECRYPT_CMD="${ZFS} load-key '${ENCRYPTIONROOT}'"
This is OK when the line is executed by shell, such as in line 430 or 436, but when plymouth is used it results in plymouth executing "zfs load-key 'rpool'" - and zfs is unable to find pool called "'rpool'".
If I understand https://docs.oracle.com/cd/E23824_01/html/821-1448/gbcpt.html correctly zfs pool name is always 'shell-friendly', so removing the quotation marks would be a proper fix for that. |
== SRU Justification, Eoan ==
initramfs/scripts/zfs.in incorrectly quotes ${ENCRYPTIONROOT} on line 414:
DECRYPT_CMD="${ZFS} load-key '${ENCRYPTIONROOT}'"
This is OK when the line is executed by shell, such as in line 430 or 436, but when plymouth is used it results in plymouth executing "zfs load-key 'rpool'" - and zfs is unable to find pool called "'rpool'".
If I understand https://docs.oracle.com/cd/E23824_01/html/821-1448/gbcpt.html correctly zfs pool name is always 'shell-friendly', so removing the quotation marks would be a proper fix for that.
== Fix ==
One line fix as attached in https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1852406/comments/1
== Test ==
Boot with encrypted data set with plymouth. Without the fix zfs is unable to find the root encrypted pool. With the fix this works.
== Regression Potential ==
This just affects the encrypted dataset that holds key for root dataset; currently this is causing issues because of the bug, so the risk of the fix outweighs the current situation where this is currently broken. |
|
2019-11-13 12:52:50 |
Colin Ian King |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
2019-11-22 09:47:53 |
Timo Aaltonen |
zfs-linux (Ubuntu Eoan): status |
In Progress |
Fix Committed |
|
2019-11-22 09:47:56 |
Timo Aaltonen |
bug |
|
|
added subscriber SRU Verification |
2019-11-25 21:33:02 |
Colin Ian King |
tags |
|
verification-done verification-done-eoan |
|
2019-12-02 11:02:49 |
Launchpad Janitor |
zfs-linux (Ubuntu Eoan): status |
Fix Committed |
Fix Released |
|
2019-12-02 11:02:57 |
Ćukasz Zemczak |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|