Error reported when creating ZFS pool with "-t" option, despite successful pool creation
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
linux (Ubuntu) |
Fix Released
|
Medium
|
Colin Ian King | ||
Xenial |
Fix Released
|
Medium
|
Colin Ian King | ||
Bionic |
Fix Released
|
Medium
|
Colin Ian King | ||
Cosmic |
Fix Released
|
Medium
|
Colin Ian King | ||
zfs-linux (Ubuntu) |
Fix Released
|
Medium
|
Colin Ian King | ||
Xenial |
Fix Released
|
Medium
|
Colin Ian King | ||
Bionic |
Fix Released
|
Medium
|
Colin Ian King | ||
Cosmic |
Fix Released
|
Medium
|
Colin Ian King |
Bug Description
== SRU Justification, Xenial, Bionic ==
Bug:
When creating a pool with the -t option on Ubuntu 18.04 LTS, it will report an error and return a non-zero exit code, but the pool appears to be successfully created.
For example:
# zpool create -O canmount=off -O mountpoint=none -R /mnt/rpool-25582 -t rpool-25582 rpool /dev/mapper/loop2p1
cannot create 'rpool': no such pool or dataset
# zpool list
NAME SIZE ALLOC FREE EXPANDSZ FRAG CAP DEDUP HEALTH ALTROOT
rpool-25582 69.5G 92.5K 69.5G - 0% 0% 1.00x ONLINE /mnt/rpool-25582
# zpool export rpool-25582
# zpool import rpool
# zpool list
NAME SIZE ALLOC FREE EXPANDSZ FRAG CAP DEDUP HEALTH ALTROOT
rpool 69.5G 134K 69.5G - 0% 0% 1.00x ONLINE -
I opened an upstream bug against ZFS on Linux, here: https:/
And it has been recently fixed, here: https:/
Can this upstream fix be pulled into the Ubuntu 18.04 LTS packages?
Thanks,
Prakash
== Fix ==
Upstream zfs commit 4ceb8dd6fdfd ("Fix 'zpool create -t <tempname>'")
== Test ==
Without the fix, creating a pool with -t will show an error message such as:
"cannot create 'rpool': no such pool or dataset" and will return an error number even though it successfully created the pool. With the fix, the error is not shown and it exits with 0.
E.g.
pool create -O canmount=off -O mountpoint=none -R /mnt/rpool-25582 -t rpool-25582 rpool /dev/mapper/loop2p1
cannot create 'rpool': no such pool or dataset
== Regression Potential ==
Small. This is an upstream fix that is know to fix the error. There are no known subsequent changes to the fix hence suggesting it is a good fix. The change is very limited and testing shows it does not break any of the kernel team's ZFS regression testing.
CVE References
Changed in zfs-linux (Ubuntu): | |
status: | Confirmed → In Progress |
importance: | Undecided → High |
importance: | High → Medium |
assignee: | nobody → Colin Ian King (colin-king) |
Changed in linux (Ubuntu Cosmic): | |
assignee: | nobody → Colin Ian King (colin-king) |
Changed in zfs-linux (Ubuntu Bionic): | |
assignee: | nobody → Colin Ian King (colin-king) |
Changed in zfs-linux (Ubuntu Xenial): | |
assignee: | nobody → Colin Ian King (colin-king) |
Changed in linux (Ubuntu Bionic): | |
assignee: | nobody → Colin Ian King (colin-king) |
Changed in linux (Ubuntu Xenial): | |
assignee: | nobody → Colin Ian King (colin-king) |
Changed in zfs-linux (Ubuntu Bionic): | |
importance: | Undecided → Medium |
Changed in zfs-linux (Ubuntu Xenial): | |
importance: | Undecided → Medium |
Changed in linux (Ubuntu Cosmic): | |
importance: | Undecided → Medium |
Changed in linux (Ubuntu Bionic): | |
importance: | Undecided → Medium |
Changed in linux (Ubuntu Xenial): | |
importance: | Undecided → Medium |
description: | updated |
Changed in linux (Ubuntu Cosmic): | |
status: | Incomplete → Fix Committed |
Changed in linux (Ubuntu Bionic): | |
status: | Incomplete → Fix Committed |
Changed in linux (Ubuntu Xenial): | |
status: | Incomplete → Fix Committed |
tags: | added: cscc |
Status changed to 'Confirmed' because the bug affects multiple users.