minor changes to satisfy MIR request

Bug #1579082 reported by Colin Ian King on 2016-05-06
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
zfs-linux (Ubuntu)
High
Colin Ian King
Xenial
Undecided
Unassigned

Bug Description

[SRU][XENIAL]

This SRU contains a few minor fixes to satisfy the outstanding issues to complete the MIR filed for ZFS linux bug 1532198

[FIXES]

The outstanding fixes that need to be applied to the package were: https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1532198/comments/4

"- zfs-zed Replaces zfsutils-linux without a version constraint. Is that correct? I assumed a file moved from one package to another, in which case there should be a version."

DONE: zfs-zed, add Replaces: zfsutils-linux (<< 0.6.3)

"- I like the dep8 tests

So I'd say add a bug subscriber..."

DONE: canonical-kernel-team and colin-king

"... fix the Replaces line, ..."

DONE: zfs-zed, add Replaces: zfsutils-linux (<< 0.6.3)

"... address the init script lintian errors ...",

DONE: the initscripts will never be used, so we proposed to just add lintian ignores for these currently. When Debian accepts their zfs package we will rebase from this and will get init scripts from there.

"... and fix the sudoers file ...",

DONE: remove root ALL=(ALL) ALL from debian/tree/zfsutils-linux/etc/sudoers.d/zfs

[REGRESSION POTENTAL]
No actual change to the zfs code per se, more final changes to the packaging, regression potential minimal to zero.

Changed in spl-linux (Ubuntu):
importance: Undecided → High
assignee: nobody → Colin Ian King (colin-king)
status: New → In Progress
Changed in spl-linux (Ubuntu):
status: In Progress → Invalid
affects: spl-linux (Ubuntu) → zfs-linux (Ubuntu)
Changed in zfs-linux (Ubuntu):
status: Invalid → In Progress
description: updated
Richard Laager (rlaager) wrote :

Does this need a versioned Breaks as well? If not, I'm curious why (for my own learning for the future).

Richard Laager (rlaager) wrote :

<< 0.6.3 seems wrong. As I noted in the MIR bug report, the current versions of the packages still conflict because they both install zed.8.gz. That needs to be fixed at the same time and the version needs to be the version with that fix. I have this in the rlaager/zfs PPA.

Colin Ian King (colin-king) wrote :

Thanks Richard, I'll put your change into the package ASAP and get this in the upload queue.

description: updated
Richard Laager (rlaager) wrote :

I'd really love to see the R_ROOT thing removed as well. It serves no useful purpose, complicates people actually using the sudoers file, and pollutes the global namespace. Plus, I'm not sure what happens if someone defines R_ROOT twice (which isn't inconceivable).

Basically, I'm saying I want this change:
 #
-#Runas_Alias R_ROOT = root
-#
 ## allow any user to use basic read-only ZFS commands
-#ALL ALL = (R_ROOT) NOPASSWD: C_ZFS
+#ALL ALL = (root) NOPASSWD: C_ZFS

Hello Colin, or anyone else affected,

Accepted zfs-linux into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/zfs-linux/0.6.5.6-0ubuntu9 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in zfs-linux (Ubuntu Xenial):
status: New → Fix Committed
Richard Laager (rlaager) wrote :

I tested 0.6.5.6-0ubuntu9. Everything looks good to me.

tags: added: verification-done
Martin Pitt (pitti) wrote :

I'm mangling the v-done tag to block the propagation to -updates until this gets fixed in the devel series. Please always fix devel *first*!

Once you did that, please change the tag back to verification-done, so that it reappears on the SRU monitor for release.

tags: added: verification-done-blocked-on-devel
removed: verification-done
Richard Laager (rlaager) wrote :

See this PPA, which should be ready for a sync into yakkety:
https://launchpad.net/~rlaager/+archive/ubuntu/zfs-0.6.5.7-2

This is the combination of the changes from 0.6.5.6-0ubuntu9 in xenial-proposed applied to yakkety for this bug plus the fix for:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1577057

Note that the 1577057 fix has previously been tested by the reporter in 1577057.

Colin Ian King (colin-king) wrote :

I'll try and get your changes into yakkety today, thanks Richard.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package zfs-linux - 0.6.5.7-0ubuntu2

---------------
zfs-linux (0.6.5.7-0ubuntu2) yakkety; urgency=medium

  * Minor changes to satisfy MIR request (LP: #1579082)
    [ Richard Laager ]
    - zfs-zed: Version "Replaces: zfsutils-linux" and add versioned
     "Breaks: zfsutils-linux"
    - explicitly specify the man pages so we don't include zed.8
    [ Colin Ian King ]
    - remove root ALL=(ALL) ALL and R_ROOT from
      debian/tree/zfsutils-linux/etc/sudoers.d/zfs. The R_ROOT serves
      no useful purpose, complicates people actually using the sudoers
      file, and pollutes the global namespace
    - add init.d linitan overrides for zfsutils-linux and zfs-zed
      as initscripts will never be used and we will rebase with the
      Debian package initscripts once the package gets accepted by Debian
  [ Richard Laager ]
  * zfs-initramfs: When rootdelay is set, retry the `zpool export` command
    until it stops returning "is busy" (or the rootdelay expires).
    (LP: #1577057)

 -- Colin Ian King <email address hidden> Thu, 26 May 2016 15:28:13 +0100

Changed in zfs-linux (Ubuntu):
status: In Progress → Fix Released
Richard Laager (rlaager) on 2016-05-27
tags: added: verification-done
removed: verification-done-blocked-on-devel
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package zfs-linux - 0.6.5.6-0ubuntu9

---------------
zfs-linux (0.6.5.6-0ubuntu9) xenial; urgency=medium

  * Minor changes to satisfy MIR request (LP: #1579082)
    [ Richard Laager ]
    - zfs-zed: Version "Replaces: zfsutils-linux" and add versioned
     "Breaks: zfsutils-linux"
    - explicitly specify the man pages so we don't include zed.8
    [ Colin Ian King ]
    - remove root ALL=(ALL) ALL and R_ROOT from
      debian/tree/zfsutils-linux/etc/sudoers.d/zfs. The R_ROOT serves
      no useful purpose, complicates people actually using the sudoers
      file, and pollutes the global namespace
    - add init.d linitan overrides for zfsutils-linux and zfs-zed
      as initscripts will never be used and we will rebase with the
      Debian package initscripts once the package gets accepted by Debian

 -- Colin Ian King <email address hidden> Wed, 11 May 2016 19:40:11 +0100

Changed in zfs-linux (Ubuntu Xenial):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for zfs-linux has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers