E: zescrow-client: copyright-should-refer-to-common-license-file-for-gpl

Bug #974533 reported by Steve Langasek on 2012-04-05
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
zescrow (Ubuntu)
High
Unassigned

Bug Description

debian/copyright for zescrow says:

 You should have received a copy of the GNU General Public License
 along with this program. If not, see <http://www.gnu.org/licenses/>.

This is true, the user *did* receive a copy of said license, at /usr/share/common-licenses/GPL-3. The copyright file should point there as required by policy.

Also, the file has the same sort of boilerplate for AGPL:

  You should have received a copy of the GNU Affero General Public License
 along with this program. If not, see <http://www.gnu.org/licenses/>.

AGPL is *not* shipped in /usr/share/common-licenses, so recipients of this binary in all likelihood have *not* received a copy of this license... and shouldn't have to go to a third-party website to get it. Please include the full text of the AGPL in this file, as required by policy.

Revision history for this message
Steve Langasek (vorlon) wrote :

marking high because IIRC, failing to include a copy of the AGPL with the binary is a violation of the AGPL itself.

Changed in zescrow (Ubuntu):
importance: Undecided → High
status: New → Triaged
Revision history for this message
Alessandro Menti (elgaton) wrote :

I think the best way to fix this would be to include the AGPL license in the base-files package, making it available for other programs as well.

If it's OK, drop here a comment - I've got a debdiff against Debian unstable (almost) ready, so I can submit the patch there, sync with the Ubuntu development release and prepare SRUs.

Revision history for this message
Steve Langasek (vorlon) wrote :

No, introducing a delta in base-files is not a reasonable solution for this bug. The license needs to be included in the zescrow package.

Revision history for this message
Alessandro Menti (elgaton) wrote :

Done - I've included the full text of the AGPL in the debian/copyright file (it seems to be the only way to do that without making lintian complain, see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=642255#30 as well as what is done with the "otrs" package, which uses the same license).

I've also fixed a typo in the .desktop file ("Categories" was spelled incorrectly) and added a missing symlink (zescrow.1.gz -> zEscrow.1.gz) in the "man1" directory.

As I'm asking for a code review and seeking sponsorship for the patch, I'm subscribing ubuntu-sponsors.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package zescrow - 1.6-0ubuntu2

---------------
zescrow (1.6-0ubuntu2) quantal; urgency=low

  [ Alessandro Menti ]
  * Added missing AGPL 3 license text to debian/copyright. (LP: #974533)
  * Bumped Standards-Version in debian/control.
  * Added missing symlink from /usr/share/man/man1/zescrow.1.gz to zEscrow.1.gz
    in the same directory.
  * debian/patches/fix_desktop_file_typo.patch:
   - Fixed typo in category name in the zEscrow.desktop file.

  [ Andrew Starr-Bochicchio ]
  * debian/copyright: Point to copy of GPL-3 in common licenses.
 -- Alessandro Menti <email address hidden> Mon, 13 Aug 2012 20:00:38 -0400

Changed in zescrow (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

Hi Alessandro,

Thanks for your work on this! I've uploaded it, but I made a few small changes that you should note.

1) I added a link to the copy of the GPL-3 at /usr/share/common-licenses/GPL-3 in the GPL-3 stanza of debian/copyright in order to completely close this bug.
2) I rebased your changes on the version currently in quantal. So the version number is now 1.6-0ubuntu2
3) I moved your changes to the upstream source (the desktop file) into a proper patch in debian/patches.

Revision history for this message
Alessandro Menti (elgaton) wrote :

Thanks, Andrew - I'll keep note.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.