[SRU] Please accept zeroc-ice to supported releases

Bug #1815684 reported by José Gutiérrez de la Concha on 2019-02-12
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
zeroc-ice (Ubuntu)
Low
Unassigned
Bionic
Low
Unassigned

Bug Description

[Impact]

 * zeroc-ice (3.7.2-4) includes various bug fixes for problems reported in
   3.7.1 the most important fixes that can affect Ubuntu users are:

   * Fixed a bug in IceGrid that could result in an infinite loop
      when Ice.ChangeUser is set and the call to getpwnam_r fails with
      ERANGE.

      https://github.com/zeroc-ice/ice/commit/21f5c77fc305ea1441b069753b0467fc145f6547

   * Fixed a bug in the code that parses command line options that caused
     short command line options to be incorrectly parsed when multiple short
     command line options are specified together.

     https://github.com/zeroc-ice/ice/issues/168

   * Fixed a bug in the syslog logger that caused the program name to not be
     correctly displayed with log messages.

     https://github.com/zeroc-ice/ice/issues/230

   * Fixed a bug in the IceGrid GUI that could cause IceGrid GUI to hang
     after a login failure.

     https://github.com/zeroc-ice/ice/issues/90

   * Fixed a bug that caused the generated code to reference undefined variables
     when included (using require or require_once) from a static method.

     https://github.com/zeroc-ice/ice/issues/174

   * Fixed Python segfault that could occur because of a KeyboardInterrupt.

     https://github.com/zeroc-ice/ice/issues/107

   * Added usr/bin/slice2matlab and usr/share/man/man1/slice2matlab.1 to zeroc-ice-compilers
     The new compiler generate code for newly released Ice for MATLAB language mapping
     https://doc.zeroc.com/ice/3.7/language-mappings/matlab-mapping

   * Added debian patch 0001-Fix-macros-for-Linux-OS-detection
     This patch fixes build failures reported for debian ppc64el
     https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=921629

   * Removed debian patch debian/patches/classpath-contains-relative-path.diff
     The fix has been integrated upstream and is no longer required
     https://github.com/zeroc-ice/ice/commit/28be8830ecafff250caa471c86ffad8b64e6b998

   * Removed debian patch debian/patches/install-file-mode.diff
     The fix has been integrated upstream and the patch is no longer required
     https://github.com/zeroc-ice/ice/commit/62fe65069610f1083cb3e934c5ab50d3f891bf13

   * Removed debian patch debian/patches/java9-build
     The fix has been integrated upstream and the patch is no longer required
     https://github.com/zeroc-ice/ice/commit/225a0acaf1ec5211be670a9a22895329b325b4bb

   * Removed debian patch debian/patches/python2.7-install
     The fix has been integrated upstream and the patch is no longer required
     https://github.com/zeroc-ice/ice/commit/aef4492fbadf9ba1ff86a8ee54e5fe9837044fd6

    * Removed debian patch debian/patches/gcc8-build-fixes.patch
      The fixes has been incorporated upstream and the patch is no longer required
      https://github.com/zeroc-ice/ice/commit/8b221cc5a17ba64836a687e17cbbf46d9ac8b359
      https://github.com/zeroc-ice/ice/commit/a6a4981616b669432ff7b588179d6e93694d9e3f#diff-3b73a2fbecc036cf505b3bc8d6c6af16

    * Add missing openjfx dependency to debian/control
      https://github.com/zeroc-ice/ice-debian-packaging/commit/d0777641313706b3b4791caece9353e41e8208ef

    * Simplify Java dependencies in debian/control
      https://github.com/zeroc-ice/ice-debian-packaging/commit/1d8ef7b88e4b8347ea128d36195bc53ffc533b14

    * Fixed service scripts to correctly wait for daemons to start, without this the scripts were not waiting for the services to be fully started, this affects scripts for starting glacier2router, icegridnode and icegridregistry:

      debian/zeroc-glacier2.glacier2router.service
      debian/zeroc-icegrid.icegridnode.service
      debian/zeroc-icegrid.icegridregistry.service
    The fix was already in cosmic Ice 3.7.1 packages, but not in bionic Ice 3.7.0 packages

[Test Case]

 * There is more details of each bug in the links provided with they
   description

[Regression Potential]

 * Upstream packages are thoroughly tested before each release, and binary
   compatibility testing is done as part of the release process we (upstream)
   are confident that the chance for regression is very low.

 * The package has an extensive test suite that is build and run during
   package builds

[Other Info]

 zeroc-ice (3.7.2-4) corresponds to a new upstream microrelease. This package
 is already available in Ubuntu Disco and Debian Buster.

 The package build logs for bionic and cosmic are available in:

   https://launchpad.net/~y-jose/+archive/ubuntu/zeroc-ice

 The package build logs for debian are available in:

   https://buildd.debian.org/status/package.php?p=zeroc-ice

 A detailed changelog of the bugs included in this release is available at:

   https://raw.githubusercontent.com/zeroc-ice/ice-debian-packaging/master/CHANGELOG-3.7.md

 The debian changelog is available at:

   https://github.com/zeroc-ice/ice-debian-packaging/blob/master/debian/changelog

 Please SRU into bionic and cosmic

Changed in zeroc-ice (Ubuntu):
status: New → In Progress
Mathew Hodson (mhodson) on 2019-02-15
tags: added: upgrade-software-version
Changed in zeroc-ice (Ubuntu):
importance: Undecided → Low
Mathew Hodson (mhodson) on 2019-03-03
Changed in zeroc-ice (Ubuntu):
status: In Progress → Fix Released
Changed in zeroc-ice (Ubuntu Bionic):
importance: Undecided → Low
Simon Quigley (tsimonq2) wrote :

Hello José, thanks for your work on this!

Could you please edit the bug description to follow the SRU template? That can be found here: https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template

Unsubscribing the Ubuntu Sponsors Team, please resubscribe us when that is done.

Hi Simon, I have updated the description as requested

description: updated
Simon Quigley (tsimonq2) wrote :

Hello José, thanks for adjusting the bug description. Everything looks good there.

I was reviewing your debdiffs when I saw that a lot of Debian changes were rolled in here. While most of these changes I would consider acceptable for a stable release update, they should be documented in the bug description as well. All of the changes made should be strictly necessary, and e.g. the copyright http -> https change, while that is absolutely best practice and you should make that change in the current development release, I would not say it is necessary for an SRU.

I'm unsubscribing sponsors for now; sorry for the time it took to get back to you on this. I really hope we can drive this to completion.

Thanks!

description: updated
description: updated
description: updated

Updated debdiff for Ice 3.7.2 bionic backport

description: updated

Updated debdiff for Ice 3.7.2 cosmic backport

Hi Simon,

I have updated the description to include the changes to debian files, I have also limited the changes to debian files to the minimum and get rid of a few things that are not required for the SRU:

There are separate branches in our packaging repository for bionic and cosmic backports:

  * https://github.com/zeroc-ice/ice-debian-packaging/tree/bionic-3.7
  * https://github.com/zeroc-ice/ice-debian-packaging/tree/cosmic-3.7

I have uploaded the new packages to zeroc-ice ppa in:

  * https://launchpad.net/~y-jose/+archive/ubuntu/zeroc-ice

description: updated
Dan Streetman (ddstreet) on 2020-04-16
tags: added: ubuntu-sponsor-ddstreet
Dan Streetman (ddstreet) wrote :

@y-jose, hello and sorry for the delay.

I'm marking this as won't-fix for cosmic, since it's EOL.

The bionic diff shows there are some binary diffs that it doesn't capture (e.g. in PNG files, etc). It's easier (for me, at least) to pull it from a PPA where you have it built; can I use the package source from this ppa?
https://launchpad.net/~y-jose/+archive/ubuntu/zeroc-ice

If that's the right ppa for me to sponsor from, can you please update the debian/changelog entry to include the LP: tag to close this bug? Specifically it should include "LP: #1815684" in the latest changelog entry description text.

Does Eoan (or Focal) need any change, or only Bionic?

Finally, as I see you're a Debian maintainer for this package, might I suggest you apply for PPU rights to upload it into Ubuntu as well?
https://wiki.ubuntu.com/UbuntuDevelopers#PerPackage

Dan Streetman (ddstreet) wrote :

> I'm marking this as won't-fix for cosmic, since it's EOL.

well it wasn't targeted for cosmic, so I should have said I'll just ignore the cosmic debdiff :)

Dan Streetman (ddstreet) wrote :

Unsubscribing ubuntu-sponsors, I will sponsor when updated pkg is ready.

Hi Dan,

We have released 3.7.3, what should we do at this point, get first this 3.7.2 uploaded or skip it and try to get 3.7.3 in?

3.7.3 is binary compatible and include a few bug fixes and enhancements see https://github.com/zeroc-ice/ice/blob/3.7/CHANGELOG-3.7.md#changes-in-ice-373

let me know what you think and I will prepare the packages.

I will check the PPU link, thanks for the pointer.

Dan Streetman (ddstreet) wrote :

> We have released 3.7.3, what should we do at this point, get first this 3.7.2 uploaded or skip it and try to get 3.7.3 in?

> 3.7.3 is binary compatible and include a few bug fixes and enhancements see https://github.com/zeroc-ice/ice/blob/3.7/CHANGELOG-3.7.md#changes-in-ice-373

If it's binary compatible and includes bug fixes, and you've tested it on Bionic already, it sounds fine to me to upload 3.7.3 to Bionic. Let me know when you have it ready in the ppa.

Also, looking at the reverse-depends, the only other package I saw that appears to directly depend on any of the packages is mumble (which build-depends on libzeroc-ice-dev and runtime deps on libzeroc-ice3.7); if the new version is binary compatible that should be ok, but can you check it just to make sure?

Thanks!

Hi Dan,

I have uploaded the 3.7.3 packages to https://launchpad.net/~y-jose/+archive/ubuntu/zeroc-ice

I installed mumble with 3.7.3 and didn't find any issue (but I'm not mumble expert, just did a default install).

I also check that mumble source build works with the new zeroc-ice 3.7.3 packages.

@ddstreet did you have a chance to look at this?

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers