zeitgeist ftbfs with GCC 5

[Matthias Klose]

see
https://launchpadlibrarian.net/211752996/buildlog_ubuntu-wily-amd64.zeitgeist_0.9.14-2.2ubuntu6~gcc5.1_BUILDING.txt.gz

[Matthias Klose (doko)]

now fails with test failures
https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/landing-016/+build/7656034

[Matthias Klose (doko)]

Robert, please have a look. This is using GCC 5. There also is a new usptream release.

[Robert Ancell (robert-ancell)]

The linked build in comment 1 is for telephony-service, not zeitgeist.

[Robert Ancell (robert-ancell)]

The first build log is implying that Mir is not built / linekd correctly:
/usr/lib/x86_64-linux-gnu/libmirprotobuf.so.0: undefined reference to `google::protobuf::internal::WireFormatLite::WriteStringMaybeAliased(int, std::string const&, google::protobuf::io::CodedOutputStream*)'

[Robert Ancell (robert-ancell)]

https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/landing-016/+build/7656245 is a build failing with test.

[Robert Ancell (robert-ancell)]

I think the issue is the std::string object is going out of scope in the tests. The tests are like this:

g_assert_cmpstr (std::string ("scheme_no_spaces_in_uris"), ==, StringUtils::MangleUri("scheme:no spaces in uris").c_str ());

Inside the g_assert_cmpstr macro the two strings are stored in variables. Nothing is left holding the result of MangleUri () so the result from c_str () is no longer valid. I guess GCC 5.1 is more agressive in destroying the std:string than it used to be?

[Robert Ancell (robert-ancell)]

Note this only happens in the tests with strings > 15 characters in length. I suspect that must be the boundary where std::string starts mallocing the contents.

[Robert Ancell (robert-ancell)]

The tests were using a c_str() result from a std::string that had gone out of
scope. GCC 5.1 seems to be more agressive in freeing the string data before
the tests checked against it.

[Robert Ancell (robert-ancell)]

Created attachment 117327
Fix tests crashing with GCC 5.1

[Robert Ancell (robert-ancell)]

Patch filed upstream and upload to the GCC 5.1 PPA.

[Launchpad Janitor (janitor)]

This bug was fixed in the package zeitgeist - 0.9.16-0ubuntu2

---------------
zeitgeist (0.9.16-0ubuntu2) wily; urgency=medium

  * debian/patches/fix-test-crash.patch:
    - Fix tests crashing with GCC 5.1 (LP: #1475623)

 -- Robert Ancell <email address hidden> Fri, 24 Jul 2015 16:16:14 +1200

[Rico Tzschichholz (ricotz)]

commit f9d2b4a70b8fd11a5c1d399ce8f4d50ea60e7fbc
Author: Robert Ancell <email address hidden>
Date: Fri Jul 24 16:14:11 2015 +1200

    Fix tests crashing with GCC 5.1

    The tests were using a c_str() result from a std::string that had gone out of
    scope. GCC 5.1 seems to be more agressive in freeing the string data before
    the tests checked against it.

    https://bugs.freedesktop.org/show_bug.cgi?id=91443