yubihsm-shell FTBFS due to _FORTIFY_SOURCE redefinition

[Pushkar Kulkarni]

yubihsm-shell 2.6.0-3 FTBFS on plucky [1], because the upstream projects uses _FORTIFY_SOURCE=2.

========

cd /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/lib && /usr/bin/cc -DDEFAULT_CONNECTOR_URL=\"http://localhost:12345\" -DHAVE_EXPLICIT_BZERO -DOPENSSL_API_COMPAT=0x10000000L -DSOVERSION=\"2\" -DVERSION=\"2.6.0\" -D_FORTIFY_SOURCE=2 -Dyubihsm_http_EXPORTS -I/<<PKGBUILDDIR>>/lib -g -O3 -Werror=implicit-function-declaration -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fdebug-prefix-map=/<<PKGBUILDDIR>>=/usr/src/yubihsm-shell-2.6.0-3 -Wdate-time -D_FORTIFY_SOURCE=3 -I/usr/include/PCSC -flto -Wno-missing-braces -Wno-missing-field-initializers -std=gnu11 -fPIC -Wall -Wextra -Werror -Wformat -Wformat-nonliteral -Wformat-security -Wshadow -Wmissing-prototypes -Wbad-function-cast -pedantic -pedantic-errors -fpie -fpic -O2 -fstack-protector-all -Wno-implicit-fallthrough -MD -MT lib/CMakeFiles/yubihsm_http.dir/lib_util.c.o -MF CMakeFiles/yubihsm_http.dir/lib_util.c.o.d -o CMakeFiles/yubihsm_http.dir/lib_util.c.o -c /<<PKGBUILDDIR>>/lib/lib_util.c
cd /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/lib && /usr/bin/cc -DDEFAULT_CONNECTOR_URL=\"http://localhost:12345\" -DHAVE_EXPLICIT_BZERO -DOPENSSL_API_COMPAT=0x10000000L -DSOVERSION=\"2\" -DVERSION=\"2.6.0\" -D_FORTIFY_SOURCE=2 -Dyubihsm_EXPORTS -I/<<PKGBUILDDIR>>/lib -g -O3 -Werror=implicit-function-declaration -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -ffile-prefix-map=/<<PKGBUILDDIR>>=. -flto=auto -ffat-lto-objects -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fdebug-prefix-map=/<<PKGBUILDDIR>>=/usr/src/yubihsm-shell-2.6.0-3 -Wdate-time -D_FORTIFY_SOURCE=3 -I/usr/include/PCSC -flto -Wno-missing-braces -Wno-missing-field-initializers -std=gnu11 -fPIC -Wall -Wextra -Werror -Wformat -Wformat-nonliteral -Wformat-security -Wshadow -Wmissing-prototypes -Wbad-function-cast -pedantic -pedantic-errors -fpie -fpic -O2 -fstack-protector-all -Wno-implicit-fallthrough -MD -MT lib/CMakeFiles/yubihsm.dir/__/aes_cmac/aes_cmac.c.o -MF CMakeFiles/yubihsm.dir/__/aes_cmac/aes_cmac.c.o.d -o CMakeFiles/yubihsm.dir/__/aes_cmac/aes_cmac.c.o -c /<<PKGBUILDDIR>>/aes_cmac/aes_cmac.c

<command-line>: error: "_FORTIFY_SOURCE" redefined
<command-line>: note: this is the location of the previous definition
<command-line>: error: "_FORTIFY_SOURCE" redefined

======

[1] https://launchpadlibrarian.net/759073413/buildlog_ubuntu-plucky-amd64.yubihsm-shell_2.6.0-3_BUILDING.txt.gz

[Colin Watson (cjwatson)]

This isn't the sort of thing where it makes sense for Ubuntu to maintain a delta, so it should probably have been forwarded to Debian. Fortunately I (the Debian maintainer) happened to spot this.

Thanks for the patch! I've applied much the same thing to Debian with only minor wording adjustments, crediting you, and uploaded it as 2.6.0-4. It won't automatically close the merge proposal since there isn't common git history, but if you're happy with my changes then you can do that yourself.

https://salsa.debian.org/pkg-security-team/yubihsm-shell/-/commit/388eb8207421613b2e5de9cd4f3a896adc0004d6

[Pushkar Kulkarni (pushkarnk)]

Sure, thanks for the feedback! I'll close the merge proposal.

[Colin Watson (cjwatson)]

I'm not sure why it didn't auto-close the bug, but this is in plucky now:

yubihsm-shell (2.6.0-4) unstable; urgency=medium

  [ Pushkar Kulkarni ]
  * Remove redefinition of _FORTIFY_SOURCE (LP: #2089705).

 -- Colin Watson <email address hidden> Mon, 02 Dec 2024 13:02:14 +0000