[SRU] Really don't ship Yaru-dark

Bug #1799217 reported by Carlo Lobrano on 2018-10-22
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
yaru-theme (Ubuntu)
Low
Didier Roche
Cosmic
Low
Didier Roche

Bug Description

[Impact]
We thought we disabled separate dark theme in the package explicitely as long as GTK2 part of the dark theme isn't complete.
Currently, people enabling dark theme have:
- GTK3 apps with dark theme
- GTK2 apps with Adwaita theme

A typo order in package (we remove the dark theme directory AFTER dh_install) made it still shipping it. Do it in the correct order right now

[Test Case]
* Install the new package version from propsoed
* ls /usr/share/themes/Yaru-dark/
-> should be empty

[Regression Potential]
People who set Yaru Dark theme in Tweaks will default to Adwaita after the update. They can set it back to Yaru after the update with the same (unshipped by default) tools. We expect them to be technical enough as they changed the default.

--------------

yaru-theme package for Cosmic Cuttlefish includes 'Yaru-dark', which is not complete (it lacks of gtk2 folder).

Note, as discussed on IRC, in order to support applications that prefer dark variant, /usr/share/themes/Yaru/gtk-3.0/gtk-dark.css is enough

Changed in yaru-theme (Ubuntu):
assignee: nobody → Didier Roche (didrocks)
importance: Undecided → Low
status: New → Triaged
Didier Roche (didrocks) on 2018-10-22
summary: - Yaru-dark packaged even if not complete, nor necessary
+ [SRU] Really don't ship Yaru-dark
Didier Roche (didrocks) on 2018-10-22
description: updated
Danial Behzadi (dani.behzi) wrote :

Yaru-dark is a good theme. Either provide a dark variant for gtk-2 apps or make it possible to choose always dark mode of yaru.

Carlo Lobrano (c-lobrano) wrote :

gtk2 for Yaru-dark is almost done, but not ready yet

Jeremy Bicha (jbicha) wrote :

This SRU is going to irritate some people. It could be argued that dropping Yaru Dark now would be a regression for users who don't use GTK2 apps. (For many locales, Ubuntu 18.10 doesn't ship any gtk2 apps by default.)

Here's one user who believes that Yaru Dark is better for him with his visual impairment:
https://www.reddit.com/r/linux/comments/9snydq/lets_talk_about_the_state_of_accessibility_on/

I do recognize that this change has been waiting in the SRU queue since almost immediately after 18.10's release.

If you do go ahead with this change, I suggest you include instructions here for how users can get Yaru Dark back.

Didier Roche (didrocks) wrote :

People complained upstream that no GTK2 variant was there. Visually impaired should still use the accessibility highcontrast profile as they won't have good support with the default theme (Shell for instance has a lot of white elements).

There are instructions though on the github project on installing from source to get the Dark variant that we want to ship in dingo.

Steve Langasek (vorlon) wrote :

I understand the motivation, but given that this is not regression-free per Jeremy's comment, I don't think this meets the SRU policy. Rejecting from the queue; feel free to grab me on IRC if you believe this should be discussed further.

Also, please note that the package that was uploaded to the queue includes other changes which are not covered by this SRU bug:

  [ feichtmeier ]
  * Minor enhancement:
    - add small margin to radiobutton radio in popovers and checks

  [ Aaron Papin ]
  * Minor enhancements:
    - Treeview drop target is missing bottom green border + label
    - Left part of focus ring not displayed

While these may be sensible changes, the SRU process still needs to be followed.

An upload of yaru-theme to cosmic-proposed has been rejected from the upload queue for the following reason: "does not appear to meet SRU policy; https://bugs.launchpad.net/ubuntu/+source/yaru-theme/+bug/1799217/comments/5".

Jeremy Bicha (jbicha) wrote :

Didier, thank you for your comment. "High Contrast" is very white. There is a "HighContrastInverse" available in Tweaks which is very black. Selecting either of those themes doesn't change the color of the Shell modal dialogs. (An easy way to see the dialog is to click the system status menu in the right side of the top bar and click the Power button at the bottom of the menu.)

Didier Roche (didrocks) wrote :

Setting it as Won't fix then for cosmic.

Changed in yaru-theme (Ubuntu Cosmic):
status: Triaged → Won't Fix
Launchpad Janitor (janitor) wrote :
Download full text (12.3 KiB)

This bug was fixed in the package yaru-theme - 19.04

---------------
yaru-theme (19.04) disco; urgency=medium

  [ Carlo Lobrano ]
  * dark gtk-2.0
    - gtkrc: added dark colors
    - fixed line
    - fixed render-assets.sh permission
    - assets: added button normal state
    - assets: added button-hover
    - assets: added button-insensitive
    - assets: added button-active
    - added entry widgets
    - assets: fixed tabs and treeview headerbar
    - external-assets: added checkbox unchecked
    - external-assets: added radio unchecked
    - assets: added pan (normal and insensitive)
    - assets: added treeview-pan
    - assets: added spin arrows
    - assets: added spin button
    - assets: added scale slider hover and active
    - assets: added frame-notebook
    - assets: fixed missing recoloring of spin buttons
    - assets: fixed button insensitive border
    - assets: fixed frame border
    - assets: added transparent scrollbars
    - assets: added handle horz + vert
    - assets: added notebook-entries
    - assets: added menu-radio and menu-checkbox
    - main.rc: using menu-radio assets for radio checked
    - assets: fixed frame-inline
    - assets: fixed entry bleeding background
    - assets: fixed menu-pan colors
  * common/scale circular slider: made border transparent in dark variant
  * shell common+dock: Fix dock opaque color and revert badge color
  * shell/common: fixed auth dialog title style
  * shell/common: Made dialog background brighter
  * common/scale circular slider: made border transparent in dark variant
  * Moved code-refactoring changes from 3.0 to 3.20 folder
  * Fixed menu background and hover colors
  * Added missing dependency in yaru part yaml
  * Unify stackswitcher and buttonbox style
  * Reuse all buttonbox code for stackswitcher
  * Fixed missing hb button definition
  * Use background property to set insertion-cursor icon
  * Fixed insertion-cursor alignment
  * re-enable -dark theme in snap
  * testing snap session pointer to communitheme-dark
  * Set both default and -dark Communitheme path to GTK2_RC_FILES env
  * Update gtk-common-themes to release the -dark version as well
  * Revert snap/session changes
  * Fixed Nautilus dark backdrop separator color
  * Attempt to set gtk2 them path according to current theme set
  * Fixed set of GTK2_RC_FILES only when theme is Communitheme*
  * Fix typo
  * Remove test code
  * Fixed comparison test
  * Always set only one path to GTK2_RC_FILE
  * treeview expander invert hover colors
  * Fix linked entry+button combobox in error and warning state
  * Do not darken error/warning border color in dark variant
  * Remove unused underline_focus_headerbar
  * Fix menu button hover
  * Update README.md
  * Add active button state for menu button
  * Add toolbar button missing states
  * Fix osd button active and active:hover states
  * Unset GTK2_RC_FILES if current theme is not Communitheme*
  * Make active button darker
  * Change menu color to be the same as in gtk3
  * Add proper svg image scaling and fix svg opacity
  * Minor format adjustments
  * Remove headerbar and menubar side borders
  * Add solid bg to check and radio
  * Fix glitches in non-s...

Changed in yaru-theme (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers