Comment 31 for bug 215672

Revision history for this message
In , Gavin Sharp (gavin-sharp) wrote :

Comment on attachment 314225
Delay initPrivacyNotice()

You can't go back to the privacy notice pane, so you can just move the call to initPrivacyNotice from the pane's onpageshow to the wizard's onload.

This will fix this specific instance of the bug, but it won't address other users of this widget that might rely on the document being "ready" when the constructor is called. It's hard to know how many potential users like that exist, but it would be nice to not break them... seems like smaug's patch would be better in this regard (although the dialog.xml change looks like it would break dialogs added after the document has loaded - perhaps not an important enough use case that we need to worry about it). I can't really evaluate the riskiness of it, though, so I'll defer to your judgement there.