Ubuntu
xulrunner-1.9 package

  1. Bug #203413
  2. Comment #13

Comment 13 for bug 203413

Revision history for this message
In , Shawn Wilsher (sdwilsh) wrote :

(From update of attachment 305310)
>+ for (PRInt32 i = urisToUnescape.Count(); --i >= 0; ) {
 ug that's a confusing loop

>+ rv = fixURI->BindUTF8StringParameter(0, *urisToUnescape[i]);
>+ NS_ENSURE_SUCCESS(rv, rv);
>+
>+ (void)textToSubURI->UnEscapeURIForUI(charset, *urisToUnescape[i], uriSpec);
>+
>+ rv = fixURI->BindStringParameter(1, uriSpec);
>+ NS_ENSURE_SUCCESS(rv, rv);
>+
>+ rv = fixURI->Execute();
>+ NS_ENSURE_SUCCESS(rv, rv);
I think it'd probably be best here to do
if (NS_FAILED(rv)) continue;

r=sdwilsh for what it's worth