session.sh should not set XDG_CONFIG_DIRS/XDG_DATA_DIRS

Bug #571133 reported by Moritz Heiber
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
xubuntu-default-settings (Ubuntu)
Medium
Lionel Le Folgoc
Lucid
Medium
Unassigned

Bug Description

Binary package hint: xubuntu-default-settings

Using Xubuntu 10.04 LTS, using the latest available xubuntu-default-settings (10.04.7).

session.sh should not set XDG_CONFIG_DIRS nor XDG_DATA_DIRS.

XDG_CONFIG_DIRS is set by /etc/X11/Xsession.d/60xdg_path-on-session and it fails to include /etc/xdg if XDG_CONFIG_DIRS is already set which in turn is doomed to break a lot of applications (ubuntuone-preferences for example).

Also, XDG_DATA_DIRS is set by startxfce4 and shouldn't be messed with at this early stage.

Moritz Heiber (mheiber)
description: updated
Revision history for this message
Lionel Le Folgoc (mrpouit) wrote :

Indeed (as discussed on irc), I'll remove XDG_CONFIG_DIRS, but keep XDG_DATA_DIRS because it has to be set to /etc/xdg/xdg-xubuntu for some xubuntu-specific stuff, e.g. the default apps list (anyway, it is also buggy, cf. Bug #574264).

Changed in xubuntu-default-settings (Ubuntu):
assignee: nobody → Lionel Le Folgoc (mrpouit)
importance: Undecided → High
status: New → Triaged
importance: High → Medium
Changed in xubuntu-default-settings (Ubuntu Lucid):
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Moritz Heiber (mheiber) wrote :

I advise to implement some sort of checking logic for it to not overwrite an already populated XDG_DATA_DIRS variable, if possible and desired.

Revision history for this message
Lionel Le Folgoc (mrpouit) wrote :
Revision history for this message
Lionel Le Folgoc (mrpouit) wrote :

Hello ubuntu-sru,

I would like to SRU that (Bug #571133 and Bug #574264) for lucid, the diff is http://bazaar.launchpad.net/~xubuntu-dev/xubuntu-default-settings/lucid/revision/205
Is it ok with you?

Maverick isn't opened yet, but I can upload if needed...
Thanks!

Revision history for this message
Martin Pitt (pitti) wrote :

See https://bugs.launchpad.net/ubuntu/+source/xubuntu-default-settings/+bug/574264/comments/4

BTW, we can copy lucid-proposed to maverick, so a separate upload isn't necessary.

Revision history for this message
Martin Pitt (pitti) wrote :

Please go ahead and upload.

Revision history for this message
Scott Kitterman (kitterman) wrote : Please test proposed package

Accepted into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in xubuntu-default-settings (Ubuntu Lucid):
status: Triaged → Fix Committed
tags: added: verification-needed
Revision history for this message
Moritz Heiber (mheiber) wrote :

I just tested the new package (Xubuntu 10.04 LTS; xubuntu-default-settings 10.04.8) and it's working as aspected. The one application I mentioned in the report (ubuntuone-preferences) is working flawlessly. From my point of view this bug can be closed as fixed.

Martin Pitt (pitti)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package xubuntu-default-settings - 10.04.8

---------------
xubuntu-default-settings (10.04.8) lucid-proposed; urgency=low

  * usr/share/xubuntu/session.sh:
    - Do not forcefully set $XDG_CONFIG_DIRS, it creates issue with non-Xfce
      applications, and 60xdg_path-on-session from gdm already takes care of
      that. lp: #571133
    - Ensure that /usr/local/share is present in $XDG_DATA_DIRS. lp: #574264
 -- Lionel Le Folgoc <email address hidden> Mon, 03 May 2010 20:15:27 +0200

Changed in xubuntu-default-settings (Ubuntu Lucid):
status: Fix Committed → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote :

Copied to maverick.

Changed in xubuntu-default-settings (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Daniel Richard G. (skunk) wrote :

This change has the unintended effect of neutering the Xubuntu session (i.e. XDG_CONFIG_DIRS doesn't get set, so you get a "stock" Xfce desktop) when xdm is used, because there is no equivalent of 60xdg_path-on-session then. I've filed bug 583634 on this.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers