xtrx-dkms module should not try to build when CONFIG_PPS is disabled
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
xtrx-dkms (Ubuntu) |
Expired
|
Undecided
|
Unassigned | ||
Jammy |
Expired
|
Undecided
|
Unassigned |
Bug Description
SRU justification:
[Impact]
This is encountered on linux kernel derivatives with fewer configuration options enabled.
First time seen on jammy:linux-
During build, it fails with the following error:
...
make -j1 KERNELRELEASE=
Error! Bad return status for module build on kernel: 5.15.0-1030-kvm (x86_64)
Consult /var/lib/
E: xtrx/0.
========== /var/lib/
DKMS make.log for xtrx-0.
Thu Mar 9 00:04:53 UTC 2023
make: Entering directory '/usr/src/
CC [M] /var/lib/
MODPOST /var/lib/
ERROR: modpost: "pps_register_
ERROR: modpost: "pps_event" [/var/lib/
ERROR: modpost: "pps_unregister
make[1]: *** [scripts/
make[1]: *** Deleting file '/var/lib/
make: *** [Makefile:1821: modules] Error 2
make: Leaving directory '/usr/src/
because CONFIG_PPS=n
[Fix]
Add a rule to avoid building xtrx-dkms when CONFIG_PPS=n
[Test Plan]
Install a new version of jammy:linux-kvm (1029 for example).
apt install xtrx-dkms will fail as described above.
After the fix, it will not be built at all.
Once the package is in proposed, a new adt is triggered against proposed for jammy:linux-kvm.
[Where problems could occur]
Low possibility of new issues.
[Note]
This fix is not scalable in the sense that if configuration name changes, the module has to be changed as well.
tags: | added: sru-20230227 |
Proposed fix is attached.
I put the rule in debian/dkms file, not in dkms.conf. dkms.conf is overridden by dkms file I noticed and the change has no affect.
tested on linux-kvm-1029
ubuntu@ jammy-kvm: ~/xtrx$ sudo dpkg -i xtrx-dkms_ 0.0.1+git201903 20.5ae3a3e- 3ubuntu1~ 22.04.2_ all.deb 0.0.1+git201903 20.5ae3a3e- 3ubuntu1~ 22.04.2_ all.deb ... 0.1+git20190320 .5ae3a3e- 3ubuntu1~ 22.04.2 completely from the DKMS tree. git20190320. 5ae3a3e- 3ubuntu1~ 22.04.2) over (0.0.1+ git20190320. 5ae3a3e- 3ubuntu1~ 22.04.2) ... git20190320. 5ae3a3e- 3ubuntu1~ 22.04.2) ... 0.1+git20190320 .5ae3a3e- 3ubuntu1~ 22.04.2 DKMS files... dkms/xtrx/ 0.0.1+git201903 20.5ae3a3e- 3ubuntu1~ 22.04.2/ 5.15.0- 1029-kvm/ x86_64/ dkms.conf for module xtrx includes a BUILD_EXCLUSIVE directive which does not match this kernel/arch.
(Reading database ... 142334 files and directories currently installed.)
Preparing to unpack xtrx-dkms_
Deleting module xtrx-0.
Unpacking xtrx-dkms (0.0.1+
Setting up xtrx-dkms (0.0.1+
Loading new xtrx-0.
Building for 5.15.0-1029-kvm
Building initial module for 5.15.0-1029-kvm
Error! The /var/lib/
This indicates that it should not be built.
Skipped.