NoDRI does not disable DRI

[Tormod Volden]

I put <<Option "NoDRI">> in the device section of xorg.conf. Still, the DRI is loaded and enabled.

[Timo Aaltonen (tjaalton)]

Are you sure that should work? According to man savage(4) there is no such option for it. And in bug #41340 you commented that disablind DRI can be done by removing Load "dri" from the config :)

[Tormod Volden (tormodvolden)]

I think I've read somewhere that NoDRI should apply to all drivers, and if not it should be considered a bug and be fixed... But where? :) Beats me.

[Bugzi09-fdo-tormod (bugzi09-fdo-tormod)]

If I understand Adam Jackson's comment correctly:
http://www.redhat.com/archives/fedora-devel-list/2006-September/msg00593.html
the "NoDRI" option should work for all drivers. It does not work for savage.

[agd5f (agd5f)]

not all drivers have that option. Only radeon (maybe some others). savage does not. You should be able to comment out the load "dri" line in the modules section of your config. that will work for all drivers.

[Bugzi09-fdo-tormod (bugzi09-fdo-tormod)]

From the same thread:
> Is there a way of disabling DRI when there's no 'Load "DRI"' statement
> to remove, as is the case in the new concise xorg.conf files?

Seems like it would be a useful option for some/future xorg.conf structures.

[Daniel Stone (daniels)]

it should definitely have one, though: think of the multi-screen case, or, even better, when we have partial configs fully supported, and so there's no way to disable loading the module ...

relying on the module being loaded is somewhat of a hack. being able to specifically tell the driver for one particular instance that it shouldn't attempt a particular configuration is surely far more sensible.

[Tormod Volden (tormodvolden)]

Yeay, I think I found it:
http://www.redhat.com/archives/fedora-devel-list/2006-September/msg00593.html
I'll try reporting it upstream.

[Bugzi09-fdo-tormod (bugzi09-fdo-tormod)]

Created an attachment (id=10158)
adds a "DRI" (boolean) option for savage

Here is a patch adding support for a "DRI" option. Heavily inspired by Alex' patch from February for the ati driver. Tested and works.

One thing that I am not happy with is that the option here is read out in SavageScreenInit, whereas all other options are dealt with in SavagePreInit. We could set directRenderingEnabled in SavagePreInit depending on the option, and check for this in SavageScreenInit. Would be a bit more intrusive but maybe cleaner.

[Bugzi09-fdo-tormod (bugzi09-fdo-tormod)]

Created an attachment (id=10159)
alternative patch for "DRI" option

This is what I meant.

[agd5f (agd5f)]

committed:
b126b204d3465700e8c6a1fcc4770f322c8bb7db

Thanks!

[Tormod Volden (tormodvolden)]

New "DRI" option included upstream and in 2.1.2-6.