[GNOME3 Staging PPA] strange shadow rendered where client-side decorations are used

Bug #1378188 reported by Erich Eickmeyer 
76
This bug affects 16 people
Affects Status Importance Assigned to Milestone
xserver-xorg-video-intel (Ubuntu)
Fix Released
Medium
Unassigned
Utopic
Fix Released
Undecided
Unassigned
xserver-xorg-video-intel-lts-utopic (Ubuntu)
Invalid
Undecided
Unassigned
Trusty
Fix Released
Undecided
Unassigned

Bug Description

[Impact]
The Intel video driver has a bug that can cause to incorrectly draw certain trapezoids. This is visible when using client side decorations in GNOME 3 (see attached screenshots).

[Test Case]
Run GNOME 3 with client side decorations on Intel hardware.
Observed result:
Shadow under window is missing corners.
Expected result:
Shadow looks correct.

[Regression potential]
Low. The fix is from upstream and just changes the logic error in the CompositeTrapezoids routine.

Revision history for this message
Erich Eickmeyer  (eeickmeyer) wrote :
Revision history for this message
Erich Eickmeyer  (eeickmeyer) wrote :

This shows that I could only duplicate the bug on CSD windows.

Revision history for this message
Tim Lunn (darkxst) wrote :

Erich, the shadows are rendering properly here for CSD apps. You are using the default Adwaita theme?

Revision history for this message
Erich Eickmeyer  (eeickmeyer) wrote :

Yes, using the default Adwaita theme. I even double-checked to make sure the right version was installed.

Revision history for this message
Thomas Beck (coktzct) wrote :

I am now again on Gnome 3.12, Ubuntu 14.10... updated yesterday and experienced exactly the same bug on gnome-tweak-tool.
I had an nvidia proprietary driver running (331) and nvidia-prime.. Theme was Adwaita too.

Revision history for this message
Hồng Quân (ng-hong-quan) wrote :

For me, no shadow at all for CSD app like DevHelp.

Revision history for this message
Dmitry Golovin (cyb3r) wrote :

Installed software from gnome3-staging today, I also have this bug. Non-CSD apps are okay, though.

Revision history for this message
Daniel (findux) wrote :

Johann [https://disqus.com/home/user/disqus_zcqy9N2LgM/] posted a fix on webupd8, that works for me:

---

****SHADOW ON CSD FIX****

The problem is generated by an older intel driver (xserver-xorg-video-intel)

1. Add oibaf ppa: $ sudo add-apt-repository ppa:oibaf/graphics-drivers

2. Update: $ sudo apt-get update

3. Install-update driver: $ sudo apt-get install xserver-xorg-video-intel

4. REMOVE REPOSITORY, -DO NOT- UPDATE YOUR SYSTEM:

$ sudo add-apt-repository -r ppa:oibaf/graphics-drivers

Reboot and be happy.

-------------------------------------------------------------------------------------------------------

(If this make something it shouldnt you can ppa-purge: $ sudo ppa-purge ppa:oibaf/graphics-drivers)

---

Source: http://www.webupd8.org/2014/10/how-to-install-gnome-314-in-ubuntu.html

Revision history for this message
Erich Eickmeyer  (eeickmeyer) wrote :

If Daniel's fix (comment #8) is a workaround, then it's clearly a bug in xserver-xorg-video-intel. Added accordingly. Might be worth including in the Ubuntu GNOME staging ppa.

no longer affects: xserver-xorg-video-intel (Ubuntu)
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Revision history for this message
Christopher M. Peñalver (penalvch) wrote :

Erich Eickmeyer, could you please execute the following at a terminal, as it will automatically gather and attach updated debug information to this report:

apport-collect -p xorg 1378188

Please ensure you have xdiagnose installed, and that you click the Yes button for attaching additional debugging information.

Changed in xorg (Ubuntu):
status: New → Confirmed
affects: ubuntu-gnome → xorg (Ubuntu)
Changed in xorg (Ubuntu):
status: New → Incomplete
importance: Undecided → Low
Revision history for this message
Erich Eickmeyer  (eeickmeyer) wrote : BootDmesg.txt

apport information

tags: added: apport-collected ubuntu
description: updated
Revision history for this message
Erich Eickmeyer  (eeickmeyer) wrote : BootLog.txt

apport information

Revision history for this message
Erich Eickmeyer  (eeickmeyer) wrote : CurrentDmesg.txt

apport information

Revision history for this message
Erich Eickmeyer  (eeickmeyer) wrote : Dependencies.txt

apport information

Revision history for this message
Erich Eickmeyer  (eeickmeyer) wrote : DpkgLog.txt

apport information

Revision history for this message
Erich Eickmeyer  (eeickmeyer) wrote : Lspci.txt

apport information

Revision history for this message
Erich Eickmeyer  (eeickmeyer) wrote : Lsusb.txt

apport information

Revision history for this message
Erich Eickmeyer  (eeickmeyer) wrote : MonitorsUser.xml.txt

apport information

Revision history for this message
Erich Eickmeyer  (eeickmeyer) wrote : ProcCpuinfo.txt

apport information

Revision history for this message
Erich Eickmeyer  (eeickmeyer) wrote : ProcInterrupts.txt

apport information

Revision history for this message
Erich Eickmeyer  (eeickmeyer) wrote : ProcModules.txt

apport information

Revision history for this message
Erich Eickmeyer  (eeickmeyer) wrote : UdevDb.txt

apport information

Revision history for this message
Erich Eickmeyer  (eeickmeyer) wrote : UdevLog.txt

apport information

Revision history for this message
Erich Eickmeyer  (eeickmeyer) wrote : XorgLog.txt

apport information

Revision history for this message
Erich Eickmeyer  (eeickmeyer) wrote : XorgLogOld.txt

apport information

Revision history for this message
Erich Eickmeyer  (eeickmeyer) wrote : Xrandr.txt

apport information

Revision history for this message
Erich Eickmeyer  (eeickmeyer) wrote : xdpyinfo.txt

apport information

Revision history for this message
Erich Eickmeyer  (eeickmeyer) wrote : xserver.devices.txt

apport information

tags: added: bios-outdated-2.11
tags: added: latest-bios-2.11
removed: bios-outdated-2.11
Revision history for this message
Christopher M. Peñalver (penalvch) wrote : Re: strange shadow rendered where client-side decorations are used

Erich Eickmeyer, if you restore gnome to the default repository version (i.e. remove the GNOME3 PPA), and remove the following non-default kernel parameters is this reproducible in Utopic:
acpi_osi=Linux i915.invert_brightness=1

If so, to see if this is already fixed for your hardware could you please http://cdimage.ubuntu.com/daily-live/current/ (live environment is fine if the problem was also reproducible in a live environment) and advise if this is reproducible?

Revision history for this message
Erich Eickmeyer  (eeickmeyer) wrote :

Christopher M. Penalver, it is not reproducible if removing the GNOME3 PPA which is what causes this bug to appear to begin with. Also, my machine requires those kernel prarameters to function correctly with the backlight, but removing them has no effect except inverting my backlight controls (0%=100%, etc.). That said, if one is to follow the workaround in comment #8 above, the problem does go away.

Therefore, I have reason to believe the shadow rendering bug is in xserver-xorg-video-intel in the repos being an old version. If one were to backport the newer version, I have reason to believe the bug will be fixed. This is why I initially filed the bug agains the GNOME3 PPA and then later xserver-xorg-video-intel and not xorg itself since it's a single package causing the bug.

I have not tested the newer xserver-xorg-video-intel driver in other DEs, but would be happy to do so.

summary: - strange shadow rendered where client-side decorations are used
+ [GNOME3 PPA] strange shadow rendered where client-side decorations are
+ used
Revision history for this message
Christopher M. Peñalver (penalvch) wrote :

Erick Eickmeyer, if the issue goes away for you and your hardware by removing the GNOME3 PPA then this would want to be reviewed as a regression in GNOME3. -> gdm (Ubuntu)

I'll let the GNOME3 triager/developer assign it a more appropriate GNOME3 package if applicable.

description: updated
summary: - [GNOME3 PPA] strange shadow rendered where client-side decorations are
- used
+ [GNOME3 Staging PPA] strange shadow rendered where client-side
+ decorations are used
description: updated
affects: xorg (Ubuntu) → gdm (Ubuntu)
Changed in gdm (Ubuntu):
status: Incomplete → New
Revision history for this message
Tim Lunn (darkxst) wrote :

This is a bug in the intel xorg driver that is triggered by Gtk 3.14, which will be landing in vivid very soon.

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in xserver-xorg-video-intel (Ubuntu):
status: New → Confirmed
Tim Lunn (darkxst)
affects: gdm (Ubuntu) → xserver-xorg-video-intel (Ubuntu)
Revision history for this message
Christopher M. Peñalver (penalvch) wrote :

Tim, thanks for the comment. Would you happen to know either the specific fix or offending commit regarding this issue?

Revision history for this message
Erich Eickmeyer  (eeickmeyer) wrote :

Just of note (not sure if this helps), but I also found that the xserver-xorg-video-intel driver from the oibaf/graphics-drivers PPA also fixed an issue I was having with waking the monitor up from standby or sleep on my machine. Before it was freezing and I'd have to either reboot or run 'sudo service lightdm restart' to fix the problem. Now, there's no issue.

So, it seems that the shadow bug triggered by GTK 3.14 and the wake from sleep issue were both corrected by the driver in that PPA, and not having to update all of xorg.

Sadly, I cannot point to a specific commit at this time, but I might be up for bisecting the driver.

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in xserver-xorg-video-intel (Ubuntu):
status: New → Confirmed
Revision history for this message
Tim Lunn (darkxst) wrote :

Christoper, sorry I don't know the specific commit, All I know is I have heard many reports that it is fixed intel 2.99.916

Revision history for this message
Marius Gedminas (mgedmin) wrote :

Link to Fedora bug: https://bugzilla.redhat.com/show_bug.cgi?id=1133142

They had the bug in xorg-x11-drv-intel-2.99.914-2.fc21.x86_64 and included the fix in xorg-x11-drv-intel-2.99.914-3.fc21. If I were more familiar with Fedora's infrastructure I'm sure I could find the patch with the backported fix and maybe even identify the upstream commit.

Revision history for this message
Marius Gedminas (mgedmin) wrote :

Ok, I found where to download the .src.rpm's for the two Fedora packages and compare the included patches.

This bug is fixed by upstream commit 48a33fc379b17eed195875222ad773c911d9dff1:
http://cgit.freedesktop.org/xorg/driver/xf86-video-intel/commit/?id=48a33fc379b17eed195875222ad773c911d9dff1

Revision history for this message
Marius Gedminas (mgedmin) wrote :

This ought to be fixed in vivid, starting with 2:2.99.916+git20141119-1~exp1ubuntu1 that was uploaded on 12 Dec 2014. Can anyone verify?

I'm currently trying to backport the patch to utopic.

Revision history for this message
Marius Gedminas (mgedmin) wrote :

I've backported the upstream patch to the xserver-xorg-video-intel package from utopic-updates and can confirm that it fixes the broken window shadows for GTK+ 3.14 apps that use client decorations (e.g. gedit).

Revision history for this message
Marius Gedminas (mgedmin) wrote :

<a href="https://launchpad.net/~mgedmin/+archive/ubuntu/ppa">ppa:mgedmin/ppa</a> has a patched xserver-xorg-video-intel that fixes this for Utopic users.

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "debdiff against utopic package" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Changed in xserver-xorg-video-intel (Ubuntu):
status: Confirmed → Triaged
importance: Low → Medium
description: updated
Revision history for this message
Robert Ancell (robert-ancell) wrote :

The patch looks good to me and the package builds fine. I haven't uploaded since there's currently 2:2.99.914-1~exp1ubuntu4.2 waiting for verification in utopic-proposed.

Revision history for this message
Marius Gedminas (mgedmin) wrote :

I built a patched 2:2.99.914-1~exp1ubuntu4.2mg1 (debdiff applied fine, except for the debian/changelog bits) and uploaded it to my ppa (ppa:mgedmin/ppa). I'm currently running it: shadows are fine.

Revision history for this message
Iain Lane (laney) wrote :

Thanks, I uploaded it to utopic-proposed.

There's another SRU (4.3) still awaiting verification, but tjaalton tells me that it is fine. If you're an SRU team member reviewing this upload and he hasn't fixed the tags yet, please poke him hard and then you should be able to release that one and upload this.

Changed in xserver-xorg-video-intel (Ubuntu):
status: Triaged → Fix Released
Changed in xserver-xorg-video-intel (Ubuntu Utopic):
status: New → In Progress
assignee: nobody → Marius Gedminas (mgedmin)
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Erich, or anyone else affected,

Accepted xserver-xorg-video-intel into utopic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/xserver-xorg-video-intel/2:2.99.914-1~exp1ubuntu4.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in xserver-xorg-video-intel (Ubuntu Utopic):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Marius Gedminas (mgedmin) wrote :

I've already upgraded to vivid so won't be able to do the verification.

Changed in xserver-xorg-video-intel (Ubuntu Utopic):
assignee: Marius Gedminas (mgedmin) → nobody
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

Erich, please test the proposed package, it's blocking other updates from entering the repo

Revision history for this message
Erich Eickmeyer  (eeickmeyer) wrote :

I can confirm the package fixes the bug.

Robert Hooker (sarvatt)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

great, thanks!

no longer affects: xserver-xorg-video-intel-lts-utopic (Ubuntu Utopic)
no longer affects: xserver-xorg-video-intel (Ubuntu Trusty)
Changed in xserver-xorg-video-intel-lts-utopic (Ubuntu):
status: New → Invalid
tags: added: verification-done-utopic
removed: verification-done
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package xserver-xorg-video-intel - 2:2.99.914-1~exp1ubuntu4.4

---------------
xserver-xorg-video-intel (2:2.99.914-1~exp1ubuntu4.4) utopic; urgency=medium

  * fix-sna-trapezoids.patch: Fix client-side shadows for GTK+ 3.14
    (LP: #1378188).

 -- Marius Gedminas <email address hidden> Tue, 05 May 2015 11:25:15 +0100

Changed in xserver-xorg-video-intel (Ubuntu Utopic):
status: Fix Committed → Fix Released
Revision history for this message
Chris J Arges (arges) wrote : Update Released

The verification of the Stable Release Update for xserver-xorg-video-intel has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Hello Erich, or anyone else affected,

Accepted xserver-xorg-video-intel-lts-utopic into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/xserver-xorg-video-intel-lts-utopic/2:2.99.914-1~exp1ubuntu4.5~trusty1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in xserver-xorg-video-intel-lts-utopic (Ubuntu Trusty):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Erich Eickmeyer  (eeickmeyer) wrote :

Martin,

At this point I am unable to test the package since I have upgraded my system to vivid, and with utopic EOL in less than a month, I am not sure it's worth the effort to install utopic to test. I'm sorry!

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package xserver-xorg-video-intel-lts-utopic - 2:2.99.914-1~exp1ubuntu4.5~trusty1

---------------
xserver-xorg-video-intel-lts-utopic (2:2.99.914-1~exp1ubuntu4.5~trusty1) trusty; urgency=medium

  * Backport utopic package for lts-utopic stack.

 -- Timo Aaltonen <email address hidden> Mon, 11 May 2015 14:35:11 +0300

Changed in xserver-xorg-video-intel-lts-utopic (Ubuntu Trusty):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.