Properly fix dithering problems
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
xserver-xorg-video-ati (Ubuntu) |
Fix Released
|
High
|
Bryce Harrington | ||
Intrepid |
Fix Released
|
High
|
Unassigned |
Bug Description
[Justification]
During Intrepid development, we worked with upstream to develop two patches to work around banding issues on certain classes of hardware. Upstream has carried on this development work and corrected several flaws that were subsequently found in our patches (including regression bug #274234).
[Development]
Upstream's git tree contains the fixes for this. We will be pulling them in when we next update our git snapshot and will be included in the next -ati release.
[Patch]
debdiff of changes cherrypicked from upstream git is attached below.
In the development of our original fixes, we had found it difficult to insert our fixes due to the way the code was organized. To correct this, upstream restructured the code that handles dithering. This is why the patch is quite a bit larger than our original patches.
[Test Case]
On some HD 2600 hardware, booting up into X results in an X failure with the following error message in Xorg.0.log:
(EE) RADEON(0): ParseTable said: CD_INVALID_OPCODE
[Regression Potential]
The size of this patch alone suggests that regression potential is a concern. A code review did not turn up any obvious flaws, and preliminary testing by myself (and others who have tested snapshots of the upstream code) shows it to be safe. However, I think this should be kept in -proposed for at least a couple weeks. I'd like to see it tested across a wider range of ATI hardware.
[Original Report]
Currently the xserver-
* RV530 on MacBook Pro
+ bug #264535
+ https:/
+ the current upstream fix has the following advantages over current ubuntu 103_rv530_
- it fixes completely the problem (the ubuntu patch still leaves some banding);
- it is targetting only RV530 on MacBook Pro (where there is the dithering problem), not all RV530;
- it makes the 103_rv530_
+ I tested current git version and noticed no regression so far
* RV6xx/RV7xx cards:
+ https:/
+ current git version should also fix this problem in a similar way, though I don't own this hardware to test; it should have the following advantages:
- it should fix completely the problem (the ubuntu patch appears to leave some banding);
- it has a more general approach targetting not only specified cards;
- it makes the 101_rv635_
Current git version (2008-10-15 commit 435cf7da68186f2
- 8 commits related to the dithering problems;
- 1 cleanup commit renaming some function;
I suggest to update the ubuntu version to current git to properly fix the dithering problems.
Test packages provided by Tormod Volden can be found at:
https:/
Changed in xserver-xorg-video-ati: | |
status: | Incomplete → New |
Changed in xserver-xorg-video-ati: | |
status: | Triaged → In Progress |
description: | updated |
Hi fabio-pedretti,
Please attach the output of `lspci -vvnn`, and attach your /var/log/Xorg.0.log file from after reproducing this issue. If you've made any customizations to your /etc/X11/xorg.conf please attach that as well.