2011-10-19 00:35:35 |
Chase Douglas |
bug |
|
|
added bug |
2011-10-19 00:48:47 |
Chase Douglas |
description |
There is a null pointer dereference that occurs when accepting a grabbed touch from a touchpad. |
SRU Justification:
==================
[Impact]
There are no known users of touch grabs in the Oneiric archives. However, development of the new uTouch architecture depends on touch grabs. This bug needs to be fixed as an SRU so further development can take place on Oneiric.
[Development Fix]
This issue will not be fixed in precise because the multitouch code will be different there.
[Stable Fix]
See attached patch. Note that the 'if' statement clause that is just above the patch is "if (first)". The fix is pretty obvious.
[Test Case]
There is not an obvious test case because nothing in the archive tests this functionality. Adventurous testers can checkout the following branches:
lp:~chasedouglas/utouch-frame/v2
lp:~chasedouglas/utouch-grail/rework
Build them sequentially, then run "tools/grail-test-propagation <root window ID>" from the utouch-grail branch. Perform any two touch gesture from a multitouch trackpad (currently limited to Apple trackpads). The server will crash immediately.
[Regression Potential]
Minimal. The fix is an obvious code path issue that can be trivially "proven". It also will not affect anyone on non-multitouch hardware. |
|
2011-10-19 00:49:40 |
Chase Douglas |
attachment added |
|
510_fix_touchpad_touch_event_removal.patch https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/877825/+attachment/2559081/+files/510_fix_touchpad_touch_event_removal.patch |
|
2011-10-19 00:49:57 |
Chase Douglas |
nominated for series |
|
Ubuntu Oneiric |
|
2011-10-19 00:49:57 |
Chase Douglas |
bug task added |
|
xorg-server (Ubuntu Oneiric) |
|
2011-10-19 00:50:04 |
Chase Douglas |
xorg-server (Ubuntu): status |
New |
Won't Fix |
|
2011-10-19 00:50:15 |
Chase Douglas |
xorg-server (Ubuntu Oneiric): assignee |
|
Chase Douglas (chasedouglas) |
|
2011-10-19 00:50:19 |
Chase Douglas |
xorg-server (Ubuntu Oneiric): importance |
Undecided |
Medium |
|
2011-10-19 00:50:23 |
Chase Douglas |
xorg-server (Ubuntu Oneiric): milestone |
|
oneiric-updates |
|
2011-10-19 00:50:32 |
Chase Douglas |
xorg-server (Ubuntu Oneiric): status |
New |
In Progress |
|
2011-10-19 01:07:33 |
Chase Douglas |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
2011-10-19 01:08:36 |
Chase Douglas |
xorg-server (Ubuntu Oneiric): status |
In Progress |
Fix Committed |
|
2011-10-19 05:01:01 |
Martin Pitt |
bug |
|
|
added subscriber SRU Verification |
2011-10-19 05:01:02 |
Martin Pitt |
tags |
|
verification-needed |
|
2011-10-20 06:06:59 |
Martin Pitt |
tags |
verification-needed |
verification-done |
|
2011-10-20 18:28:25 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/oneiric-proposed/xorg-server |
|
2011-10-27 04:19:35 |
Launchpad Janitor |
xorg-server (Ubuntu Oneiric): status |
Fix Committed |
Fix Released |
|
2012-01-05 03:23:41 |
Rex Tsai |
bug |
|
|
added subscriber Rex Tsai |
2012-02-06 12:33:12 |
Alexander |
bug |
|
|
added subscriber Alexander |