FFe: xserver 1.19.3

Bug #1671799 reported by Timo Aaltonen
42
This bug affects 8 people
Affects Status Importance Assigned to Milestone
xorg-server (Ubuntu)
Fix Released
Undecided
Timo Aaltonen

Bug Description

xserver 1.19 has been out for quite some time now. Debian Stretch will release with it, and xmir has been recently ported so we can push 1.19 to zesty now. It's currently being staged on a ppa:

https://launchpad.net/~canonical-x/+archive/ubuntu/x-staging

The main features of this release are:
- PRIME synchronization support, should reduce tearing on hybrid setups
- GLAMOR (2D accel over OpenGL) improvements
- threaded input

This bugreport is also for gathering testing feedback.

Tested to be working fine on:
- Intel Kabylake
- Intel Broadwell
- Intel+NVIDIA hybrid (Skylake + 930MX, with OSS and blob drivers)
- Intel+NVIDIA hybrid (Haswell + NVIDIA GK107M [GeForce GT 755M])
- Intel+NVIDIA hybrid (Ivybridge + NVIDIA GK107M [GeForce GT 660M])
- Radeon SI (radeon & amdgpu drivers)
- qemu (QXL)

CVE References

Revision history for this message
dino99 (9d9) wrote :

Feedback on ZZ 64 bits, unity 7 session, nv117 (gtx750) card , after mesa/xserver upgrades

- upgrade goes well (wine-devel removed due to libglu dependency)
- after reboot: numpad is deactivated and cant be activated at login level; after the session is opened, numlock is on and cant be set off.
- journalctl is fine, except that compiz has many warnings/errors (log joined to let you know, but it seems a compiz needed upgrade to be happy with mesa/xserver)

Revision history for this message
iLogin (cerebellum-l) wrote :

also stopped working Caps Lock... when press the Caps Lock, most combinations not working at all.

Revision history for this message
dino99 (9d9) wrote :

Also problem scrolling with chromium-browser and calc: does not work.
If caps-lock status is not modified by the user, then the keyboard can be used as expected; otherwise, keyboard's language is lost and typing is a nightmare: no arrows, no erase back, ...

Revision history for this message
dino99 (9d9) wrote :

If xserver is downgraded to the previous 1.18.4 version, and rebooted, then there is no warning/error logged about compiz.

Revision history for this message
iLogin (cerebellum-l) wrote :

you may need to update this patch?
208_switch_on_release.diff
https://bugs.freedesktop.org/show_bug.cgi?id=865#c142

Revision history for this message
iLogin (cerebellum-l) wrote :

Without this patch my keyboard works.

Revision history for this message
Timo Aaltonen (tjaalton) wrote :

Thanks for testing! Indeed, I had not tested it properly, since I could reproduce the bug.. Dropped the patch and pushed to the ppa, now caps-lock etc works fine

Revision history for this message
dino99 (9d9) wrote :

Now its fine here too with 1.19.2-1ubuntu2 version:
- no more keyboard issue
- no more scrolling issue
- no more compiz issue

Thanks for the quick upgrade.

Revision history for this message
Doug McMahon (mc3man) wrote :

Here with fresh 17.04 Ubuntu install using today's image -
After adding ppa & upgrading a reboot goes to low graphics screen.
This is on a Lenovo IdeaPad Y510P, nvidia drivers not installed.
Logs seem unremarkable, only way to boot to ubuntu session is thru recovery (nomodeset

Revision history for this message
Doug McMahon (mc3man) wrote :

Same thing with a lenovo IdeaPad Y580 (sandybridge) except there it doesn't even make it the low graphic pop up.

In both cases (sandybridge & previous laptop which is haswell) if I install the nvidia drivers & reboot, it does boot up to an ubuntu session. From there switching via prime profiles to intel gpu works & survives a reboot.
So the issue is on an upgrade of xserver while on the Intel iGPU, maybe how alternatives are set?

Also to report that when the nvidia drivers are used via nvidia-prime the current lack of any vsync is Not solved at all.. ( logs look good for prime synchronization, just doesn't work.

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in xorg-server (Ubuntu):
status: New → Confirmed
Revision history for this message
Removed by request (removed3338318) wrote :

Tested on Lenovo Yoga 20FY that has an Optimus setup (Intel HD 520 and Nvidia 540M Card).
Used Ubuntu 17.04 daily and added PPA: https://launchpad.net/~canonical-x/+archive/ubuntu/x-staging.

Test 1 - No restricted/closed drivers
Upgrade worked with no packages broken, etc.. Unfortunately, Ubuntu will not boot after doing this and just hangs forever.

Test 2 - Enable restricted/closed NVidia driver (and Intel microcode if it matters) BEFORE PPA
Upgrade worked with no packages broken, etc.. Ubuntu was able to boot and I was able to login. There didn't seem to be any obvious problems with the graphics stack at this point.

Revision history for this message
Timo Aaltonen (tjaalton) wrote :

Hangs how? This stack has been in debian for some time now, so I believe it's your hybrid configuration that is somehow busted.

Revision history for this message
Doug McMahon (mc3man) wrote :

Pretty simple here -
Will only successfully boot to greeter, ect. when nvidia drivers are installed.
If the drivers aren't installed then it either 'hangs' right after the fs check on sandybridge or goes to low graphics pop up on haswell.

Once the nvidia drivers are installed then boot ups work fine whether using either nvidia or intel. (as picked thru prime profiles or prime-select.

If the nvidia drivers are removed then again boot up fails so something is certainly amiss on your or Ubuntu's end.

Revision history for this message
dino99 (9d9) wrote :
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

I can repro that bug! Related to offload gpu autobinding..

Revision history for this message
Timo Aaltonen (tjaalton) wrote :

1.19.3-1u0.1 uploaded, please test

Revision history for this message
Doug McMahon (mc3man) wrote : Re: [Bug 1671799] Re: FFe: xserver 1.19.x

On 03/16/2017 07:20 AM, Timo Aaltonen wrote:
> 1.19.3-1u0.1 uploaded, please test
>
Does indeed resolve issue when nvidia drivers are not installed.

(out of the scope of this FFe, many optimus users will be expecting
prime synchronization to work. At least here it doesn't when using
nvidia drivers via nvidia-prime.

Is this worth a new bug once 1.19.x releases to 17.04?

Timo Aaltonen (tjaalton)
description: updated
Revision history for this message
dino99 (9d9) wrote : Re: FFe: xserver 1.19.x

Have upgraded and made a reboot: works fine and log clean too on the system described previously.

Revision history for this message
Timo Aaltonen (tjaalton) wrote : Re: [Ubuntu-x-swat] [Bug 1671799] Re: FFe: xserver 1.19.x

On 16.03.2017 14:04, Doug McMahon wrote:
> On 03/16/2017 07:20 AM, Timo Aaltonen wrote:
>> 1.19.3-1u0.1 uploaded, please test
>>
> Does indeed resolve issue when nvidia drivers are not installed.

Yes, I've verified it myself.

> (out of the scope of this FFe, many optimus users will be expecting
> prime synchronization to work. At least here it doesn't when using
> nvidia drivers via nvidia-prime.
>
> Is this worth a new bug once 1.19.x releases to 17.04?

I heard that it was discussed on the nvidia forums to be due to 4.10
kernel, so yes a new bug would be in order.

Timo Aaltonen (tjaalton)
description: updated
Timo Aaltonen (tjaalton)
Changed in xorg-server (Ubuntu):
assignee: nobody → Timo Aaltonen (tjaalton)
Revision history for this message
Doug McMahon (mc3man) wrote : Re: FFe: xserver 1.19.x

Seems ok on both
Intel+NVIDIA hybrid Haswell + NVIDIA GK107M [GeForce GT 755M]
Intel+NVIDIA hybrid Ivybridge + NVIDIA GK107M [GeForce GT 660M]

Though both show an oddity in inxi reporting when on Intel with nvidia drivers not installed -
Ex.,
intel xserver not installed, no nvidia drivers installed, with the apparent Ubuntu default of DRI2 only

$ inxi -G
Graphics: Card-1: Intel 4th Gen Core Processor Integrated Graphics Controller
           Card-2: NVIDIA GK107M [GeForce GT 755M]
           Display Server: X.Org 1.19.3 drivers: (unloaded: fbdev,vesa) FAILED: modesetting,nouveau
           Resolution: 1920x1080@59.91hz
           GLX Renderer: Mesa DRI Intel Haswell Mobile
           GLX Version: 3.0 Mesa 17.0.1

The same is reported if intel xserver package is installed.

If nvidia drivers are installed -

intel xserver not installed, nvidia installed, DRI2
$ inxi -G
Graphics: Card-1: Intel 4th Gen Core Processor Integrated Graphics Controller
           Card-2: NVIDIA GK107M [GeForce GT 755M]
           Display Server: X.Org 1.19.3 drivers: modesetting (unloaded: fbdev,vesa)
           Resolution: 1920x1080@59.91hz
           GLX Renderer: Mesa DRI Intel Haswell Mobile
           GLX Version: 3.0 Mesa 17.0.1
inxi -G
Graphics: Card-1: Intel 4th Gen Core Processor Integrated Graphics Controller
           Card-2: NVIDIA GK107M [GeForce GT 755M]
           Display Server: X.Org 1.19.3 drivers: modesetting (unloaded: fbdev,vesa)
           Resolution: 1920x1080@59.91hz
           GLX Renderer: Mesa DRI Intel Haswell Mobile
           GLX Version: 3.0 Mesa 17.0.1

The same is reported if intel xserver package is installed.

If I was to enable DRI3 then more expected? reporting, doesn't matter if nvidia drivers are installed or not.

intel xserver installed, DRI3
$ inxi -G
Graphics: Card-1: Intel 4th Gen Core Processor Integrated Graphics Controller
           Card-2: NVIDIA GK107M [GeForce GT 755M]
           Display Server: X.Org 1.19.3 driver: intel
           Resolution: 1920x1080@59.91hz
           GLX Renderer: Mesa DRI Intel Haswell Mobile
           GLX Version: 3.0 Mesa 17.0.1

no intel xserver, DRI3
$ inxi -G
Graphics: Card-1: Intel 4th Gen Core Processor Integrated Graphics Controller
           Card-2: NVIDIA GK107M [GeForce GT 755M]
           Display Server: X.Org 1.19.3 drivers: modesetting,nouveau (unloaded: fbdev,vesa)
           Resolution: 1920x1080@59.91hz
           GLX Renderer: Mesa DRI Intel Haswell Mobile
           GLX Version: 3.0 Mesa 17.0.1

Revision history for this message
Timo Aaltonen (tjaalton) wrote :

sounds like an inxi bug then.. note that modesetting uses DRI3 by default

Timo Aaltonen (tjaalton)
description: updated
summary: - FFe: xserver 1.19.x
+ FFe: xserver 1.19.3
Revision history for this message
dino99 (9d9) wrote :

Problem found:

its about using mouse: selecting columns & raws with libreoffice calc.

results are erratic:
- sometime that works as expected (less than half time)
- most of the time when you first click on a cell then move the mouse to the other cell at the end of the wanted selection, here start the erratic results: either lost the already selected cells before the selection is completed done, or start moving the first part of the selection, or if all the selection can be done and you release the mouse click, then either you completly lost the selection or only a part of that selection is still active.

Well its fully not usable; this have been met with several opened gnome-shell sessions from the past days.

To compare, on the same machine but with a zz partition which still use the xserver 1.18 version (fully updated genuine zz) and the same spreadsheet:
- doing a cells selection always works as expected
- the selection is never lost/moved/...
- doing the selection let a better feeling of mouse fluidity.

So something still need to be investigated about how the mouse works. (seems a sensitivity issue)

Revision history for this message
Timo Aaltonen (tjaalton) wrote :

assuming you're using the -libinput driver; please build the ppa version (0.25.0) on zesty or the zesty version against 1.19 and try again

Revision history for this message
dino99 (9d9) wrote :

Thanks for the answer

i have libinput10 & bin 1.6.3-1ubuntu1 installed like all ZZ default installs.
I'm not sure what exactly doing to have compatible version installed.
So i propose to wait until this recompilation is done by default on ZZ archive

Revision history for this message
dino99 (9d9) wrote :

note: the package xserver-xorg-input-libinput 0.23.0-2 is not installed; does it should ?

as the meta package (input-all) is also not installed, the above one has not been requested by an other one.
So i install it, and will test it tomorrow; will report here in the coming 12 hours or so to let you know about the possible result change.

Revision history for this message
Timo Aaltonen (tjaalton) wrote :

By mouse do you mean touchpad or an actual mouse? Touchpads use -synaptics which got bumped to 1.9.0. Test a real mouse too if not already.

Revision history for this message
Timo Aaltonen (tjaalton) wrote :

fwiw, I can't repro that bug on a touchpad using -libinput (synaptics doesn't work right with it)

Revision history for this message
dino99 (9d9) wrote :

Made some tests, with both xserver 18 & with/without input-libinput 23 ; and xserver 19 with/without input-libinput 25

To clarify 'mouse': it's a generic usb mouse, no touchpad at all. Tests made on two different ZZ partitions on the same desktop.

Test xserver 18
- note that comment #26 above is a bit confusing: i was talking about the partition using xserver 18
- xserver 18 without input-libinput 23: works well (as previouly said (#23)
- xserver 18 + input-libinput 23: no problem to select a range of calc's cells; but discovered an other 'scrolling' issue when trying to set the 'sort criteria' for keys: scrolling does not work.
That is when using Calc sorting; testing 'scrolling' inside 'nautilus' works well (confusing).
So i purge input-libinput hoping to get back a normal calc's sorting scrolling; that fails; closing calc / restating gnome-shell session / even logout/in the session does not set scrolling back (confusion again); Check System settings mouse options /gnome-tweak-tool but settings are as usual.

- xserver 19 + input-libinput 25 : problem initialy reported
- xserver 19 without input-libinput 25 (23 not installable due to abi, so cant test that case): selecting a cells range can be done as expected, scrolling for sorting also works !!!

Revision history for this message
dino99 (9d9) wrote :

This scrolling issue has been met also outside the ubuntu world:
https://ubuntuforums.org/showthread.php?t=2355713&p=13622468#post13622468

Revision history for this message
Timo Aaltonen (tjaalton) wrote :

-libinput has been the default since 16.10 where it replaced -evdev (-input-all pulls -libinput), so I don't consider this a blocker, since it doesn't seem to be a widespread issue (I can't reproduce it with a mouse either). Feel free to file a bug against -libinput, upstream too if you can.

Timo Aaltonen (tjaalton)
description: updated
Revision history for this message
Doug McMahon (mc3man) wrote :

Ot to FFe
Bug filed regarding PRIME synchronization with hybrid hardware implemented via nvidia-prime
Bug 1674304

Revision history for this message
Dave Morley (davmor2) wrote :

Tested this on several machines
Intel, trackpad, keybaord, touchscreen, 4k on xps13
Amd, usb keyboard/mouse, 1080p on Home built all amd box
Nvidia, ps2 keybaord/mouse, 1080p on home built mixed box

Revision history for this message
Dave Morley (davmor2) wrote :

All tests on zesty plus ppa

Revision history for this message
Dave Morley (davmor2) wrote :

No issues discovered

Revision history for this message
Iain Lane (laney) wrote :

I'm really worried about doing this so late.

But if you're willing to take the risk, if you will keep a close eye on incoming bug reports & errors.ubuntu.com and if you will upload very soon, go ahead.

Revision history for this message
Timo Aaltonen (tjaalton) wrote :

So this is being blocked by onscripter autopkgtests failing on qemu. Notes so far

- happens only with qemu
- test fails only if Xvfb was started from the same shell (as is the case with xvfb-run)
  - test runs fine if Xvfb was started from another shell..
  - trying to strace the test makes it pass..
- happens on Debian too
- tried reverting randr support from Xvfb, didn't help
- remaining two commits to it were for server internal abi changes, can't revert those

Revision history for this message
Sampo Savola (samposavola) wrote :

Any news on this, will it make it to the release? IMHO this is very important to be included.
Is there somewhere a test image or instructions how to test?

Thanks

Revision history for this message
Timo Aaltonen (tjaalton) wrote :

something in 1.19 makes SDL video init unreliable, causing onscripter autopkgtest to fail when run on qemu.. this issue is now monitored on bug 1679209

Revision history for this message
Joseph Yasi (joe-yasi) wrote :

Any reason libx11 wasn't bumped for zesty this? 1.6.4 has some security fixes.

Revision history for this message
Tim Richardson (tim-richardson) wrote :

I've been testing 1.19.x in 17.04 pre-release for a few weeks, hoping to take advantage of the Nvidia PRIME synchronisation fix for laptops with Optimus hybrid graphics. As of 1.19.3, PRIME sync works (with a modprobe fix related to the nvidia driver). This is a huge improvement for nvidia Optimus users (i.e. most high-end laptops I suspect), since it means no more screen tearing on the laptop's LCD panel when hybrid graphics mode is activated. My testing has been on a Thinkpad P50. Really hope 1.19 gets into 17.04, and then into 16.04.3

Revision history for this message
Timo Aaltonen (tjaalton) wrote :

libx11 is unrelated to this FFE and can be updated independently

Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (5.1 KiB)

This bug was fixed in the package xorg-server - 2:1.19.3-1ubuntu1

---------------
xorg-server (2:1.19.3-1ubuntu1) zesty; urgency=medium

  [ Timo Aaltonen ]
  * Merge from Debian experimental. (LP: #1671799)
    - Patches refreshed
    - randr-adjust-masters-last-set-time.diff,
      modesetting-unifdef-slave-support.diff: Dropped, upstream
    - config-add-no-removal.patch, xf86-inactive-gpuscreen.patch,
      fix-detach-gpu.patch: Dropped, more or less obsolete
  * 190_cache-xkbcomp_output_for_fast_start_up.patch: Cleaned up from
    the package as it wasn't used.
  * 111_armel-drv-fallbacks.patch: Dropped, we don't ship these drivers
    anymore.
  * rules: Drop the workaround that adds lt_cv_prog_compiler_static_works=no
    to confflags.
  * 232-xf86compatoutput-valgrind.patch: This was added upstream
    already, no need to carry a duplicate check.
  * 208_switch_on_release.diff: Dropped, doesn't work with 1.19.
  * 228_autobind_gpu.patch: Update from Fedora, fixes nvidia.
  * disable-rotation-transform-gpuscreens.patch: Dropped, nvidia
    supports rotation now.
  * 122_xext_fix_card32_overflow_in_xauth.patch: Dropped, upstream
    review found issues and it never got applied.
  * xfree86-no-xv-for-gpuscreens.patch: Drop bogus buglink.
  * 227_null_ptr_midispcur.patch: Dropped, upstream didn't accept it.
  * randr-do-not-check-the-screen-size.diff: Dropped, can't reproduce
    #1586260 anymore without the patch.

  [ Robert Ancell ]
  * debian/patches/xmir.patch:
    - Refresh
    - Fix warnings when built against lp:mir/0.25
    - Support both Mir 0.24, 0.25 and 0.26 client APIs
    - Fix crashing on arm64 (LP: #1642297)

xorg-server (2:1.19.3-1) unstable; urgency=medium

  * New upstream release.

xorg-server (2:1.19.2-1) unstable; urgency=medium

  [ Andreas Boll ]
  * xserver-xorg-core.bug.script: Change udevadm path from /sbin to /bin
    (Closes: #852584).

  [ Emilio Pozuelo Monfort ]
  * New upstream stable release.
    - CVE-2017-2624: Timing attack against MIT cookie. Closes: #856398.
  * control: Build-depend on libbsd-dev everywhere, needed for
    arc4random_buf for the above fix.

xorg-server (2:1.19.1-4) unstable; urgency=medium

  * rules: Only set the suid bit on Xorg.wrap when building arch:any
    packages. Thanks Julien Cristau.

xorg-server (2:1.19.1-3) unstable; urgency=medium

  * rules: Fix setting suid bit on Xorg.wrap.
  * rules: Don't ignore errors when setting the suid bit.

xorg-server (2:1.19.1-2) unstable; urgency=medium

  * rules: Fix udeb regression from dh migration. Should also fix FTBFS
    on hurd and kfreebsd.
  * rules: Add --fail-missing to dh_install.
  * rules: Remove unused vars config_backend_main and
    config_backend_udeb.

xorg-server (2:1.19.1-1) unstable; urgency=medium

  [ Emilio Pozuelo Monfort ]
  * Switch to dh.
  * Drop build-deps on automake and libtool, dh-autoreconf depends on
    them for us.
  * rules: use install consistently.
  * Drop pre-wheezy Breaks.

  [ Andreas Boll ]
  * New upstream release.
    - AttendClient of grab-pervious client must queue to
      saved_ready_clients [v2] (Closes: #846779, #850940).
    - present: Only call present_flip_notify if vblank->queu...

Read more...

Changed in xorg-server (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.